From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id aFv3Jka0BGWDRAEAG6o9tA:P1 (envelope-from ) for ; Fri, 15 Sep 2023 21:45:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id aFv3Jka0BGWDRAEAG6o9tA (envelope-from ) for ; Fri, 15 Sep 2023 21:45:10 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 96E205FEB5 for ; Fri, 15 Sep 2023 21:45:09 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=TnR76C8H; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694807110; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=sWY0rxY2lWaf24GnZ6eT/swzebzSDQemJ2kLj99HBhE=; b=KG806ArVI7Lor5GzYUc1hz0LFlsOu3sIu80B5Q44amwSx8SwbNCJCNnZiosKI6RvDLq3nu pfO9XpuS29jcCmiDnLG8arenW/ipz9/zm8tdCzmRzdkA1vVvoKn/Zw+g6JnKmZiHrmOzU8 IXkrE/SMKMNcBbLMzzC4xNMIlRx7Fdc+Nmkb86+hr2yg7bwg9Ly8qJSk1HVZqGwDlPjVR7 73LvsQq4fBIXeaEtUv5mDdwxPQ+VwFlkLIdXeSdiXreAINvpuJi1yfM27fV1Ir+JOquv1C CFbtlLhZ7POowUq56dE4mt/gu61t/0MswHzZVjprYWIcBozL/yIkzJ778xr0AA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=TnR76C8H; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694807110; a=rsa-sha256; cv=none; b=hfIYhY5gGLRo58MAa64dQulGc/zLpr6Qbao8M6oZmHAvb5YPfZarp9DQinrcbjitLWmPmW WcXit1VBx5job85t+6u3ORMd/9vX2S/7lVX4Mg5O7v1yg3cFT8JwZrh92meXkeq4xAkgbC 6EpzPwvTmPX3vNiRATS7vIm8wVKtSzgHu7w6yn7sro2fSS3qjQ8ywQPwiq+cCr6grO2H8Y +iFznZ4L+d+RZmEiFy9SAUBl4EJEnjJtynFn6+fgJkp8qDHxPmbYQbgNxhWL8DcQYpdOIb f4AGT8Exjx7PylGx9MZxyamgaujYfjJ9MDR2cJYuZ3AhOssXDYdCn8iEMyskgA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qhEkL-0006Ev-Ez; Fri, 15 Sep 2023 15:44:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhEkJ-0006DJ-Uz for guix-patches@gnu.org; Fri, 15 Sep 2023 15:44:55 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qhEkJ-0007sr-N5 for guix-patches@gnu.org; Fri, 15 Sep 2023 15:44:55 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qhEkQ-0007tt-8z for guix-patches@gnu.org; Fri, 15 Sep 2023 15:45:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65755] [PATCH 0/3] Mark some packages as not supported on the hurd. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 15 Sep 2023 19:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65755 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: Marius Bakke , 65755@debbugs.gnu.org, Janneke Nieuwenhuizen Received: via spool by 65755-submit@debbugs.gnu.org id=B65755.169480705530291 (code B ref 65755); Fri, 15 Sep 2023 19:45:02 +0000 Received: (at 65755) by debbugs.gnu.org; 15 Sep 2023 19:44:15 +0000 Received: from localhost ([127.0.0.1]:44875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhEje-0007sU-V3 for submit@debbugs.gnu.org; Fri, 15 Sep 2023 15:44:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhEja-0007sC-8p for 65755@debbugs.gnu.org; Fri, 15 Sep 2023 15:44:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhEjM-0007VG-PE; Fri, 15 Sep 2023 15:43:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=sWY0rxY2lWaf24GnZ6eT/swzebzSDQemJ2kLj99HBhE=; b=TnR76C8H5YXOr/wPRGdX HZMIhgro1vuLsdt4z6hzMDv6DqFunlYc/KblfJwjTQNRHcvUlReUDu4GelK1dHD57rceWac1npjZY 5nkm/DgTbpndmwUmf1wLL5aEki/I+/CYVuHMsjFjba4w9UH4twLtZ8R5Iw8lGaSj/6yg28u8qLjEv RepWQXW6XxGvEDkFp4F+OnZW3XYOXpKYvSn+tuk2cNuRs7mtd3uz7dIL2Waooks02/bqQhLaOLpPZ 3cVjf86Q661rtbaaV/c7gv1CGbCUhMonN58nVPWYMM5BdLlF1N2qCBp7fG6mkmyJ1Jhb/g30qd326 2DF6LGUhPs5UmA==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <871qez1e59.fsf@gnu.org> <874jjvqmel.fsf@cbaines.net> Date: Fri, 15 Sep 2023 21:43:53 +0200 In-Reply-To: <874jjvqmel.fsf@cbaines.net> (Christopher Baines's message of "Fri, 15 Sep 2023 19:56:06 +0100") Message-ID: <87h6nv1ati.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: -2.11 X-Spam-Score: -2.11 X-Migadu-Queue-Id: 96E205FEB5 X-TUID: Xw38jt3PgNrR Christopher Baines skribis: > Janneke Nieuwenhuizen writes: > >> Marius found that building the updated "guix" package on the >> just-rebased hurd-team branch failed. >> >> It turns out that the packages.scm test on master fails notably: >> package-transitive-supported-systems, implicit inputs >> >> test-name: package-transitive-supported-systems, implicit inputs >> location: /home/janneke/src/guix/master/tests/packages.scm:496 >> source: >> + (test-equal >> + "package-transitive-supported-systems, implicit inputs" >> + %supported-systems >> + (let ((p (dummy-package >> + "foo" >> + (build-system gnu-build-system) >> + (supported-systems >> + `("does-not-exist" "foobar" ,@%supported-systems))))) >> + (parameterize >> + ((%current-system "armhf-linux")) >> + (package-transitive-supported-systems p)))) >> expected-value: ("x86_64-linux" "mips64el-linux" "aarch64-linux" "powerp= c64le-linux" "riscv64-linux" "i686-linux" "armhf-linux" "i586-gnu" "powerpc= -linux") >> actual-value: ("x86_64-linux" "mips64el-linux" "aarch64-linux" "powerpc6= 4le-linux" "riscv64-linux" "i686-linux" "armhf-linux" "powerpc-linux") >> result: FAIL [...] > I don't think there's anything wrong with adjusting the expectation to > have the test pass, but to me the longer term thing to do is look at > changing the code around supported systems. Agreed, we need to change the expected result to: (filter target-linux? %supported-systems) This is expected given that =E2=80=98%current-system=E2=80=99 is set to *-l= inux. > On not breaking tests when making changes though, I don't generally run > make check unless I'm changing code in guix/ but it would be nice to > start QA doing that for every patch series. Yes! > We should also probably try to avoid tests that break when making > changes to packages. We try to avoid it but there are a few cases where we test real packages that we hope rarely change. Thanks, Ludo=E2=80=99.