From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id MK83EY7LEmUJdQEA9RJhRA:P1 (envelope-from ) for ; Tue, 26 Sep 2023 14:16:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id MK83EY7LEmUJdQEA9RJhRA (envelope-from ) for ; Tue, 26 Sep 2023 14:16:14 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 29AB85FEBE for ; Tue, 26 Sep 2023 14:16:14 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=nCNtDtIe; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1695730574; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=soW8m1Mwb6bCeQ1rn7YxNSjIOKLRF0BpjBg0wdRCMiw=; b=OBkS22sHcbqMk/KDCO7YL1115Pj8CGop5dD2WYSHjwUvJCSbI+TjqN/yioJY3XHaxctLRP l5w12FPxw8pzyuFHgV+nKsk4pDI+9E6F8VPIMORorDQXpET5/TfkBG8tXyWd5GWaOHeCiG tnzYmZYgCit9ilgQGe6gpjyN78oih6Rdllhp7iwAOjBEdQV047htuJGrb9BjMlDZj1tftU +OGXMIIxnY+c2WKKlaIl5sZVDBenMxlpJuzU7JWAV4v/4u1DHmeoJY8HRxKVWHdmK06t57 IALG1wfoZVDLppFPMBJezgAe2nMtlQfcKYsrKVIN4sV7vdnm99oWGJTigsdWLw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1695730574; a=rsa-sha256; cv=none; b=kbw47GlC0YqgLj6RqyOflER5s3iJIcSjdfrZOTkgMgKMmUMm2UCSMtN2KdGGKWhD1dGLY5 +sRH31Zf9xQ9O3jiKq0vkL6adCNTYYcp+ujWAOiX4l1DF6YdSEUTDbk3Qn8qe1S4tRJsQz dTQriYTtoxQteRRa2xikqxa83u8Cp08Iq9UIBgR/BFPMKmFkroytBeuynnTJIjh8Th7i96 SGKZPSBiyK3t0N8y8A8ieTYLfqnuyiFOGdPDprSDsxqzFY8n0/RHaRtyvGbX4X3r0Kc5bU SLEGMYpfnsTX87p/PMDXvmiPpIzjY0/dihbkXoDP/Km0b35k48oqzAPZyCvktg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=nCNtDtIe; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ql6yl-0000Tx-Sq; Tue, 26 Sep 2023 08:15:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ql6yk-0000Te-4Z for guix-patches@gnu.org; Tue, 26 Sep 2023 08:15:50 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ql6yj-0001MT-Sz for guix-patches@gnu.org; Tue, 26 Sep 2023 08:15:49 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ql6yw-0008LG-Qo for guix-patches@gnu.org; Tue, 26 Sep 2023 08:16:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66199] [PATCH] gnu: librepcb: Update to 1.0.0. Resent-From: pinoaffe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 26 Sep 2023 12:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66199 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vinicius Monego Cc: 66199@debbugs.gnu.org Received: via spool by 66199-submit@debbugs.gnu.org id=B66199.169573054132013 (code B ref 66199); Tue, 26 Sep 2023 12:16:02 +0000 Received: (at 66199) by debbugs.gnu.org; 26 Sep 2023 12:15:41 +0000 Received: from localhost ([127.0.0.1]:47520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ql6yb-0008KG-BE for submit@debbugs.gnu.org; Tue, 26 Sep 2023 08:15:41 -0400 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]:47380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ql6yV-0008Jr-JD for 66199@debbugs.gnu.org; Tue, 26 Sep 2023 08:15:39 -0400 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-9b0168a9e05so828239066b.3 for <66199@debbugs.gnu.org>; Tue, 26 Sep 2023 05:15:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695730516; x=1696335316; darn=debbugs.gnu.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=soW8m1Mwb6bCeQ1rn7YxNSjIOKLRF0BpjBg0wdRCMiw=; b=nCNtDtIemtsNwxcv35aJuQYaDgLiveXwNwUY5FERyDX9uF8HEhQrvBN1ya0sqrKMoB TEQJjc6kjdq+PafgXrmHAqdR65lwnM0jU5hKl87y59cnYGyGgkRQyKoTXV1gk+Aw+aLa aY/cNv4WFRuXUJeAYF0eunOR5IenHantmq5Ke6/T3a/sMTaAjHxJQnwH/uBqRuCjI45k ks7AnzeGPgWSfqIWKmCoFPEr9KNZ3mxAvR7vf1VPkARktTcE9pMq7bliNgDAjzOlWQSD YCpEkGuIr4LkI5co5bcCwmwFON+fckzMldhVvyGD+AfZPewL6TnGAk0XeQoptXwsXZDx gVMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695730516; x=1696335316; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=soW8m1Mwb6bCeQ1rn7YxNSjIOKLRF0BpjBg0wdRCMiw=; b=TVHHb0UOhAPZXihK8SmBBibLQXyckapt0NWcGTDEyeuMIrO5JIdUkysKfv7Of7mivH K2f5GaRX5Iz15pMnWE/EARIE0osZwNibPA3gxEyWHX5XXao1Bpj0Nc3VJV+dhhUG64O7 qBfFWpxKyoLIW99BhN531ihJlGUCSHj+BVzleIqPAZrBLjYusSafWUsM93P29irn9vgs 2dwsddxgZwuzAPK6tQSZAcowcFu+tHfsNbZhstznRrNpgoIzTeRomP/pLwNCFMgxGz1V DxvXA+VL3AHHqdPVq1xDRmJw/QgCxJTPRsJvh3bRCZXQA9xpEviukwgBYMCDTo8VZF3/ uGcQ== X-Gm-Message-State: AOJu0YwJSYKl9+34t6MPvNx+fzjl5zeNoABI8NOrVsb+oACONHJlUVlk /f1dMywBBkP6Nv4ck87pQas= X-Google-Smtp-Source: AGHT+IG4mCpr30aJpT7Fy8mfpdSWLnYnZaKvMjpO9rXsbmddP3SDljOxx4Iq83B8AEegPuvxtt9seQ== X-Received: by 2002:a17:906:53d8:b0:9ae:5643:6493 with SMTP id p24-20020a17090653d800b009ae56436493mr8271966ejo.74.1695730516107; Tue, 26 Sep 2023 05:15:16 -0700 (PDT) Received: from localhost (h120217.upc-h.chello.nl. [62.194.120.217]) by smtp.gmail.com with ESMTPSA id sa21-20020a170906edb500b009add084a00csm7647071ejb.36.2023.09.26.05.15.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 05:15:15 -0700 (PDT) References: <3e28337e7ead18b49e5e2e99d0e3d1d22e3f9d47.1695673614.git.pinoaffe@gmail.com> <2f4f0210-ea10-27e0-55fc-ccd55e807576@posteo.net> User-agent: mu4e 1.10.5; emacs 28.2 From: pinoaffe Date: Tue, 26 Sep 2023 14:08:23 +0200 In-reply-to: <2f4f0210-ea10-27e0-55fc-ccd55e807576@posteo.net> Message-ID: <87h6nhdtbh.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -5.06 X-Spam-Score: -5.06 X-Migadu-Queue-Id: 29AB85FEBE X-TUID: djZ6vs41+GRg Hi, thank you for your review! Vinicius Monego writes: > The commit message should also mention the switch to > cmake-build-system, the "not overriding" of the configure phase, the > new inputs and the test skip.. I wasn't sure how to phrase / format this, is what I arrived at OK? > Inputs should be sorted alphabetically. Done > The comment about lrelease can be removed as lrelease is not being > manually invoked anymore, and the native inputs list can be squashed > in one line. Done > There are options in LibrePCB's CMakeLists.txt to unvendor some > dependencies: > https://github.com/LibrePCB/LibrePCB/blob/9edb6ede393e5b48785f95252f81a027db4b718a/CMakeLists.txt#L51 I unvendored all of the mentioned dependencies apart from dxflib (I couldn't get it to build). > The only dependencies we do not have is dxflib and fontobene-qt5. It > failed to find muparser and polyclipping ('clipper' package in Guix), > I don't know why. Adding pkg-config as a native dependency seems to have done the trick > It would be best to unvendor as many dependencies as possible. Could > you send an updated patch? Optionally, you can try to package > fontobene-qt5 and have cmake find muparser and polyclipping. I'll send some updated patches in a minute Kind regards, pinoaffe