unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: rg@raghavgururajan.name, 66481@debbugs.gnu.org
Subject: [bug#66481] [PATCH gnome-team] gnu: tracker-miners: Update to 3.6.1.
Date: Thu, 12 Oct 2023 13:31:30 -0400	[thread overview]
Message-ID: <87h6mv7nnx.fsf@gmail.com> (raw)
In-Reply-To: <8d1afe5f376a0b3174023fc23cf6a61c70c54a46.camel@gmail.com> (Liliana Marie Prikler's message of "Thu, 12 Oct 2023 16:38:49 +0200")

Hi,

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

> Am Donnerstag, dem 12.10.2023 um 10:21 -0400 schrieb Maxim Cournoyer:
>> Hello,
>> 
>> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
>> 
>> > * gnu/packages/gnome.scm (tracker-miners): Update to 3.6.1.
>> 
>> LGTM.  I think this is a small change enough that it doesn't need to
>> go through guix-patches (you could have pushed it already).
> IIUC the exception for small patches is no longer part of the manual. 
> Plus, with the recent kerfluffle around tracker-miners, I prefer a
> review :)

The relevant bits from info '(guix) managing patches and branches' is
this:

> As an exception, some changes considered “trivial” or “obvious” may be
> pushed directly to the ‘master’ branch.  This includes changes to fix
> typos and reverting commits that caused immediate problems.  This is
> subject to being adjusted, allowing individuals to commit directly on
> non-controversial changes on parts they’re familiar with.

It mentions 'master' there but I think this was an oversight; the same
should hold for any branch.  And I think bumping a version field and the
hash is non-controversial enough if it doesn't break the world and was
tested :-).

-- 
Thanks,
Maxim




      reply	other threads:[~2023-10-12 18:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-11 20:23 [bug#66481] [PATCH gnome-team] gnu: tracker-miners: Update to 3.6.1 Liliana Marie Prikler
2023-10-11 20:23 ` [bug#66481] [PATCH gnome-team v2] " Liliana Marie Prikler
2023-11-15 21:45   ` bug#66481: " Liliana Marie Prikler
2023-10-12 14:21 ` [bug#66481] [PATCH gnome-team] " Maxim Cournoyer
2023-10-12 14:38   ` Liliana Marie Prikler
2023-10-12 17:31     ` Maxim Cournoyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6mv7nnx.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=66481@debbugs.gnu.org \
    --cc=liliana.prikler@gmail.com \
    --cc=rg@raghavgururajan.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).