From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id mH4oLzdAKWVDFwAAauVa8A:P1 (envelope-from ) for ; Fri, 13 Oct 2023 15:03:51 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id mH4oLzdAKWVDFwAAauVa8A (envelope-from ) for ; Fri, 13 Oct 2023 15:03:51 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6C76C729B5 for ; Fri, 13 Oct 2023 15:03:51 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Svo3qkdO; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1697202231; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=NEr3hAiqkWfYwJItTiQNh1reswKNV9O0D6cbCVaseIM=; b=ekYZjj/WyksxFHxgJX8vc+oICZY1Ocycqtr9wiNj4SpbhVpZ6n55OQJEAXR0+F0OtH/0fS X4l5UpbZileqG5LEiNY3Tw/I9vSFZA2mh/6lt3eb4gpnGZXZ94TPu1wgO/jZkz3QY0bYAa JQwtZhzUGEqIQ0rf/JYEstvb/gGmKw3jugmxfPvprnR4AYOt4mCCIP6BlLBvaOUnP6qIYF 89mTQDjexBkiB8bgHr9y3e2smoiCisyLiFDa48ETGHnUYdcmalrwnF4tGQBTXs4GGdPQDN kGFreECeABpirBSnc238M3WglcmZ2gvkpRajaUzqpy8MMDfBt8p97ZG7ElQLxg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1697202231; a=rsa-sha256; cv=none; b=GVP2WOg8k6ke6N51A56iHDmWaTp/0+qm3K6ahJn+I505/AOAsLxDG4Gtj6izcCkUaQVxfV uc8LosJkiZcZva9AcS5n9TRNsGJhzqhXI3r68RrT5hE1c70Ngoyapi5rIICn+AdaAiK0X5 0yycUsa2Dc6RxTfEk8mN4FNR8tix1PQE7/lgFRmJIPdHDNeKljFLetivPfFtXMbiEhkOoc Vnrx3mmlrJXIgJCj2B2CrSCrlC+tLg7JeYO0gcqX2hH5OWVQBmembzuMLq5oCgcJd2KFTF Br5yMh5Au/yokBphRiLn74pMLpF/M0NtXs2EsjtdstMs841M2P2+YQ6IJfjZTg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Svo3qkdO; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qrHpN-0004Qy-Ey; Fri, 13 Oct 2023 09:03:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrHpL-0004H0-Eo for guix-patches@gnu.org; Fri, 13 Oct 2023 09:03:39 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qrHpL-00042B-5y for guix-patches@gnu.org; Fri, 13 Oct 2023 09:03:39 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qrHph-0004SW-PT for guix-patches@gnu.org; Fri, 13 Oct 2023 09:04:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66448] [PATCH] image: Add 'lba partition label. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 13 Oct 2023 13:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66448 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Gabriel Wicki Cc: 66448@debbugs.gnu.org Received: via spool by 66448-submit@debbugs.gnu.org id=B66448.169720218517062 (code B ref 66448); Fri, 13 Oct 2023 13:04:01 +0000 Received: (at 66448) by debbugs.gnu.org; 13 Oct 2023 13:03:05 +0000 Received: from localhost ([127.0.0.1]:45462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrHom-0004R7-Vh for submit@debbugs.gnu.org; Fri, 13 Oct 2023 09:03:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53838) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrHoj-0004Qb-46 for 66448@debbugs.gnu.org; Fri, 13 Oct 2023 09:03:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrHoF-0003qP-8Y; Fri, 13 Oct 2023 09:02:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=NEr3hAiqkWfYwJItTiQNh1reswKNV9O0D6cbCVaseIM=; b=Svo3qkdOR6g6t4PthG9M +AupEd2ghxQ7CU3gRHU/KTiM/lSdgOhd8kpDlFkvZypCME0rFOKMz4oo1BMwO6LWyuDggDZ6zPG/T 0F3Z/aiCJMR6tpSIlV3qt6Ur6FaHneRmjSk4I0zvOD3+r0hwQHGHMl7PfkXysJWmZeX3UDcQVEOhO u9A+fx4FPAF3y59jVMEwL5Nr3teTpoIRIMKcT2lNxivfKByccB2AGK9Cy/9QCYFHRtap56wMKXqjD hiYrGmz1OWd0kkj60jNaI5bQQmRQsOYNThRy3ZLiHnbzxowlE0cxygiXLLHiHl84Cnxr0/crZKHds GA0yNbppvTgQYQ==; From: Mathieu Othacehe References: <87o7h58ruw.fsf@gnu.org> Date: Fri, 13 Oct 2023 15:02:25 +0200 In-Reply-To: (Gabriel Wicki's message of "Wed, 11 Oct 2023 10:55:23 +0200") Message-ID: <87h6mud6am.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: -3.88 X-Migadu-Queue-Id: 6C76C729B5 X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -3.88 X-TUID: hi+JacIiid1l Hello, > I didn't follow the whole source tree to figure out how all of this > works, but this tiny change makes the image partition show up as LBA. I had a closer look, this flag has no effect at all. If the 'esp flag is set then the MBR partition type is set to 0xEF (EFI partition). If the flag is removed, then depending on the file-system type: "fat16" or "fat32", the partition type will be 0x0E or 0x0C which are respectively FAT16 with LBA an FAT32 with LBA. I guess that by removing the 'esp flag and adding the 'lba flag you ended up with an LBA partition. That was the consequence of removing the 'esp flag, not adding the 'lba flag. The partition type is specified in the partition->dos-type procedure of (gnu system image). The corresponding types can be found here: https://en.wikipedia.org/wiki/Partition_type. We could improve the documentation here by stating that fat16 and fat32 partitions are by default LBA compatible, but the source modification in not needed. Thanks, Mathieu