unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Sergey Trofimov <sarg@sarg.org.ru>
To: Christopher Baines <mail@cbaines.net>
Cc: 67176@debbugs.gnu.org
Subject: [bug#67176] [PATCH] gnu: openvpn: Update to 2.6.7.
Date: Sat, 02 Dec 2023 14:47:10 +0100	[thread overview]
Message-ID: <87h6l0iu8j.fsf@sarg.org.ru> (raw)
In-Reply-To: <87bkbkv9pq.fsf@cbaines.net>


Christopher Baines <mail@cbaines.net> writes:

... omitted
>>      (arguments
>>       '(#:configure-flags '("--enable-iproute2=yes")))
>>      (native-inputs
>> -     (list iproute))
>> -    (inputs
>> -     (list lz4 lzo openssl linux-pam))
>> +     (append
>> +      (if (target-linux?) (list pkg-config) '())
>> +      (list iproute)))
>> +    (inputs (append
>> +             (if (target-linux?) (list libcap-ng) '())
>> +             (list lz4 lzo openssl linux-pam)))
>
> These changes could do with mentioning in the commit message, 
> since it's
> not immediately clear what you're trying to do?
>

Hey, sorry for responding lately. I've just noticed your mail 
ended in gmail's spam folder.

So libcap-ng is required only for linux as could be seen here:
https://github.com/OpenVPN/openvpn/blob/753cba211c4752ef13d810b757f1aa7dee89626b/CMakeLists.txt#L261

Though pkg-config seems to be mandatory. It is present on every 
platform, right? Let me fix that.




  reply	other threads:[~2023-12-02 13:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-14 15:02 [bug#67176] [PATCH] gnu: openvpn: Update to 2.6.7 Sergey Trofimov
2023-11-23 14:13 ` Christopher Baines
2023-12-02 13:47   ` Sergey Trofimov [this message]
2023-12-02 17:24 ` [bug#67176] [PATCH v1] " Sergey Trofimov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6l0iu8j.fsf@sarg.org.ru \
    --to=sarg@sarg.org.ru \
    --cc=67176@debbugs.gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).