From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id mPn0FAMzdmXXJAEAG6o9tA:P1 (envelope-from ) for ; Sun, 10 Dec 2023 22:52:03 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id mPn0FAMzdmXXJAEAG6o9tA (envelope-from ) for ; Sun, 10 Dec 2023 22:52:03 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=H6haOoMY; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1702245123; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=lxHsBYdDporDJXbwWL52gKlszwpwUMp/6ObVSlIcPA4=; b=ioHhCObWKR4ShHp6eP7lzwr6/Hjpc4ggpBYM4tfcuySOesJVnt6o8oZb5XkvORf+MUxNqJ FZiM6HFBHgUdcxokUjbBu2wvewcfoBqHNw2J9570D7NJNAyrRYxC9GMCKn5eyeUXoICYUb ScDGnECWzwWBR8xxDHnUdCko69VHeqRkKm1CwApjNi5tuVQhYOuNCFTYy+n53UiIo+TBBk xG7/bSqp5CISXMcHvyGzkVoyi157xgJ5q8JSJo8aBxLhiw3MR4KQlLjWOOZjyrF+HMOhOY M2+qNWfuh2jFTDOel0oyDYD6KudSySkdV5dsOaRmU/vt2r/GjBv20rsvosJWaw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1702245123; a=rsa-sha256; cv=none; b=enywvBLXx65tewjP8szpr+aucz0/MPw4Bi4ImtvgHGA1SJad6oTrZVs2b/E70owehmYT5J XVLq/8Ci1w/JiNVJkCElzfo1kk29qwc8bwmTYp1RL2wpckjH8BWTqJRpHBD5/XTVJzbhIa 8eE09IOarZnhAWKyNJhUXYjhD7hSBlFAbpuw2OCQ5YCB7eIL3szhloowPNUN4rSXnOE0H5 dwtBi7SBk9VqavvXIY3rwm9MpS8K5sIwJbdKl0oTxqj7WD0uFyAai5SkbYWHEjsaYfETD4 8w4KZvqgn8YSHKM0IMiL2tjXfSRNT0p3YP4654MobPsRQ5FXz/h9kZLXlXasJQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=H6haOoMY; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 19B1F38366 for ; Sun, 10 Dec 2023 22:52:03 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rCRiI-0002fq-1D; Sun, 10 Dec 2023 16:51:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCRiG-0002fe-4b for guix-patches@gnu.org; Sun, 10 Dec 2023 16:51:48 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rCRiF-00019r-Sr for guix-patches@gnu.org; Sun, 10 Dec 2023 16:51:47 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rCRiU-0006WB-2A for guix-patches@gnu.org; Sun, 10 Dec 2023 16:52:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67733] [PATCH v3] daemon: Sacrifice builders on OOM. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 10 Dec 2023 21:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67733 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tobias Geerinckx-Rice Cc: 67733@debbugs.gnu.org Received: via spool by 67733-submit@debbugs.gnu.org id=B67733.170224509925023 (code B ref 67733); Sun, 10 Dec 2023 21:52:02 +0000 Received: (at 67733) by debbugs.gnu.org; 10 Dec 2023 21:51:39 +0000 Received: from localhost ([127.0.0.1]:51885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCRi7-0006VX-Fy for submit@debbugs.gnu.org; Sun, 10 Dec 2023 16:51:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCRi5-0006VJ-16 for 67733@debbugs.gnu.org; Sun, 10 Dec 2023 16:51:38 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCRhl-000181-Aq; Sun, 10 Dec 2023 16:51:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=lxHsBYdDporDJXbwWL52gKlszwpwUMp/6ObVSlIcPA4=; b=H6haOoMYyKjqmxfVhz9x J96UZzNVilyJ69Lc7x42gGzOLkcBsNXLCrHKGvh91L6oqkyQWA+7OwPBBTaupu2FghNRViPFEVjcu gLPsKWl39VJNI8p/DDJ7/FddE8OOyLcWE7+nu1hkvq8iRZ1/hQcqUSQLdmqWEpKeZ98nX3vTRcX50 xr1ZKyffpu7iM5rV3RdkMwuuw67iCX+9HR5yoy3+JUQV+G4Mu8c9xF/WMewzuab5b81eD+Vn1augu 2DIMcdb/gkCDNjHG5Q/OSDWJKqP2MNs6ks2Mb7N0jufkLOYDypfZqXqOfiV/M+ma4QYswkjrj1e9F judGgt4dXxVk0Q==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <20231203000111.30681-1-me@tobias.gr> (Tobias Geerinckx-Rice's message of "Sun, 3 Dec 2023 01:00:01 +0100") References: <20231203000032.29995-1-me@tobias.gr> <20231203000111.30681-1-me@tobias.gr> Date: Sun, 10 Dec 2023 22:51:15 +0100 Message-ID: <87h6kp3ewc.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -2.11 X-Spam-Score: -2.11 X-Migadu-Queue-Id: 19B1F38366 X-Migadu-Scanner: mx11.migadu.com X-TUID: ejWKkWge7D8G Hullo! Tobias Geerinckx-Rice skribis: > * nix/libstore/build.cc (DerivationGoal::runChild): > Maximise our OOM score adjustment. > > Change-Id: I418c763b499ca16e1ffe3c6033319112b9744f51 > --- > > v3: In my defens, I'm on a fone. Nooo, you=E2=80=99re a hero. > + /* Ask the kernel to eagerly kill us & our children if it runs out of > + memory, regardless of blame, to preserve =E2=80=98real=E2=80=99 user= data & state. */ > + try { > + writeFile("/proc/self/oom_score_adj", "1000"); // 100% > + } catch (...) { ignoreException(); } Sounds like a good idea. LGTM! Ludo=E2=80=99.