unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#64813] [PATCH] gnu: Add python-manimpango.
@ 2023-07-23 20:57 Wamm K. D
  2023-08-16 20:35 ` Ludovic Courtès
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Wamm K. D @ 2023-07-23 20:57 UTC (permalink / raw)
  To: 64813; +Cc: Wamm K. D

* gnu/packages/python-xyz.scm (python-manimpango): New variable.
---
 gnu/packages/python-xyz.scm | 22 +++++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index db3e69fb45..14cb375a8a 100644

Right now, the tests are failing with "No module named 'manimpango.cmanimpango'";
it's clearly trying to import the package so it can use it for testing but the
test files are failing to find it (it looks like the "cmanimpango" file is a C
file (along with .pxd and .pyx files) so maybe it's Cython related?).

Is there a way we usually handle this for Python/Cython packages?
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -119,7 +119,7 @@
 ;;; Copyright © 2022 Evgeny Pisemsky <evgeny@pisemsky.com>
 ;;; Copyright © 2022 drozdov <drozdov@portalenergy.tech>
 ;;; Copyright © 2022 Peter Polidoro <peter@polidoro.io>
-;;; Copyright © 2022 Wamm K. D. <jaft.r@outlook.com>
+;;; Copyright © 2022, 2023 Wamm K. D. <jaft.r@outlook.com>
 ;;; Copyright © 2022 Jai Vetrivelan <jaivetrivelan@gmail.com>
 ;;; Copyright © 2022 Artyom V. Poptsov <poptsov.artyom@gmail.com>
 ;;; Copyright © 2022 Paul A. Patience <paul@apatience.com>
@@ -9292,6 +9292,26 @@ (define-public python-xcffib
 support for Python 3 and PyPy.  It is based on cffi.")
     (license license:expat)))
 
+(define-public python-manimpango
+  (package
+    (name "python-manimpango")
+    (version "0.4.3")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "ManimPango" version))
+              (sha256 (base32
+                       "00x1l55wy0k6v3b6l2g5603zk5d5dab59fwkxq6jq4ncifwiqbvk"))))
+    (build-system pyproject-build-system)
+    (native-inputs (list pkg-config python-cython python-pytest))
+    (inputs (list pango))
+    (home-page "https://pypi.org/project/ManimPango/")
+    (synopsis "Bindings for Pango for using with Manim.")
+    (description "Python bindings for ManimPango which is a C binding for Pango,
+using Cython.
+
+ManimPango is internally used in Manim to render (non-LaTeX) text.")
+    (license license:expat)))
+
 (define-public python-cairocffi
   (package
     (name "python-cairocffi")
-- 
2.41.0





^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#64813] [PATCH] gnu: Add python-manimpango.
  2023-07-23 20:57 [bug#64813] [PATCH] gnu: Add python-manimpango Wamm K. D
@ 2023-08-16 20:35 ` Ludovic Courtès
  2023-12-16 19:24 ` Troy Figiel
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2023-08-16 20:35 UTC (permalink / raw)
  To: Wamm K. D; +Cc: 64813

Hi,

"Wamm K. D" <jaft.r@outlook.com> skribis:

> * gnu/packages/python-xyz.scm (python-manimpango): New variable.
> ---
>  gnu/packages/python-xyz.scm | 22 +++++++++++++++++++++-
>  1 file changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index db3e69fb45..14cb375a8a 100644
>
> Right now, the tests are failing with "No module named 'manimpango.cmanimpango'";
> it's clearly trying to import the package so it can use it for testing but the
> test files are failing to find it (it looks like the "cmanimpango" file is a C
> file (along with .pxd and .pyx files) so maybe it's Cython related?).
>
> Is there a way we usually handle this for Python/Cython packages?

I don’t know if there are specific tricks here, though maybe you could
grep around or look for other packages that depend on Cython?

HTH,
Ludo’.




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#64813] [PATCH] gnu: Add python-manimpango.
  2023-07-23 20:57 [bug#64813] [PATCH] gnu: Add python-manimpango Wamm K. D
  2023-08-16 20:35 ` Ludovic Courtès
@ 2023-12-16 19:24 ` Troy Figiel
  2023-12-16 19:26 ` [bug#64813] (no subject) Troy Figiel
  2024-01-20 21:42 ` bug#64813: [PATCH] gnu: Add python-manimpango Sharlatan Hellseher
  3 siblings, 0 replies; 5+ messages in thread
From: Troy Figiel @ 2023-12-16 19:24 UTC (permalink / raw)
  To: 64813

* gnu/packages/python-xyz.scm (python-manimpango): New variable.

Change-Id: I5ee6faa9cfd51a173f73d03c5c18e3c7d399582a
---
 gnu/packages/python-xyz.scm | 35 ++++++++++++++++++++++++++++++++++-
 1 file changed, 34 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 86f8d81689..6bc02393e0 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -119,7 +119,7 @@
 ;;; Copyright © 2022 Evgeny Pisemsky <evgeny@pisemsky.com>
 ;;; Copyright © 2022 drozdov <drozdov@portalenergy.tech>
 ;;; Copyright © 2022 Peter Polidoro <peter@polidoro.io>
-;;; Copyright © 2022 Wamm K. D. <jaft.r@outlook.com>
+;;; Copyright © 2022, 2023 Wamm K. D. <jaft.r@outlook.com>
 ;;; Copyright © 2022 Jai Vetrivelan <jaivetrivelan@gmail.com>
 ;;; Copyright © 2022 Artyom V. Poptsov <poptsov.artyom@gmail.com>
 ;;; Copyright © 2022 Paul A. Patience <paul@apatience.com>
@@ -9615,6 +9615,39 @@ (define-public python-pywinrm
 any machine that can run Python.")
     (license license:expat)))
 
+(define-public python-manimpango
+  (package
+    (name "python-manimpango")
+    (version "0.5.0")
+    (source
+     (origin
+       ;; Test fixtures are not included in the PyPI tarball. We need the Github
+       ;; release to successfully run the tests.
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/ManimCommunity/ManimPango")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "00mrvswk8yly0m13jq0f432pr19sy3j6w37lrv78ah1j6jz9n50h"))))
+    (build-system pyproject-build-system)
+    (arguments
+     '(#:phases (modify-phases %standard-phases
+                  (add-before 'check 'build-extensions
+                    (lambda _
+                      (invoke "python" "setup.py" "build_ext" "--inplace"))))))
+    (native-inputs (list pkg-config python-cython python-pytest
+                         python-pytest-cov))
+    (inputs (list pango))
+    (home-page "https://pypi.org/project/ManimPango/")
+    (synopsis "Bindings for Pango for using with Manim")
+    (description
+     "Python bindings for ManimPango which is a C binding for Pango,
+using Cython.
+
+ManimPango is internally used in Manim to render (non-LaTeX) text.")
+    (license license:expat)))
+
 (define-public python-xcffib
   (package
     (name "python-xcffib")

base-commit: d5298c5e334e56a9aabddcb62d312e63135864f6
-- 
2.40.1





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#64813] (no subject)
  2023-07-23 20:57 [bug#64813] [PATCH] gnu: Add python-manimpango Wamm K. D
  2023-08-16 20:35 ` Ludovic Courtès
  2023-12-16 19:24 ` Troy Figiel
@ 2023-12-16 19:26 ` Troy Figiel
  2024-01-20 21:42 ` bug#64813: [PATCH] gnu: Add python-manimpango Sharlatan Hellseher
  3 siblings, 0 replies; 5+ messages in thread
From: Troy Figiel @ 2023-12-16 19:26 UTC (permalink / raw)
  To: 64813

Hi both of you,

I took the liberty to

- fix the build (the extensions still needed to be built)
- upgrade to the latest release
- rebase on master

Hope this helps!

Best wishes,

Troy




^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#64813: [PATCH] gnu: Add python-manimpango.
  2023-07-23 20:57 [bug#64813] [PATCH] gnu: Add python-manimpango Wamm K. D
                   ` (2 preceding siblings ...)
  2023-12-16 19:26 ` [bug#64813] (no subject) Troy Figiel
@ 2024-01-20 21:42 ` Sharlatan Hellseher
  3 siblings, 0 replies; 5+ messages in thread
From: Sharlatan Hellseher @ 2024-01-20 21:42 UTC (permalink / raw)
  To: 64813-done

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]


I've added Co-author-by Troy Figiel <troy@troyfigiel.com>, updated home-page to
https://manimpango.manim.community/, applied G-Expressions package style.

Pushed as 782d69fb7f88eeb5ea470f365d8ecbc761dfa1ff

Thanks,
Oleg

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-01-20 21:43 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-23 20:57 [bug#64813] [PATCH] gnu: Add python-manimpango Wamm K. D
2023-08-16 20:35 ` Ludovic Courtès
2023-12-16 19:24 ` Troy Figiel
2023-12-16 19:26 ` [bug#64813] (no subject) Troy Figiel
2024-01-20 21:42 ` bug#64813: [PATCH] gnu: Add python-manimpango Sharlatan Hellseher

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).