On 2024-03-02, Troy Figiel wrote: > diff --git a/gnu/packages/python-science.scm b/gnu/packages/python-science.scm > index b6a116f16b..93b5c5c91d 100644 > --- a/gnu/packages/python-science.scm > +++ b/gnu/packages/python-science.scm ... > @@ -836,14 +836,7 @@ (define-public python-pandera > (commit (string-append "v" version)))) > (file-name (git-file-name name version)) > (sha256 > - (base32 "1mnqk583z90k1n0z3lfa4rd0ng40v7hqfk7phz5gjmxlzfjbxa1x")) > - (modules '((guix build utils))) > - ;; These tests require PySpark and Modin. We need to remove the entire > - ;; directory, since the conftest.py in these directories contain > - ;; imports. (See: https://github.com/pytest-dev/pytest/issues/7452) > - (snippet '(begin > - (delete-file-recursively "tests/pyspark") > - (delete-file-recursively "tests/modin"))))) > + (base32 "14b5aij5zjkwvsimg0v00qvp59mhhq7ljim4qghcn432vkg9gh47")))) > (build-system pyproject-build-system) > (arguments > (list > @@ -854,7 +847,16 @@ (define-public python-pandera > ;; positives. These tests currently fail. > "not test_python_std_list_dict_generics" > " and not test_python_std_list_dict_empty_and_none" > - " and not test_pandas_modules_importable")))) > + " and not test_pandas_modules_importable")) > + #:phases #~(modify-phases %standard-phases > + (add-before 'check 'fix-tests > + (lambda _ > + ;; These tests require PySpark and Modin. We need to > + ;; remove the entire directory, since the conftest.py > + ;; in these directories contain imports. (See: > + ;; https://github.com/pytest-dev/pytest/issues/7452) > + (for-each delete-file-recursively > + '("tests/pyspark" "tests/modin"))))))) > ;; Pandera comes with a lot of extras. We test as many as possible, but do > ;; not include all of them in the propagated-inputs. Currently, we have to > ;; skip the pyspark and io tests due to missing packages python-pyspark Any compelling reason why the test removal should be moved from a snippet to a phase? The documentation admits to this being an elusive distinction, not really clearing things up much: https://guix.gnu.org/en/manual/devel/en/guix.html#Snippets-versus-Phases Other than that, this looks like a trivial version bump. :) Builds fine, no dependents... live well, vagrant