unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: 69778@debbugs.gnu.org, rg@raghavgururajan.name,
	Vivien Kraus <vivien@planete-kraus.eu>
Subject: [bug#69778] [PATCH gnome-team] gnu: telegram: Build with glibmm@2.76.
Date: Sat, 16 Mar 2024 21:30:15 -0400	[thread overview]
Message-ID: <87h6h5prvc.fsf@gmail.com> (raw)
In-Reply-To: <9a216319058f8b61f725bb09d3849bee7406248c.camel@gmail.com> (Liliana Marie Prikler's message of "Wed, 13 Mar 2024 22:59:14 +0100")

Hi,

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

> Am Mittwoch, dem 13.03.2024 um 17:45 +0100 schrieb Vivien Kraus:
>> * gnu/packages/telegram.scm (glibmm-for-telegram-desktop): New
>> variable.
>> (telegram-desktop): Use glibmm-for-telegram-desktop instead of
>> glibmm.
>> 
>> Change-Id: I0ec4ebc549dd867db22d68ee6317d1630cf1bfd8
>> ---
>> 
>> Dear Guix,
>> 
>> While we are waiting for the telegram-desktop update in #67493, here
>> is a minimally intrusive way to keep it working on gnome-team, by
>> using an older version of glibmm.
>> 
>> Best regards,
>> 
>> Vivien
>> 
>>  gnu/packages/telegram.scm | 19 ++++++++++++++++++-
>>  1 file changed, 18 insertions(+), 1 deletion(-)
>> 
>> diff --git a/gnu/packages/telegram.scm b/gnu/packages/telegram.scm
>> index 7d02824efa..16d36b2c7c 100644
>> --- a/gnu/packages/telegram.scm
>> +++ b/gnu/packages/telegram.scm
>> @@ -74,7 +74,9 @@ (define-module (gnu packages telegram)
>>    #:use-module ((guix licenses) #:prefix license:)
>>    #:use-module (guix packages)
>>    #:use-module (guix gexp)
>> +  #:use-module (guix download)
>>    #:use-module (guix git-download)
>> +  #:use-module (guix utils)
>>    #:use-module (guix build-system cmake)
>>    #:use-module (guix build-system copy)
>>    #:use-module (guix build-system glib-or-gtk)
>> @@ -267,6 +269,21 @@ (define tgcalls-for-telegram-desktop
>>       (base32
>>        "193m2gkvipijqbfd6a8mhg9nd63wlnshzgspk3pip57vk21l709z"))))
>>  
>> +(define-public glibmm-for-telegram-desktop
>> +  (hidden-package
>> +   (package
>> +     (inherit glibmm)
>> +     (name "glibmm-for-telegram-desktop")
>> +     (version "2.76.0")
>> +     (source (origin
>> +               (method url-fetch)
>> +               (uri (string-append "mirror://gnome/sources/glibmm/"
>> +                                   (version-major+minor version)
>> +                                   "/glibmm-" version ".tar.xz"))
>> +               (sha256
>> +                (base32
>> +                
>> "1cia8vrpwzn8zwalws42mga5hi965840m5s8dvfzv55xx86dhdw6")))))))
>> +
> Canonically, inherited packages are put in the same files as the
> package they inherit.

Yes.  That's important to avoid the dreaded circular module import
problem (info "(guix) Cyclic Module Dependencies").

-- 
Thanks,
Maxim




  reply	other threads:[~2024-03-17  1:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-13 16:45 [bug#69778] [PATCH gnome-team] gnu: telegram: Build with glibmm@2.76 Vivien Kraus via Guix-patches via
2024-03-13 21:59 ` Liliana Marie Prikler
2024-03-17  1:30   ` Maxim Cournoyer [this message]
2024-03-14 18:06 ` [bug#69778] [PATCH gnome-team v2 0/2] Make the glibmm-2.76 variable public in (gnu packages glib) Vivien Kraus via Guix-patches via
2024-03-13 16:45   ` [bug#69778] [PATCH gnome-team v2 2/2] gnu: telegram: Build with glibmm@2.76 Vivien Kraus via Guix-patches via
2024-03-14 17:29   ` [bug#69778] [PATCH gnome-team v2 1/2] gnu: Add glibmm-2.76 Vivien Kraus via Guix-patches via
2024-03-14 19:17   ` [bug#69778] [PATCH gnome-team v2 0/2] Make the glibmm-2.76 variable public in (gnu packages glib) Liliana Marie Prikler
2024-03-16 11:04     ` Christopher Baines
2024-03-17  1:31   ` Maxim Cournoyer
2024-03-17  7:29     ` Vivien Kraus via Guix-patches via
2024-03-17  8:30       ` Liliana Marie Prikler
2024-03-21 18:25         ` Vivien Kraus via Guix-patches via
2024-03-21 18:49           ` Liliana Marie Prikler
2024-03-21 19:51             ` Vivien Kraus via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6h5prvc.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=69778@debbugs.gnu.org \
    --cc=liliana.prikler@gmail.com \
    --cc=rg@raghavgururajan.name \
    --cc=vivien@planete-kraus.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).