From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 0MZyAFRsfGZfOwAAqHPOHw:P1 (envelope-from ) for ; Wed, 26 Jun 2024 19:30:28 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 0MZyAFRsfGZfOwAAqHPOHw (envelope-from ) for ; Wed, 26 Jun 2024 21:30:28 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=fxHTKSX6; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1719430227; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=1ilDd8ltMPdXWrkPXIHq/4gVtMKVeMEjrD0CXAJZ7/o=; b=aNNyqbZZ/hUhhOH5Ae4NK/w3V0CklxFdCGW9ht+WVKYnJX1178RLwdtFJvYtWWrUD5zwXa ZAjJY6Q8kUU6ow5kx9hgvU0upUWKtXj16TALtb04ek1MFGGKcPfpsSw9DDqAhGTYye00MI C6MePre9inxCyiJCcgj7LRGPHFcM479uNF+uQn1sTq2fv7QmYeuL6qi79Sg0h4TFjQVzK9 Ur3tHW0mgbYu5mcAD1hvNZoUY7K4T7WS+jfIFG3LU61+ObMTRqbxgbLuJmR9Epa90ByxhH EVSmHFqCY6KREVv60aQn0+7XwwgUOcCOIaUNvVp7wXr0HUgXNQvjwikCrusO3w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1719430227; a=rsa-sha256; cv=none; b=HAqEf1/i0FH2EER1WT5g8XjRPB7/6BKoDUxqeVvqNQb8uIj9611drY0r4NjVgcw9hR+zQI ydlsaraU/5Mz8dK0CF7Vvu4NLpAIZ3iJ26tESnsdfdrD59fAqyAZqCe8RiPzQxfxrR7f45 PQDooZU1jVYsfSKRIBANus3+BdUQ/i6u9OYhZUAU0llYBQSXjfQd8wW4wljnUwpIXNWmvQ AY2tiJ6QZlCn+YsByp+4PWfEg6jZ5BBv5hGVl5pe3CD2r11s/HESohrjtP1q9wBInYAq8M wz/4Xr1qvkkwKVgytLgVhuK7bMK9lt7KfDRCZOiSXkS//GX+5FWVBc/EcWJtUg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=fxHTKSX6; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B2CB573258 for ; Wed, 26 Jun 2024 21:30:27 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sMYLF-0004DG-Bm; Wed, 26 Jun 2024 15:30:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMYLB-0004Cr-Ov for guix-patches@gnu.org; Wed, 26 Jun 2024 15:30:01 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sMYLA-00087x-1g for guix-patches@gnu.org; Wed, 26 Jun 2024 15:30:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sMYLC-0007IU-Bx for guix-patches@gnu.org; Wed, 26 Jun 2024 15:30:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71697] [PATCH v3 2/2] scripts: lint: Honor package property to exclude checkers. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 26 Jun 2024 19:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71697 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Greg Hogan Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Tobias Geerinckx-Rice , Florian Pelz , Ricardo Wurmus , 71697@debbugs.gnu.org, Christopher Baines , Matthew Trzcinski Received: via spool by 71697-submit@debbugs.gnu.org id=B71697.171943016327955 (code B ref 71697); Wed, 26 Jun 2024 19:30:02 +0000 Received: (at 71697) by debbugs.gnu.org; 26 Jun 2024 19:29:23 +0000 Received: from localhost ([127.0.0.1]:40369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMYKY-0007Gp-VC for submit@debbugs.gnu.org; Wed, 26 Jun 2024 15:29:23 -0400 Received: from mail-qk1-f171.google.com ([209.85.222.171]:50281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMYKX-0007Gc-9T for 71697@debbugs.gnu.org; Wed, 26 Jun 2024 15:29:21 -0400 Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-79c072af217so189839685a.0 for <71697@debbugs.gnu.org>; Wed, 26 Jun 2024 12:29:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719430093; x=1720034893; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1ilDd8ltMPdXWrkPXIHq/4gVtMKVeMEjrD0CXAJZ7/o=; b=fxHTKSX6ovYaoFzeTIfkAgvGgmLKx2IgmmBguOWsKGOKnVGub7E/cphQB0WHQ2bduQ q3VLKMkwKqzg/jOtpzF+b7zib8mws20eWoROm+r0mpjwphbbiycpAWELAo9VfywbIMkT VVVmWDIHRkwQiYa3URcf8tRVXJRZlf2ECh7rvCRzUycDAJLwd+2IOV9CF/rhoaDTTskI Z+fij3uvwBKekTe4R+kq1sMa8GJ0kZUX44veO+os3SNy78EAevmT4ST29LCuszDQ1PqO H7wYVJiqPu/FOIbV9vGcZ7vIEK3kr2+QT14PgjITONLyUCs7r+otKvToRFJ4bP1Nqob0 hRtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719430093; x=1720034893; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1ilDd8ltMPdXWrkPXIHq/4gVtMKVeMEjrD0CXAJZ7/o=; b=xVClY2+c6bypS8yrV0DKCcWj/51GXyuzzLJtj11vi1P8kNNS/uNkWme5r2wNoRjyBp pJiJvFQelDRK4r1eDNaBHTds6CWmBkho/OAI8gnwWjeEAJAnqcnMvCf6ktJQSClnpGXA s/Bds0pRXW3Eepn4tC0LJlbujYiM0zHE5BOcbA3C9j1SqeDRLg8GSvtZ+8twrBSAdivm Bz9daKcP2rcdixcbRFIEzniT29OSUk8KhocGXzPfNqhH8iKRYJ1ycFiC+QRQW+4K2QUp fNPB82NA1PwZfFd8Gikmf/jRZ0EZ7z62ZOCbPMn2x5hyGaxffhiY49OVwl0RAmpRuust hGVA== X-Forwarded-Encrypted: i=1; AJvYcCUg/StBz7d8quj6zoYWudKo7ZeLjigxPMoKlVkvBXJOmEZ+0plBxbxq7rd80MvLxYiO6zusZdbZdyRtQDAvg8sgGlsSjDQ= X-Gm-Message-State: AOJu0YwL7dG4dN0esmMdt9KxZq/mmdlvC3ndS6DuNEF+BfvjOnTrdqEx f6eeC47nHEbnNBrK5qciA4MStehrpLiiiszUwe6vrKUx9jnNVAX5 X-Google-Smtp-Source: AGHT+IGlhfsakzn3MdE9T5MAvoEar23K4jf7bK1bzQqwEAO8CpGGVszvsTfD5J/TmeR0pNJnvpDGDA== X-Received: by 2002:a05:620a:4416:b0:795:54d4:df7e with SMTP id af79cd13be357-79be6ed69cemr1364021885a.20.1719430093179; Wed, 26 Jun 2024 12:28:13 -0700 (PDT) Received: from hurd ([204.48.95.10]) by smtp.gmail.com with ESMTPSA id af79cd13be357-79bce8b0f3esm526802285a.29.2024.06.26.12.28.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jun 2024 12:28:12 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: (Greg Hogan's message of "Tue, 25 Jun 2024 13:14:18 -0400") References: <1f9e0a732fff5c6460e6da9500ea5b748882e38d.1719069966.git.zimon.toutoune@gmail.com> <871q4ldpgv.fsf@gnu.org> Date: Wed, 26 Jun 2024 15:28:11 -0400 Message-ID: <87h6dfbj1w.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -0.77 X-Spam-Score: -0.77 X-Migadu-Queue-Id: B2CB573258 X-Migadu-Scanner: mx11.migadu.com X-TUID: +ZAKyBLv17lb Hi Greg, Greg Hogan writes: > On Tue, Jun 25, 2024 at 11:15=E2=80=AFAM Ludovic Court=C3=A8s wrote: >> >> Hi, >> >> Simon Tournier skribis: >> >> > +@lisp >> > +(package >> > + (name "python-scikit-learn") >> > + ;; @dots{} >> > + (properties '((lint-exclude-archival? . #t) >> > + (lint-exclude-home-page? . #t)))) >> >> To complement Maxim=E2=80=99s review, how about: >> >> (properties '((lint-excluded-checkers . (archival home-page)))) >> >> ? >> >> Apart from that, the idea sounds reasonable to me. >> >> Thanks, >> Ludo=E2=80=99. > > Could we not instead create a GUIX_LINT_OPTIONS, similar to > GUIX_BUILD_OPTIONS? Then anyone wishing to universally exclude certain > checkers (or disable network checks) on their own system would be free > to do so. That would be a good option to have too, on top of the other one. > I find the current implementation confusing since I don't believe the > project would accept a new or modified package missing the home page > or with archiving disabled. Stated another way, to which Guix packages > are we adding lint exclusions? I don't think these exclusions should be committed in general to the repo, except when we have for example the author of some software explicitly requesting that SWH archival be disabled for it in Guix. It may also be useful e.g. for some project that really don't have a home page, to avoid a spurious lint warning in this case. --=20 Thanks, Maxim