From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id WHhuNJuF72Z9KwEAqHPOHw:P1 (envelope-from ) for ; Sun, 22 Sep 2024 02:49:00 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id WHhuNJuF72Z9KwEAqHPOHw (envelope-from ) for ; Sun, 22 Sep 2024 04:48:59 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=lIXRoxaV; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="Y/Sax/8Q"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1726973339; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=AYDqREzgQiz6yw1xfNPC3PcWDe5bPfGvK335JVd+FY4=; b=XeV2B0Qi6jL5U45mzQ8k/ofJqlwlPT83h+4SwKSD62V7/Q1xZFQYe/JdfYwz9IYWgiHlKt CMQpRH/+wcqKxDXylFmO/9wvmStoTg7OQaRVVEHz5q3t7nCJVBLPw+hh3G/CQgdu6ZBZ+t W8ZHpMZIdLFYHw9g6NX3zGmVZwl9hHskZMnOvZ/B/I9MkPjU5c3SSw6iJwFjj/7/7BDBK6 15KNsAiFHzJ3uH+a7FvX0xUn1hZARYzAfoXJfFx0ktSjq+y2jjVQnkTg4GgYxBgPZzsmed MbyslWUVC/h6CVIxTXHUPHa6vGosMVRKyqcXrQj9eg9NvCmcGGgAnH/gTRjhfg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=lIXRoxaV; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="Y/Sax/8Q"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1726973339; a=rsa-sha256; cv=none; b=VUjl0x6wHKzYFX+yGPqAXD1IQP8Ks4c+tvLg2qFnAHouPYkR8gvfKeJXuAhSd9acOqD0o2 AiSUraiMUtXvevgplH/FTtYwSWq/wSq0OTpy/PY3vvx3cFkGhfYsY7j4a2wJhQE/7BfiXn vcGgeuw8HGMkm+NIND8TvhlQi4EOgwbscF8qHgKYqQbb/XkZaTjowvBPJ6R4wSmKu+L2np UMH58fxC1KbcKriniCkHUmlmTwH0/z7dHnv7fUVgUHddUfRa7075q0EBY0sDAw2KtS8cBn 86ILTDbj8BlUPMgivIub9nwDyqURTbJteBnHMJi3X/CaK+BFwCUXaPsmkQGz5Q== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 74C8B7F27F for ; Sun, 22 Sep 2024 04:48:59 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ssCeT-0001hP-3a; Sat, 21 Sep 2024 22:48:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ssCeP-0001hG-Od for guix-patches@gnu.org; Sat, 21 Sep 2024 22:48:41 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ssCeP-0005Yv-7v for guix-patches@gnu.org; Sat, 21 Sep 2024 22:48:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=AYDqREzgQiz6yw1xfNPC3PcWDe5bPfGvK335JVd+FY4=; b=lIXRoxaVXl2sU1oR1XHiZqnCz9h1zRkTKfBR8Wk+QkPFbAc/EtSi+5b0b+y8yKVzHkv2BLOHXxGAWn3jRPDaR01O5273j4j3/v1adWQR+0f9+MMthbHZbg3R9SJWAmdLNyLiM+0WJV2mH5Mrh0ykjU0xqxe2ph8QwzSVedvke4pqbTMxGB8IshtnlgERYPMfj7FRNsvWFTXp/vd6Q6EOgNkVA3bJ65qXiKbRqZBG+Xck/ooooo8Tz98LaiNvx9FERuhswyF75mAEDN1RaDdlruccy3STGbfd/nUNrOIaXRaz8GGKoysJ0gX2QGTaN54TELaqb0eLkR0f993YC2wrbg==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ssCek-0000zS-6A for guix-patches@gnu.org; Sat, 21 Sep 2024 22:49:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73301] [PATCH 3/4] gnu: gtk: Update to 4.16.1. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 22 Sep 2024 02:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73301 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: vivien@planete-kraus.eu, 73301@debbugs.gnu.org Received: via spool by 73301-submit@debbugs.gnu.org id=B73301.17269733203770 (code B ref 73301); Sun, 22 Sep 2024 02:49:02 +0000 Received: (at 73301) by debbugs.gnu.org; 22 Sep 2024 02:48:40 +0000 Received: from localhost ([127.0.0.1]:40544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssCeN-0000yj-Ok for submit@debbugs.gnu.org; Sat, 21 Sep 2024 22:48:40 -0400 Received: from mail-pg1-f181.google.com ([209.85.215.181]:51418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssCeL-0000yP-5i for 73301@debbugs.gnu.org; Sat, 21 Sep 2024 22:48:38 -0400 Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-7db908c9c83so1724742a12.2 for <73301@debbugs.gnu.org>; Sat, 21 Sep 2024 19:48:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726973230; x=1727578030; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AYDqREzgQiz6yw1xfNPC3PcWDe5bPfGvK335JVd+FY4=; b=Y/Sax/8QZ3aK5mCs/3vL+zmdfrmlCyKkLnHhooXtmVbfs5loNVXXLs/bZ9xpFdf0+A mNp6XwRnJjnZt3E9yFvlRrqFfR7f4gN+jGSUdY7iwD+JpHDXm6vm9bEzd6hon2kPwMnh gCS3SPN2Jem34SC9TWLEmiRdNaiXEXNbcWyU6ib8tHXmJYNN0f5bOuDBG3GWlRM4Ymsr 84naCVD6mu4BfIkRI/1jxCtj0e5pB+BRUeAc3X+8SbJHOlr1YsdFcff3LqdUTdfGd+UZ ySrJ2D/t/GEYqcGIPdKYFCSYyNpoRIxu4AjobNIlT+Zrp6JK2q7AQ4wtoVgnbnNpsiCx qZVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726973230; x=1727578030; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=AYDqREzgQiz6yw1xfNPC3PcWDe5bPfGvK335JVd+FY4=; b=RdxNBoZydnz+jNaEd21yMRJ9j9tWfEFc/4mSYdmR+jCuvwQQIxnkCam5NfHPvOzdeh 4OQtM0eDJRQ2g9PeKsEMMmTkCuu1xmpl+cjATXu3eY5qmqBA67iNO7QCGijaqpitR/NZ /iVhIqs4pZak/pU4B5nXbM/qCOE+IkAbKFVHWGSuwNI/mK3eldIMX+QLv0MjwecMrbsj T+/tabxq2o8Ph3KHVirZgInLxjmmmz18OwPpUCLquPL1Slc2aM6Ol5yNMrQINcbzHUKa MPOzEQlFzuYL+O0E0HUyXzO0B8XOSKS5WR//4qIchCY1gkAAzm1fDpyOvDItYAd6wA// 1+2g== X-Gm-Message-State: AOJu0YxAu87lxyYskp6B+FnQ/hA+Tp/6SfJU+Cejaiygyiw3AGES/Gn3 tnzjYrmo9RmWQhKjHgvu3bmvCHoVOWLsNGwgKTIeauAEIeTFmghe2J3ncQ== X-Google-Smtp-Source: AGHT+IHeM/7du7oXD0sqbLs4o5Mn01T7GCiwCSTsj7aJS5/Vgty8igeV5rNDti9whph35xr3WUW9Iw== X-Received: by 2002:a05:6a21:2d8c:b0:1d0:56b1:1aec with SMTP id adf61e73a8af0-1d30a9b4f69mr13628020637.35.1726973230117; Sat, 21 Sep 2024 19:47:10 -0700 (PDT) Received: from hurd ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944abe4casm11848733b3a.87.2024.09.21.19.47.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Sep 2024 19:47:08 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: (Liliana Marie Prikler's message of "Sun, 15 Sep 2024 00:33:55 +0200") References: User-Agent: Gnus/5.13 (Gnus v5.13) Date: Sun, 22 Sep 2024 11:47:05 +0900 Message-ID: <87h6a8mml2.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 74C8B7F27F X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -10.46 X-Migadu-Spam-Score: -10.46 X-TUID: 6g/8ZAFOfjeL Hi Liliana, Liliana Marie Prikler writes: > * gnu/packages/gtk.scm (gtk): Update to 4.16.1. > [arguments]<#:configure-flags>: Replace =E2=80=9C-Dgtk_doc=3D=E2=80=A6=E2= =80=9D with > =E2=80=9C-Ddocumentation=3Dtrue=E2=80=9D. > <#:test-options>: Add =E2=80=9C--no-suite=3Dneeds-udmabuf=E2=80=9D. > <#:phases>: Adjust patches for failing tests. > [inputs]: Replace wayland-protocols with wayland-protocols-next. > --- > gnu/packages/gtk.scm | 34 ++++++++-------------------------- > 1 file changed, 8 insertions(+), 26 deletions(-) > > diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm > index 8945fb98ae..5733749a72 100644 > --- a/gnu/packages/gtk.scm > +++ b/gnu/packages/gtk.scm > @@ -1141,7 +1141,7 @@ (define-public gtk+ > (define-public gtk > (package > (name "gtk") > - (version "4.14.5") > + (version "4.16.1") > (source > (origin > (method url-fetch) > @@ -1149,7 +1149,7 @@ (define-public gtk > (version-major+minor version) "/" > name "-" version ".tar.xz")) > (sha256 > - (base32 "0kg286za53qhl6ngw4rrvbpm3q04g30qf2q77sck7c86y2wz4ism")) > + (base32 "0p11k5afy3g9d6p402zrn9izkypwzlb51y9qanibzyc1sjmiwslj")) > (patches > (search-patches "gtk4-respect-GUIX_GTK4_PATH.patch")) > (modules '((guix build utils))))) > @@ -1166,11 +1166,7 @@ (define-public gtk > "-Dcloudproviders=3Denabled" ;for cloud-providers support > "-Dtracker=3Denabled" ;for filechooser search support > "-Dcolord=3Denabled" ;for color printing support > - #$@(if (%current-target-system) > - ;; If true, gtkdoc-scangobj will try to execute a > - ;; cross-compiled binary. > - '("-Dgtk_doc=3Dfalse") > - '("-Dgtk_doc=3Dtrue")) > + "-Ddocumentation=3Dtrue" > "-Dman-pages=3Dtrue") > #:test-options #~(list "--setup=3Dx11" ;defaults to wayland > ;; Use the same test options as upstream us= es for > @@ -1180,6 +1176,7 @@ (define-public gtk > "--no-suite=3Dflaky" > "--no-suite=3Dheadless" ; requires mutter= =E2=80=A6 > "--no-suite=3Dgsk-compare-broadway" > + "--no-suite=3Dneeds-udmabuf" > ;; These seem to fail on aarch64, and Debia= n has > ;; also disabled these, see: > ;; https://bugs.debian.org/cgi-bin/bugrepor= t.cgi?bug=3D1050075 > @@ -1219,29 +1216,14 @@ (define-public gtk > (("[ \t]*'empty-text.node',") "") > (("[ \t]*'testswitch.node',") "") > (("[ \t]*'widgetfactory.node',") "") > - ;; The unaligned-offscreen test fails for unknown reason= s, also > - ;; on different distributions (see: > - ;; https://gitlab.gnome.org/GNOME/gtk/-/issues/4889). > - ((" 'unaligned-offscreen',") "") > ;; This test, 'gtk:tools / validate', started failing for > ;; unknown reasons after updating mesa to 23.3.1 and xor= gproto > ;; to 2023.2. > ((" 'validate',") "") > - ;; XXX: These test failures come newly from 4.14. > - ;; Not all of them are reported upstream yet, but the te= xt nodes > - ;; are mentioned in > - ;; . > - (("'glyph-subpixel-position',") "") > - (("'subpixel-positioning',") "") > - (("'subpixel-positioning-hidpi-nogl-nocairo',") "") > - (("'text.*\\.node',") "") > - (("'text-mixed-color-colrv1',") "")) LGTM so far. > + ;; XXX: Figure out why this fails and report upstream. > + ((".*'memorytexture',.*") "")) Is the above comment just for 'memorytexture' test? I've learnt to be very explicit in my comments, as when new tests gets disabled, it's how to track what is being commented about. (also, I doubt someone will come back to the investigation later, so this is technical debt on our side -- I'd favor a minimal investigation with a report upstream if none exist so far). > (substitute* "testsuite/reftests/meson.build" > - (("[ \t]*'label-wrap-justify.ui',") "") > - ;; The inscription-markup.ui fails due to /etc/machine-id > - ;; related warnings (see: > - ;; https://gitlab.gnome.org/GNOME/gtk/-/issues/5169). > - (("[ \t]*'inscription-markup.ui',") "")) > + (("[ \t]*'label-wrap-justify.ui',") "")) There's no more comment about why this new test fails. Is it known upstream? > ;; These tests fail on an Apple M1 (aarch64) with the foll= owing errors: > ;; - MESA: error: ZINK: failed to choose pdev > ;; - libEGL warning: egl: failed to create dri2 screen > @@ -1391,7 +1373,7 @@ (define-public gtk > vulkan-headers > vulkan-loader ;for vulkan graphics API support > wayland ;for wayland display-backend > - wayland-protocols)) > + wayland-protocols-next)) Instead of using -next things, perhaps we should byte the bullet and update them in this iteration too? Using various variants of system means the system closure will be higher, may cause problems down the line (if the same process attempts to load two variants library in memory, that would cause issues). --=20 Thanks, Maxim