From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 2LsSHc6Y72YkDgAAe85BDQ:P1 (envelope-from ) for ; Sun, 22 Sep 2024 04:10:54 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 2LsSHc6Y72YkDgAAe85BDQ (envelope-from ) for ; Sun, 22 Sep 2024 06:10:54 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=u5MfCYaV; dkim=fail ("headers rsa verify failed") header.d=dan.games header.s=fm3 header.b=HzigqbRp; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=gaVIl7yq; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1726978254; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=OOe4ONKpwRMZNHdG5RzpKxuM7492znpt//D0Vu0Mcoo=; b=XWy5CuML7uUs+dyc5MmHFLKSBsWIwGr4jUvQfZPY6hUl4qQa2FM3tTFniWM1xQho2wuqFV 8PM4u+usznr3WKiPjVMK5DH3dxGlO10TbDvLf2Kn3Yu4zkI97z6/a01S32POAGMxn6erxb oNEbBiB6tx65lTAbvyfvPDglVR9JvLgfCX3AyP9LLzF0anJ3P0H+oXqZTfmpody20+pvyh ig9n+XzGYsveTGu9kE1VsbihRvMnOLTC2NGMcsLx+yH00gfcEhU+Dj0aRiLFY0UreaGqCP c3WFyukK+S725TkiXKQOb5IVSQ2JdXauR5cO4K4i8hu+cjiCT+mAXD9Y1A1puw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1726978254; a=rsa-sha256; cv=none; b=YvsFcG5QaGmD8XVuaDnTtP0nKjeEwari6g0f5fy3sft524JIiGb6Mj2fX2crdpBDXtSe5B o4U6RzQDlicD01+eEDNzcUaDUYUwLplPZLk2qC0eXQMT7+wIXUbIvYH5sLeCmlQ7ft4k2j qtxqpXSXMwRDN1IlU7xn8eXfzMTEz52k7r6muqxwBnUXdIrvYFyW0Rf+E6ZVkWN7McAATx M4x2IPct7bODcvKYBH5hbdc1igmUZ8GEhdvJwNMOSF4uFYrL3NSLDY2p2UTbP/IkkQoUiW xJ0Fhvre3KGkk/J6K4MA5h1MixSEXV4SN1lXtyOLgAn44SY/iwSem1tN2oCJ0Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=u5MfCYaV; dkim=fail ("headers rsa verify failed") header.d=dan.games header.s=fm3 header.b=HzigqbRp; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=gaVIl7yq; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6827063A8E for ; Sun, 22 Sep 2024 06:10:53 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ssDvq-0000DF-3g; Sun, 22 Sep 2024 00:10:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ssDvl-000099-Ok for guix-patches@gnu.org; Sun, 22 Sep 2024 00:10:42 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ssDvl-000598-9U for guix-patches@gnu.org; Sun, 22 Sep 2024 00:10:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=OOe4ONKpwRMZNHdG5RzpKxuM7492znpt//D0Vu0Mcoo=; b=u5MfCYaVhIeP+n696TwXv2SE97b6z2qOWUbIBf32w4GVDNcRe9MKfh4Cvtxnq0tZd6NU3Yc9yMaLXwG0fbXLXQjcuXPeNA1wXxbXHvoznYBouzQO2I7i7LxrDt5O9orf+grXUI/bFnSjo2RZA29jpGipOrYeqGm60g2Q6KWUNDk8lKifoTHB30wqU7FZCHtSLcwDCXocQ0pOgKdsCP8MEv/VgzU1GJoL88B5KUSFdz6567lx4OqnISkqmeJQoO01qp+Nf78RDkySfyv0hsVFIYFJAQ0j2nMN4jbj3UJ0SIO452WdxGMnbXUUV2mZkblQabfzhQQYqHHsrBLZCV6fDw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ssDw6-0005VA-2N for guix-patches@gnu.org; Sun, 22 Sep 2024 00:11:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71897] [PATCH v8 8/8] gnu: telegram-desktop: Update to 5.5.5. Resent-From: dan Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 22 Sep 2024 04:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71897 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: Sharlatan Hellseher , Liliana Marie Prikler , 71897@debbugs.gnu.org Received: via spool by 71897-submit@debbugs.gnu.org id=B71897.172697822420599 (code B ref 71897); Sun, 22 Sep 2024 04:11:02 +0000 Received: (at 71897) by debbugs.gnu.org; 22 Sep 2024 04:10:24 +0000 Received: from localhost ([127.0.0.1]:40610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssDvT-0005Lv-RT for submit@debbugs.gnu.org; Sun, 22 Sep 2024 00:10:24 -0400 Received: from fhigh6-smtp.messagingengine.com ([103.168.172.157]:60185) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssDvQ-0005La-M1 for 71897@debbugs.gnu.org; Sun, 22 Sep 2024 00:10:22 -0400 Received: from phl-compute-02.internal (phl-compute-02.phl.internal [10.202.2.42]) by mailfhigh.phl.internal (Postfix) with ESMTP id E56F211402FA; Sun, 22 Sep 2024 00:09:53 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-02.internal (MEProxy); Sun, 22 Sep 2024 00:09:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dan.games; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1726978193; x=1727064593; bh=OOe4ONKpwR MZNHdG5RzpKxuM7492znpt//D0Vu0Mcoo=; b=HzigqbRplu7lRFEtJQ3c06qJTH Y3GZQEPL5keOOKzATn+ciYhsp198LU7s4A6MQOGbmr//0hyV8bJ9U5Y4Jeb0i57+ bIonklpuN8YZVoWkhDOXlQdxYOkAiVvCfoKw7Q5LW0IZS3y9mqftHr5+KW7kz1UA 1zU9YdGnT2hv72KQFzcdR7WVwuQl6RSyicxDh17AdFxGC63/LGa1KylD4CPoPwRv u8fLoXOvXfdp5Gqb+MtMY7cS0a+10WsdEhxh9S2DcM7x+q6L0HQfS7OfHcueIvE6 8kVY1vt7Q5Qn4KL93n11ZoiOWZLBdNiQomqJgTZr50TX+4aKnTiqsTQvvVTA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1726978193; x=1727064593; bh=OOe4ONKpwRMZNHdG5RzpKxuM7492 znpt//D0Vu0Mcoo=; b=gaVIl7yqNiz0kiRXHBHOY7DOaKGfqJfBUkbcykTdDg06 cRFYYRiAA4Z/xskZHSXIvMZLGfKgvGFvGsxFhYQ4DDTJmemEDXrpiKJa09JHYjrK iD6Uy9sI5QXDXgWJWaISznLIMpQVFEsYqk3yQ5O1u/pUCtSUcZXAYHY+k6iHfdwE TZvzviZUgva47WNG7sssFYbPUMJS+ksunhH0x4RFZDzl95GnxYAyhrSg6ZuLx7G+ Wjg2qQ8Q6erzE77Ja4ozf2pycw9yS9JP4B0jtu24fnFffDAzplA8ujZmn0WHKxY2 BJx3p0SyGGqHi+BTi5OQmUEBxVOJ320cI4DAC+EDSg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudeliedgkeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefujghffffkgggtsehttdertddttddtnecu hfhrohhmpegurghnuceoihesuggrnhdrghgrmhgvsheqnecuggftrfgrthhtvghrnhepve fhvedvgffhhfdtteeiuddvteegudeuvefgvdffkedvueeuteetffeliefgtdffnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepihesuggrnhdrgh grmhgvshdpnhgspghrtghpthhtohepgedpmhhouggvpehsmhhtphhouhhtpdhrtghpthht ohepmhgrgihimhdrtghouhhrnhhohigvrhesghhmrghilhdrtghomhdprhgtphhtthhope ejudekleejseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtoheplhhilhhirghn rgdrphhrihhklhgvrhesghhmrghilhdrtghomhdprhgtphhtthhopehshhgrrhhlrghtrg hnuhhssehgmhgrihhlrdgtohhm X-ME-Proxy: Feedback-ID: i3b5946ed:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 22 Sep 2024 00:09:52 -0400 (EDT) From: dan In-Reply-To: <87o74gl6dp.fsf@gmail.com> (Maxim Cournoyer's message of "Sun, 22 Sep 2024 12:22:26 +0900") References: <5fddf9f718d95467cd90d9d2625d749af580205c.1726930328.git.i@dan.games> <87o74gl6dp.fsf@gmail.com> Date: Sun, 22 Sep 2024 12:09:50 +0800 Message-ID: <87h6a8l46p.fsf@dan.games> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -10.66 X-Migadu-Queue-Id: 6827063A8E X-Spam-Score: -10.66 X-TUID: nXl2hJobVHb6 Hi Maxim, Maxim Cournoyer writes: >> + (add-after 'use-system-xdg-desktop-portal >> 'patch-libwebview >> + (lambda _ >> + (substitute* >> "Telegram/lib_webview/webview/webview_interface.h" >> + (("constexpr ") "")))) > > GCC should know about constexpr; perhaps the wrong C++ standard > (can be > provided via a CMake flag) is being selected, or alternatively > you could > provide a newer gcc compiler native inputs? The original compilation error is: --8<---------------cut here---------------start------------->8--- /tmp/guix-build-telegram-desktop-5.5.5.drv-0/source/Telegram/lib_webview/webview/webview_interface.h:34:38: error: call to non-?constexpr? function ?typename __gnu_cxx::__enable_if::__value, bool>::__type std::operator==(const std::__cxx11::basic_string<_CharT>&, const std::__cxx11::basic_string<_CharT>&) [with _CharT = char; typename __gnu_cxx::__enable_if::__value, bool>::__type = bool]? 34 | friend inline constexpr bool operator==( | ^~~~~~~~ In file included from /gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/include/c++/string:55, from /gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/include/c++/bits/locale_classes.h:40, from /gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/include/c++/bits/ios_base.h:41, from /gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/include/c++/streambuf:41, from /gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/include/c++/bits/streambuf_iterator.h:35, from /gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/include/c++/iterator:66, from /gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/include/c++/bits/ranges_algobase.h:36, from /gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/include/c++/bits/ranges_algo.h:35, from /gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/include/c++/algorithm:64, from /gnu/store/mz9sf8vsp2qksx1vb4fz8mrz4pkypfmc-qtbase-5.15.10/include/qt5/QtCore/qglobal.h:142, from /gnu/store/mz9sf8vsp2qksx1vb4fz8mrz4pkypfmc-qtbase-5.15.10/include/qt5/QtCore/qiterator.h:43, from /gnu/store/mz9sf8vsp2qksx1vb4fz8mrz4pkypfmc-qtbase-5.15.10/include/qt5/QtCore/qmap.h:43, from /gnu/store/mz9sf8vsp2qksx1vb4fz8mrz4pkypfmc-qtbase-5.15.10/include/qt5/QtCore/QMap:1, from /tmp/guix-build-telegram-desktop-5.5.5.drv-0/source/Telegram/lib_base/base/ordered_set.h:9, from /tmp/guix-build-telegram-desktop-5.5.5.drv-0/source/Telegram/lib_base/base/basic_types.h:10, from /tmp/guix-build-telegram-desktop-5.5.5.drv-0/source/Telegram/lib_webview/webview/webview_common.h:9, from /tmp/guix-build-telegram-desktop-5.5.5.drv-0/source/Telegram/lib_webview/webview/webview_interface.h:9, from /tmp/guix-build-telegram-desktop-5.5.5.drv-0/source/Telegram/lib_webview/webview/platform/linux/webview_linux.h:9, from /tmp/guix-build-telegram-desktop-5.5.5.drv-0/source/Telegram/lib_webview/webview/platform/linux/webview_linux_webkitgtk.h:9, from /tmp/guix-build-telegram-desktop-5.5.5.drv-0/source/Telegram/lib_webview/webview/platform/linux/webview_linux_webkitgtk.cpp:7: /gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/include/c++/bits/basic_string.h:6234:5: note: ?typename __gnu_cxx::__enable_if::__value, bool>::__type std::operator==(const std::__cxx11::basic_string<_CharT>&, const std::__cxx11::basic_string<_CharT>&) [with _CharT = char; typename __gnu_cxx::__enable_if::__value, bool>::__type = bool]? declared here 6234 | operator==(const basic_string<_CharT>& __lhs, | ^~~~~~~~ --8<---------------cut here---------------end--------------->8--- The problematic code in telegram-desktop is: --8<---------------cut here---------------start------------->8--- struct NavigationHistoryState { std::string url; std::string title; bool canGoBack : 1 = false; bool canGoForward : 1 = false; friend inline constexpr bool operator==( NavigationHistoryState, NavigationHistoryState) = default; }; --8<---------------cut here---------------end--------------->8--- And the code in /gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/include/c++/bits/basic_string.h is: --8<---------------cut here---------------start------------->8--- template inline typename __gnu_cxx::__enable_if<__is_char<_CharT>::__value, bool>::__type operator==(const basic_string<_CharT>& __lhs, const basic_string<_CharT>& __rhs) _GLIBCXX_NOEXCEPT { return (__lhs.size() == __rhs.size() && !std::char_traits<_CharT>::compare(__lhs.data(), __rhs.data(), __lhs.size())); } --8<---------------cut here---------------end--------------->8--- In gcc-12, the code looks like this: --8<---------------cut here---------------start------------->8--- template _GLIBCXX20_CONSTEXPR inline typename __gnu_cxx::__enable_if<__is_char<_CharT>::__value, bool>::__type operator==(const basic_string<_CharT>& __lhs, const basic_string<_CharT>& __rhs) _GLIBCXX_NOEXCEPT { return (__lhs.size() == __rhs.size() && !std::char_traits<_CharT>::compare(__lhs.data(), __rhs.data(), __lhs.size())); } --8<---------------cut here---------------end--------------->8--- Which indeed has the constexpr. But as I explained in previous reply, I failed at using a newer version of gcc. Thus, I think trivially remove the constexpr from telegram-desktop's source is the easiest fix here. -- dan