unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Zheng Junjie <zhengjunjie@iscas.ac.cn>
To: Sughosha via Guix-patches via <guix-patches@gnu.org>
Cc: 73965-done@debbugs.gnu.org, Sughosha <sughosha@disroot.org>
Subject: bug#73965: [PATCH] gnu: phonon-backend-vlc: Enable QT6.
Date: Thu, 24 Oct 2024 00:08:35 +0800	[thread overview]
Message-ID: <87h692kdj0.fsf@iscas.ac.cn> (raw)
In-Reply-To: <95676FC6-CD66-4C14-AB72-F16B78552D21@disroot.org> (Sughosha via Guix-patches via's message of "Wed, 23 Oct 2024 20:45:36 +0530")

[-- Attachment #1: Type: text/plain, Size: 2034 bytes --]

Sughosha via Guix-patches via <guix-patches@gnu.org> writes:

> This is just a VLC backend for phonon, not the phonon itself. Currently this package is used only by dragon
> and none other, which does not have a qt5 version packaged yet.

ok, push it, and i use ON/OFF replace 1/0. close.

>
> On 23 October 2024 8:09:04 pm IST, Zheng Junjie <zhengjunjie@iscas.ac.cn> wrote:
>
>  Sughosha via Guix-patches via <guix-patches@gnu.org> writes:
>
>   * gnu/packages/kde-frameworks.scm (phonon-backend-vlc): Switch to Qt6.
>  [arguments]<configure-flags>: Add "-DPHONON_BUILD_QT5=0" and replace
>  "-DPHONON_BUILD_QT6=OFF" with "-DPHONON_BUILD_QT6=1".
>  [native-inputs]: Replace qttools-5 with qttools.
>  [inputs]: Replace qtbase-5 with qtbase.
>
>  Change-Id: I45380ca844e987bb27ee67106e35cb60fc0565c3
> -------------------------------------------------------------------------------------------
>   gnu/packages/kde-frameworks.scm | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>
>  diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
>  index 13d4e24726..a14ba1ffb0 100644
>  --- a/gnu/packages/kde-frameworks.scm
>  +++ b/gnu/packages/kde-frameworks.scm
>  @@ -311,11 +311,12 @@ (define-public phonon-backend-vlc
>       (build-system cmake-build-system)
>       (arguments
>        (list #:configure-flags
>  -           #~(list "-DPHONON_BUILD_QT6=OFF")))
>  +           #~(list "-DPHONON_BUILD_QT5=0"
>  +                    "-DPHONON_BUILD_QT6=1")))
>       (native-inputs
>  -     (list extra-cmake-modules qttools-5))
>  +     (list extra-cmake-modules qttools))
>       (inputs
>  -     (list phonon qtbase-5 vlc))
>  +     (list phonon qtbase vlc))
>       (home-page "https://community.kde.org/Phonon")
>       (synopsis "Phonon backend which uses VLC")
>       (description "Phonon makes use of backend libraries to provide sound.
>
>  base-commit: 5794926bed6fad4598bb565fb7f49be4205b11a1
>
> i think maybe also add a qt5 version? some package use phonon with qt5.
>
> Sughosha

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

      reply	other threads:[~2024-10-23 16:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-23 14:13 [bug#73965] [PATCH] gnu: phonon-backend-vlc: Enable QT6 Sughosha via Guix-patches via
2024-10-23 14:39 ` Zheng Junjie
2024-10-23 15:15   ` Sughosha via Guix-patches via
2024-10-23 16:08     ` Zheng Junjie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h692kdj0.fsf@iscas.ac.cn \
    --to=zhengjunjie@iscas.ac.cn \
    --cc=73965-done@debbugs.gnu.org \
    --cc=guix-patches@gnu.org \
    --cc=sughosha@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).