From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 8H7qBUfqWmfl9QAAqHPOHw:P1 (envelope-from ) for ; Thu, 12 Dec 2024 13:51:03 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 8H7qBUfqWmfl9QAAqHPOHw (envelope-from ) for ; Thu, 12 Dec 2024 14:51:03 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=n01z7uHQ; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=kNrOK4Vt; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=inria.fr (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1734011462; a=rsa-sha256; cv=none; b=TiyO8Ljh69PKxxMTBmgRF/1ZaTFVUIiCr5d+tXK24KdsotT0k81osTo0at8EXG5M9O6Ety ts9xjZXPMiVYGkZV6QK0Z4o2KALBfyn5rVuZbxRQGUrjX6ckYn0evyKEgDmqosqd6toCNJ ZxiikR4UhbQYU3RyWyzVFhwrrthHnjIjJyjs04DfMIWUJbrbVVRVZvjQ2X55oJ0n4cLTcG mwAxBBEuhBFtZ2V2GLtrwLIPx0ErHJipnoOkVnHEibNu8m6zUtzqgbbgIh3eeEKDW1EclK c3CL6dd24/YIdG8fl3t4N6/7Vd/PZOG+ug5DBJc1phFvt80IqX1UM4xV3YDfng== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=n01z7uHQ; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=kNrOK4Vt; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=inria.fr (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1734011462; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=c/nZ/OtR1R/1j+Kh962d47dxKm37PiK92U4IMJS42Og=; b=Igga8wiwHJFRSVMWB195+MNB673JK0EZwZF7cZt6ZM6ojiwQ14sfF+4KrOF3saBecoHjIq /qxCbgwujsGrRgbdXN2rfTdLIGhOWw3QvQkmDMqvtiUgXLtfb0NQ0rABMaXSEyS3K3ZO5L CRuktLQtSWjd353nqREqHkJuWGsUjOQITdF+b2VGdP6SOzUmf7AFO6k+LVcAW6Kk9KOUoI lrqLtKLeCFzDD+sU7HvPf5miw2fuIITPxuncmSRK8XJXsbT8Vf8HxvtwiheLzBLziXpArX DSWyS9UT28dTszi7wenolcR9aTrXX2N/DqbM/FzAivfvtyCzalPrTx40iOrheA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 988295A20 for ; Thu, 12 Dec 2024 14:51:02 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tLjaC-00036F-1h; Thu, 12 Dec 2024 08:50:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLjZs-0002oR-8Y for guix-patches@gnu.org; Thu, 12 Dec 2024 08:50:07 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tLjZr-00043H-8Z for guix-patches@gnu.org; Thu, 12 Dec 2024 08:50:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=c/nZ/OtR1R/1j+Kh962d47dxKm37PiK92U4IMJS42Og=; b=n01z7uHQ5Ni142C2KGi4PNhqRXjr1pgCm5TPoc5XhaEE1Y8gXsyI+Hp9cjHKB/RgcWFiPhvs+Aio0ee/W9PtI6hhSwEiyGVvpUQn+DC0hJJtZHS960xXACaqrriLA3J0IFW1GQ4EOIKwFgrML1LvzYVPIMf4TFLtA5PNeeyPr9azm5/sf5t7usNpeMwjpjbWpWHCXeErcE7QbjkHxY4YoJoB+p3RzEp9NayVdV0Wj3rS6Yye8dRUUsdINOi748ElA80dX7oEHM2o9pRZ8j4vzRyz9lAGtnY6c3VUcAN4F+fRI2XorlYc/dmKFZqq/T8T+swiwiMv9UMTsoH/KoOk8Q==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tLjLK-0000yM-B8 for guix-patches@gnu.org; Thu, 12 Dec 2024 08:35:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74769] [PATCH Cuirass 2/4] forgejo: Add module for Forgejo JSON objects definition. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 12 Dec 2024 13:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74769 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Romain GARBAGE Cc: 74769@debbugs.gnu.org Received: via spool by 74769-submit@debbugs.gnu.org id=B74769.17340104653678 (code B ref 74769); Thu, 12 Dec 2024 13:35:02 +0000 Received: (at 74769) by debbugs.gnu.org; 12 Dec 2024 13:34:25 +0000 Received: from localhost ([127.0.0.1]:38205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLjKe-0000xB-Mf for submit@debbugs.gnu.org; Thu, 12 Dec 2024 08:34:24 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:28785) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLjKb-0000wm-T9 for 74769@debbugs.gnu.org; Thu, 12 Dec 2024 08:34:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=c/nZ/OtR1R/1j+Kh962d47dxKm37PiK92U4IMJS42Og=; b=kNrOK4Vt5j2sO6Wu+NofH/kS4twNHZGItGmlbYYR3mIqrWRpj2VjZA1T fxcaBzJ/CQ/QWl6rn/kDFbEOYLNuwZZMyDdLkyOZ/pQKt40n9dbC3WRoF uQiRThaLtD1/TE4LZYDA1wnDuEG/nnNEBG5o00BoSUQd2RosWVYAu0cdD 4=; X-IronPort-AV: E=Sophos;i="6.12,228,1728943200"; d="scan'208";a="104159160" Received: from unknown (HELO ribbon) ([193.50.110.52]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Dec 2024 14:34:12 +0100 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <20241210160929.14180-2-romain.garbage@inria.fr> (Romain GARBAGE's message of "Tue, 10 Dec 2024 17:09:26 +0100") References: <20241210160929.14180-1-romain.garbage@inria.fr> <20241210160929.14180-2-romain.garbage@inria.fr> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Duodi 22 Frimaire an 233 de la =?UTF-8?Q?R=C3=A9volution, ?= jour de la =?UTF-8?Q?Bruy=C3=A8re?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 12 Dec 2024 14:34:10 +0100 Message-ID: <87h6799ga5.fsf@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 988295A20 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -7.19 X-Spam-Score: -7.19 X-TUID: QIjk2l5iEilI Hi! Very nice! :-) Romain GARBAGE skribis: > * Makefile.am: Add src/cuirass/forgejo.scm and tests/forgejo.scm. > * src/cuirass/forgejo.scm: Add , > , , > and record types. > (forgejo-pull-request->specification): New variable. > * tests/forgejo.scm: Add tests. > > fixup tests Leftover? One thing, though: > +(define* (forgejo-pull-request->specification pull-request #:optional (c= uirass-options #f)) > + "Returns a SPECIFICATION built out of a FORGEJO-PULL-REQUEST." > + (let* ((source-repo-reference (forgejo-pull-request-head pull-request)) > + (project-name (forgejo-repository-name > + (forgejo-repository-reference-repository > + (forgejo-pull-request-base pull-request)))) > + (source-branch (forgejo-repository-reference-ref source-repo-re= ference)) > + (source-url (forgejo-repository-url > + (forgejo-repository-reference-repository source-re= po-reference))) > + (id (forgejo-pull-request-number pull-request)) > + (name-prefix (if (and cuirass-options > + (jobset-options-name-prefix cuirass-optio= ns)) > + (jobset-options-name-prefix cuirass-options) The =E2=80=98jobset-options-*=E2=80=99 variables are unbound. I understand= the goal is to share as defined in (cuirass gitlab), but perhaps that should either be made clearly, or just left out for now. Thanks! Ludo=E2=80=99.