From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dAkBO-0002ss-4q for guix-patches@gnu.org; Tue, 16 May 2017 17:39:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dAkBK-0001L7-2W for guix-patches@gnu.org; Tue, 16 May 2017 17:39:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:46575) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dAkBJ-0001KP-Tb for guix-patches@gnu.org; Tue, 16 May 2017 17:39:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dAkBJ-00037c-L4 for guix-patches@gnu.org; Tue, 16 May 2017 17:39:01 -0400 Subject: bug#26956: [PATCH] Add MuseScore Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <878tlwss3t.fsf@nicolasgoaziou.fr> Date: Tue, 16 May 2017 23:37:57 +0200 In-Reply-To: <878tlwss3t.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Tue, 16 May 2017 18:07:18 +0200") Message-ID: <87fug432kq.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Nicolas Goaziou Cc: 26956@debbugs.gnu.org Hi Nicolas, Nicolas Goaziou skribis: > I used glib-or-gtk-build-system because, somewhere in the Makefile, > there's a call to `gtk-update-icon-cache'. However, since that command > cannot be found during the build process, I skip it with > UPDATE_CACHE=3DFALSE. So, should I leave the package as-is, or add > a "gtk+" input, or simply downgrade to gnu-build-system? Since it uses Qt, perhaps we=E2=80=99d better use =E2=80=98gnu-build-system= =E2=80=99 (or =E2=80=98cmake-build-system=E2=80=99?) no? Would we lose something? > Also, the description is a bit verbose. It is an excerpt from > Wikipedia's introduction about the software. Debian's is much terser. > FSF directory's is out of date. WDYT? [...] > From 78e2006499b93895635215e80e58c359a5e31405 Mon Sep 17 00:00:00 2001 > From: Nicolas Goaziou > Date: Tue, 16 May 2017 17:55:29 +0200 > Subject: [PATCH] gnu: Add MuseScore. > > * gnu/packages/music.scm (musescore): New variable. FWIW I trimmed the description a bit and moved =E2=80=98cmake=E2=80=99 to =E2=80=98native-inputs=E2=80=99. Also, a couple of #:use-module were missi= ng. Result copied below. Ludo=E2=80=99. (define-public musescore (package (name "musescore") (version "2.1.0") (source (origin (method url-fetch) (uri (string-append "https://github.com/musescore/MuseScore/archive/" "v" version ".tar.gz")) (file-name (string-append name "-" version ".tar.gz")) (sha256 (base32 "0irwsq6ihfz3y3b943cwqy29g3si7gqbgxdscgw53vwv9vfvi085")))) (build-system glib-or-gtk-build-system) (arguments `(#:make-flags `(,(string-append "PREFIX=3D" (assoc-ref %outputs "out")) ;; Skip update-mime-database and gtk-update-icon-cache. "UPDATE_CACHE=3DFALSE") ;; There are tests, but no simple target to run. The command ;; used to run them is: ;; ;; make debug && sudo make installdebug && cd \ ;; build.debug/mtest && make && ctest ;; ;; Basically, it requires to start a whole new build process. ;; So we simply skip them. #:tests? #f #:phases (modify-phases %standard-phases (delete 'configure) (add-after 'unpack 'use-system-freetype (lambda _ (substitute* "Makefile" ;; XXX: For the time being, we grossly insert the CMake ;; option needed to ignore bundled freetype. However, ;; there's a pending PR to have it as a regular make ;; option, in a future release. (("cmake -DCMAKE") "cmake -DUSE_SYSTEM_FREETYPE=3DON -DCMAKE= ")) #t))))) (inputs `(("alsa-lib" ,alsa-lib) ("freetype" ,freetype) ("jack" ,jack-1) ("lame" ,lame) ("libogg" ,libogg) ("libsndfile" ,libsndfile) ("libvorbis" ,libvorbis) ("openssl" ,openssl) ("portaudio" ,portaudio) ("pulseaudio" ,pulseaudio) ("qtbase" ,qtbase) ("qtdeclarative" ,qtdeclarative) ("qtscript" ,qtscript) ("qtsvg" ,qtsvg) ("qtwebkit" ,qtwebkit) ("qtxmlpatterns" ,qtxmlpatterns))) (native-inputs `(("pkg-config" ,pkg-config) ("cmake" ,cmake) ("qttools" ,qttools))) (synopsis "Music composition and notation software") (description "MuseScore is a music score typesetter. Its main purpose = is the creation of high-quality engraved musical scores in a WYSIWYG environme= nt. It supports unlimited staves, linked parts and part extraction, tablature, MIDI input, percussion notation, cross-staff beaming, automatic transpositi= on, lyrics (multiple verses), fretboard diagrams, and in general everything commonly used in sheet music. Style options and style sheets to change the appearance and layout are provided. MuseScore can also play back scores through the built-in sequencer and Soun= dFont sample library.") (home-page "https://musescore.org") (license license:gpl2)))