From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47695)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dSs6c-0004Ah-3C
	for guix-patches@gnu.org; Wed, 05 Jul 2017 17:45:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dSs6Y-0000oJ-S9
	for guix-patches@gnu.org; Wed, 05 Jul 2017 17:45:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:51147)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dSs6Y-0000o3-Oz
	for guix-patches@gnu.org; Wed, 05 Jul 2017 17:45:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dSs6Y-0006hD-FK
	for guix-patches@gnu.org; Wed, 05 Jul 2017 17:45:02 -0400
Subject: [bug#27550] [PATCH 0/2] cuirass: Prepare (guix git) integration.
Resent-Message-ID: <handler.27550.B27550.149929106225679@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170701150043.14654-1-m.othacehe@gmail.com>
	<87inj9pvvf.fsf@gnu.org> <868tk5ogwe.fsf@gmail.com>
	<867ezpocf4.fsf@gmail.com> <87o9szsxai.fsf@gnu.org>
	<864lurnxd6.fsf@gmail.com>
Date: Wed, 05 Jul 2017 23:44:07 +0200
In-Reply-To: <864lurnxd6.fsf@gmail.com> (Mathieu Othacehe's message of "Wed,
	05 Jul 2017 09:42:13 +0200")
Message-ID: <87fueasgns.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 27550@debbugs.gnu.org

Hello,

Mathieu Othacehe <m.othacehe@gmail.com> skribis:

>> Looks nice!
>
> Thanks :)
>
>> Leftover =E2=80=98pk=E2=80=99.  :-)
>
> Oops !
>
>>
>> Maybe s/store-dir/checkout/ for clarity.
>>
>> Please add a check for (guix git) in configure.ac.
>
> Ok.
>
>>
>> Now there are =E2=80=98git-error=E2=80=99 exception that can be thrown f=
rom there.
>> Should the =E2=80=98cuirass=E2=80=99 program catch them, report them on =
stderr, and keep
>> going?  Maybe we can ignore that for now (throwing is better than
>> silently ignoring Git problems anyway.)
>
> Maybe we can ignore them for now, and when guile-git will support
> git-error integer error code -> string conversion, we can report them
> and keep going as you suggested ?

Sure, sounds good, let=E2=80=99s ignore this for now.

Thank you!

Ludo=E2=80=99.