From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37857) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnKNX-0005yq-O2 for guix-patches@gnu.org; Thu, 31 Aug 2017 03:59:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dnKNT-0004lb-3i for guix-patches@gnu.org; Thu, 31 Aug 2017 03:59:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:55618) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dnKNS-0004lR-VU for guix-patches@gnu.org; Thu, 31 Aug 2017 03:59:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dnKNS-00048s-5N for guix-patches@gnu.org; Thu, 31 Aug 2017 03:59:02 -0400 Subject: [bug#27905] changes for openmpi Resent-Message-ID: From: ludovic.courtes@inria.fr (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87zibja1of.fsf@i-ulialbion.it.manchester.ac.uk> <87h8x1t0op.fsf@gnu.org> <87d17mh20q.fsf@albion.it.manchester.ac.uk> Date: Thu, 31 Aug 2017 09:58:43 +0200 In-Reply-To: <87d17mh20q.fsf@albion.it.manchester.ac.uk> (Dave Love's message of "Wed, 23 Aug 2017 14:00:53 +0100") Message-ID: <87fuc8w4lo.fsf@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Dave Love Cc: 27905@debbugs.gnu.org Hi Dave, Dave Love skribis: > Ludovic Court=C3=A8s writes: > >>> * mpi.scm (hwloc)[outputs]: Replace lib with nogui. >>> (hwloc)[arguments]: Change configure --prefix; use "nogui" output, >>> not "lib"; populate "all" output. >>> (openmpi)[inputs]: Use hwloc-nogui. >> >> The downside of this is that the =E2=80=9Cnogui=E2=80=9D output is less = discoverable >> (and it=E2=80=99s another user-visible breakage.) > > I don't think that's a problem, as people who want to avoid the GUI > stuff will look for an alternative. > >> Also, it shouldn=E2=80=99t make any difference to the closure size of op= enmpi >> anyway, no? > > No, but I think you should be able to run the hwloc programs on compute > nodes without requiring X support, and you sometimes need to run openmpi > programs specifically with openmpi (for memory affinity, for instance). OK so the gain over the current status (with the =E2=80=9Clib=E2=80=9D outp= ut) is that people would be able to get, say, =E2=80=98hwloc-bind=E2=80=99, without get= ting the full =E2=80=98lstopo=E2=80=99 and its dependencies, right? I guess that makes sense, though at the same time =E2=80=98lstopo=E2=80=99 = is probably the most widely used program in hwloc. Perhaps we should keep the current =E2=80=9Clib=E2=80=9D separation, and instead provide an =E2=80=9Ch= wloc-minimal=E2=80=9D package that does not depend on X11/Cairo? >> > + (add-after 'install 'install-openmpi >> > + (lambda* (#:key outputs #:allow-other-keys) >> > + (let ((dest (format #f "~a/lib/valgrind" >> > + (assoc-ref outputs "openmpi")))) >> > + (mkdir-p dest) >> > + (zero? >> > + (system (format #f "mv ~a/lib/valgrind/libmpiwrap* ~a" >> > + (assoc-ref outputs "out") dest)))))))= )) >>=20 >> Why move it to a separate output? After all, we can keep it in =E2=80= =9Cout=E2=80=9D >> since all it costs is the size of libmpiwrap.so, right? > > That would still pull in valgrind, which drags in a lot else (gdb, perl, > python...). The support isn't commonly used as far as I can tell, and > isn't configured by default -- I forgot about the performance hit > . The hunk above is within Valgrind, so I don=E2=80=99t understand what you m= ean by =E2=80=9Cthat would still pull in valgrind.=E2=80=9D My suggestion was to: 1. Remove Valgrind from the inputs of Open MPI; 2. Not add the =E2=80=98install-openmpi=E2=80=99 phase above to Valgrind. Does that make sense? Thank you, Ludo=E2=80=99.