unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Roel Janssen <roel@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 29017@debbugs.gnu.org
Subject: [bug#29017] [PATCH] gnu: Add gwl.
Date: Fri, 27 Oct 2017 13:26:24 +0200	[thread overview]
Message-ID: <87fua4estm.fsf@gnu.org> (raw)
In-Reply-To: <87wp3hcz15.fsf@gnu.org>


Ludovic Courtès writes:

> Hello!
>
> Roel Janssen <roel@gnu.org> skribis:
>
>> I would like to add GWL.  For a lack of a better place, I chose the
>> bioinformatics module because that's where we use this package.
>
> Awesome!  \o/
>
> Perhaps that could go to package-management.scm?

The new patch adds it to package-management.scm.

>
>> From eaa22755769973ba30600ae96bb92a5d6bad11dd Mon Sep 17 00:00:00 2001
>> From: Roel Janssen <roel@gnu.org>
>> Date: Thu, 26 Oct 2017 22:46:50 +0200
>> Subject: [PATCH] gnu: Add gwl.
>>
>> * gnu/packages/bioinformatics.scm (gwl): New variable.
>
> [...]
>
>> +(define-public gwl
>> +  (package
>> +    (name "gwl")
>> +    (version "0.1.0")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri (string-append "https://git.roelj.com/attachments/"
>> +                                  "d804e310-b9c0-44b1-bd18-c7505e9f9d9b"))
>
> Do you have a more “standard” URL, such as a cgit snapshot?  If not
> that’s fine.

This I found a bit weird about Gogs.  Custom-uploaded tarballs get these
weird URLs.  I uploaded the same tarball to guixwl.org, and adjusted the
recipe to use that URL.

>
>> +    (inputs
>> +     `(("guix" ,guix)
>> +       ("guile" ,guile-2.2)
>> +       ("guile-commonmark" ,guile-commonmark)))
>
> It might be that you either need to propagate Guix and CommonMark, or to
> wrap the binaries that GWL provides (as is done in the ‘guix’ package),
> no?

I added guix and guile-commonmark to the propagated-inputs.

>
> Otherwise LGTM, thank you!
>
> Ludo’.

Thanks for your quick response!  I pushed the new patch in 58a308e0b.

Kind regards,
Roel Janssen

  reply	other threads:[~2017-10-27 11:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-26 20:51 [bug#29017] [PATCH] gnu: Add gwl Roel Janssen
2017-10-26 22:41 ` Ludovic Courtès
2017-10-27 11:26   ` Roel Janssen [this message]
2017-10-27 14:08     ` bug#29017: " Roel Janssen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fua4estm.fsf@gnu.org \
    --to=roel@gnu.org \
    --cc=29017@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).