From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43877) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRJta-0006LC-7V for guix-patches@gnu.org; Tue, 19 Dec 2017 10:33:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eRJt8-00039V-SU for guix-patches@gnu.org; Tue, 19 Dec 2017 10:33:30 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:33774) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eRJt8-00038a-LI for guix-patches@gnu.org; Tue, 19 Dec 2017 10:33:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eRJt8-0005mC-9x for guix-patches@gnu.org; Tue, 19 Dec 2017 10:33:02 -0500 Subject: [bug#29610] [PATCH] gnu: games: Add quakespasm. Resent-Message-ID: From: Kei Kebreau References: <9684edc1-5c32-4fab-fbfa-a77160eab0fb@cock.li> <87o9mwyo5b.fsf@posteo.net> <3f4e7ae4-0ab6-7d89-71c4-9d3dd54d2e00@cock.li> Date: Tue, 19 Dec 2017 10:32:34 -0500 In-Reply-To: <3f4e7ae4-0ab6-7d89-71c4-9d3dd54d2e00@cock.li> (nee@cock.li's message of "Tue, 19 Dec 2017 02:27:49 +0100") Message-ID: <87fu86zqb1.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: nee Cc: 29610@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable nee writes: > Am 18.12.2017 um 17:52 schrieb Kei Kebreau: >> A few things: >> * Please end the "fix-makefile-paths" phase with a #t. >> * It turns out that the license is actually gpl2+. >> * The description's indentation seems a bit early and weird. That is, we >> can have up to 80 characters per line in our description, and some of >> the description can be adjusted accordingly. >>=20 > > GJ spotting all of this. Here is the updated patch. One more nitpick: our commit messages tend not to include the name of the file being added to, so they look like gnu: Add quakespasm. as opposed to gnu: games: Add quakespasm. I've fixed that bit, though, and this patch is otherwise great! I've pushed this to master. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlo5MRIACgkQ5qXuPBlG eg1x9w//Tbgdya1RwDNOs4tVD1hn8hzVvdur2sDv8TmrKMfqj2vKq1vYYkmauipd o5Tmx7fDkTsHVV/lEubHSsMuh0zgWtQyVeS2U91KX0APRj33Gx+ePi0RIi0v7ukE s/PzJr2Zgxoj8UcU9wZ4WQH1rDQqFDg1aeiDGopEso7xqINZnagjtCRvFLaGQXa9 xi1mh8mBZDAll14GS/e0ZOl52Py+REcFx95xP5r8tyZSg4vTmi4mr+0xHxTWSQnF w5O+NvrPcVP1z2JpBjzjy29nxQLhHACMwxXTeAGB876BsoCVrWX+meMqD+dQ0spv GUwRZsZrNT43JN/flt1+KdLwTbvZK6ifvBydk19TSVaTaaqcEtLT4XlwUgx/Aj11 lpggxsTaJvgMYPv9DMiiqUdQcFeu5S/qKRSOjD1Xt4X3wMhcBcOiq81GC23HB0ko bs9iNDgk/E3MX9vyAM3e+JKubpVP83bTaBlR7bs+FVpaGaLJ0vGB3eqYIMLmmcn4 0sKxHXf1f2qeALhhu04n8mNHZOYFSgPag+MK209tyFMIQzujYA+egZEwpc22LH7g B86nn7y8srkMO4Dzq/9fsl1HzyPcjnzRS7CtpyyjvjqjWc8JFr92M0DIn1zHYpik CIj6j/7zQOMmPQpUYjV02CYwghLGBlY72Zq9fn5KTJk74PHgkJg= =JdPP -----END PGP SIGNATURE----- --=-=-=--