From: Kei Kebreau <kkebreau@posteo.net>
To: nee <nee@cock.li>
Cc: 29610@debbugs.gnu.org
Subject: [bug#29610] [PATCH] gnu: games: Add quakespasm.
Date: Tue, 19 Dec 2017 10:32:34 -0500 [thread overview]
Message-ID: <87fu86zqb1.fsf@posteo.net> (raw)
In-Reply-To: <3f4e7ae4-0ab6-7d89-71c4-9d3dd54d2e00@cock.li> (nee@cock.li's message of "Tue, 19 Dec 2017 02:27:49 +0100")
[-- Attachment #1: Type: text/plain, Size: 760 bytes --]
nee <nee@cock.li> writes:
> Am 18.12.2017 um 17:52 schrieb Kei Kebreau:
>> A few things:
>> * Please end the "fix-makefile-paths" phase with a #t.
>> * It turns out that the license is actually gpl2+.
>> * The description's indentation seems a bit early and weird. That is, we
>> can have up to 80 characters per line in our description, and some of
>> the description can be adjusted accordingly.
>>
>
> GJ spotting all of this. Here is the updated patch.
One more nitpick: our commit messages tend not to include the name of
the file being added to, so they look like
gnu: Add quakespasm.
as opposed to
gnu: games: Add quakespasm.
I've fixed that bit, though, and this patch is otherwise great! I've
pushed this to master.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2017-12-19 15:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 21:59 [bug#29610] [PATCH] gnu: games: Add quakespasm nee
2017-12-18 16:52 ` Kei Kebreau
2017-12-19 1:27 ` nee
2017-12-19 15:32 ` Kei Kebreau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fu86zqb1.fsf@posteo.net \
--to=kkebreau@posteo.net \
--cc=29610@debbugs.gnu.org \
--cc=nee@cock.li \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).