From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35790) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eu2YA-0007qd-Kr for guix-patches@gnu.org; Thu, 08 Mar 2018 15:54:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eu2Y6-0002HF-4a for guix-patches@gnu.org; Thu, 08 Mar 2018 15:54:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:43619) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eu2Y6-0002H5-0H for guix-patches@gnu.org; Thu, 08 Mar 2018 15:54:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eu2Y5-0004Ks-Q6 for guix-patches@gnu.org; Thu, 08 Mar 2018 15:54:01 -0500 Subject: [bug#30734] [PATCH core-updates 3/3] gnu: net-tools: Don't install 'ifconfig'. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20180306165642.4486-1-mbakke@fastmail.com> <20180306165642.4486-3-mbakke@fastmail.com> <87zi3jporb.fsf@gnu.org> <87woym70ue.fsf@fastmail.com> Date: Thu, 08 Mar 2018 21:53:26 +0100 In-Reply-To: <87woym70ue.fsf@fastmail.com> (Marius Bakke's message of "Thu, 08 Mar 2018 21:45:45 +0100") Message-ID: <87fu5al261.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: 30734@debbugs.gnu.org Marius Bakke skribis: > Ludovic Court=C3=A8s writes: > >> Marius Bakke skribis: >> >>> * gnu/packages/linux.scm (net-tools)[arguments]: In >>> REMOVE-REDUNDANT-COMMANDS-PHASE, add regexp for ifconfig. >>> --- >>> gnu/packages/linux.scm | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm >>> index dffe2c49c..8c07d1fdd 100644 >>> --- a/gnu/packages/linux.scm >>> +++ b/gnu/packages/linux.scm >>> @@ -1290,7 +1290,7 @@ inadequately in modern network environments, and = both should be deprecated.") >>> ;; Remove commands and man pages redundant with Inetuti= ls. >>> (let* ((out (assoc-ref outputs "out")) >>> (dup (append-map (cut find-files out <>) >>> - '("^hostname" >>> + '("^hostname" "^ifconfig" >> >> GNU ifconfig is somewhat incompatible and may have a different feature >> set compared to the one of net-tools, so I=E2=80=99d be in favor of keep= ing it. >> >> WDYT? > > The motivation for this commit was to remove a conflict in > %base-packages. Currently it's entirely random which ifconfig ends up > in the system profile, which is not great. I think it=E2=80=99s not _entirely_ random, but I agree it=E2=80=99s not gr= eat. ;-) > What about the below hack? Alternatively, it could be moved to a > separate output. Thoughts? > > From 0887b6af81781ae74f0a34c59f32ed098fa199dc Mon Sep 17 00:00:00 2001 > From: Marius Bakke > Date: Thu, 8 Mar 2018 21:41:13 +0100 > Subject: [PATCH] gnu: net-tools: Move 'ifconfig' to "/sbin". > > * gnu/packages/linux.scm (net-tools)[arguments]: In > REMOVE-REDUNDANT-COMMANDS-PHASE, use rename-file on ifconfig. > --- > gnu/packages/linux.scm | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm > index 875f11062..916309b79 100644 > --- a/gnu/packages/linux.scm > +++ b/gnu/packages/linux.scm > @@ -1286,6 +1286,11 @@ inadequately in modern network environments, and b= oth should be deprecated.") > '("^hostname" > "^(yp|nis|dns)?domainname")))) > (for-each delete-file dup) > + ;; ifconfig from net-tools is somewhat incompatible with > + ;; GNU ifconfig, so we keep it around. Move it to "/sb= in" > + ;; to prevent conflict in %base-packages. > + (rename-file (string-append out "/bin/ifconfig") > + (string-append out "/sbin/ifconfig")) > #t)))) Sure, either that or rename it to =E2=80=9Cifconfig.net-tools=E2=80=9D (I t= hink Debian sometimes does things like this.) But, isc-dhcp depends on net-tools, and it might have scripts that depend on its ifconfig, for instance. Same for virtuoso-ose, isc-bind, iodine, and more. So all in all, your suggestion may be safer, though we should check whether these things break. Thank you, Ludo=E2=80=99.