From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60156)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fbplg-0000mj-1A
	for guix-patches@gnu.org; Sat, 07 Jul 2018 12:09:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fbple-0002dh-R0
	for guix-patches@gnu.org; Sat, 07 Jul 2018 12:09:03 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:42442)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fbple-0002dU-N8
	for guix-patches@gnu.org; Sat, 07 Jul 2018 12:09:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fbple-000865-Ic
	for guix-patches@gnu.org; Sat, 07 Jul 2018 12:09:02 -0400
Subject: bug#31881: [PATCH 4/4] gnu: Add go-github-com-docker-distribution.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.31881.D31881.153097972331091.done@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180619084333.8993-1-pierre-antoine.rouby@inria.fr>
	<20180619084333.8993-4-pierre-antoine.rouby@inria.fr>
	<20180620170048.GD1240@jasmine.lan>
	<1040680639.2490239.1530026409131.JavaMail.zimbra@inria.fr>
Date: Sat, 07 Jul 2018 18:08:33 +0200
In-Reply-To: <1040680639.2490239.1530026409131.JavaMail.zimbra@inria.fr>
	(Pierre-Antoine Rouby's message of "Tue, 26 Jun 2018 17:20:09 +0200
	(CEST)")
Message-ID: <87fu0v3u66.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Pierre-Antoine Rouby <pierre-antoine.rouby@inria.fr>
Cc: 31881-done@debbugs.gnu.org

Hello!

Pierre-Antoine Rouby <pierre-antoine.rouby@inria.fr> skribis:

>> From: "Leo Famulari" <leo@famulari.name>
>>> +      (source
>>> +       (origin
>>> +         (method git-fetch)
>>> +         (uri (git-reference
>>> +               (url "https://github.com/docker/distribution")
>>> +               (commit commit)))
>>
>> This bundles its entire dependency graph, including the logrus module
>> you just packaged, and some other things we have packaged:
>
> I'm not sure vendor version is the same as package version. I have the
> impression some Go package have no tag or CHANGELOG, so I'm not sure for
> compatibility. Without explicit version number I thinks is more sure to
> use the vendor version.
>
>> I think it's okay to add the package with the bundled code if everything
>> is freely licensed. Can you confirm that it is?
>
> Yes, everything is free.

Based on this I went ahead and applied it, but I added a FIXME about
bundling.

P-A, could you look into unbundling at least those that are already
packaged?

Thank you!

Ludo=E2=80=99.