unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Pierre-Antoine Rouby <pierre-antoine.rouby@inria.fr>
Cc: 31881-done@debbugs.gnu.org
Subject: bug#31881: [PATCH 4/4] gnu: Add go-github-com-docker-distribution.
Date: Sat, 07 Jul 2018 18:08:33 +0200	[thread overview]
Message-ID: <87fu0v3u66.fsf@gnu.org> (raw)
In-Reply-To: <1040680639.2490239.1530026409131.JavaMail.zimbra@inria.fr> (Pierre-Antoine Rouby's message of "Tue, 26 Jun 2018 17:20:09 +0200 (CEST)")

Hello!

Pierre-Antoine Rouby <pierre-antoine.rouby@inria.fr> skribis:

>> From: "Leo Famulari" <leo@famulari.name>
>>> +      (source
>>> +       (origin
>>> +         (method git-fetch)
>>> +         (uri (git-reference
>>> +               (url "https://github.com/docker/distribution")
>>> +               (commit commit)))
>>
>> This bundles its entire dependency graph, including the logrus module
>> you just packaged, and some other things we have packaged:
>
> I'm not sure vendor version is the same as package version. I have the
> impression some Go package have no tag or CHANGELOG, so I'm not sure for
> compatibility. Without explicit version number I thinks is more sure to
> use the vendor version.
>
>> I think it's okay to add the package with the bundled code if everything
>> is freely licensed. Can you confirm that it is?
>
> Yes, everything is free.

Based on this I went ahead and applied it, but I added a FIXME about
bundling.

P-A, could you look into unbundling at least those that are already
packaged?

Thank you!

Ludo’.

  reply	other threads:[~2018-07-07 16:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-18 15:15 [bug#31881] [PATCH 1/4] gnu: Add go-github-com-sirupsen-logrus Rouby Pierre-Antoine
2018-06-18 15:18 ` [bug#31881] [PATCH 2/4] gnu: Add go-github-com-kardianos-osext Rouby Pierre-Antoine
2018-06-18 15:18   ` [bug#31881] [PATCH 3/4] gnu: Add go-github-com-ayufan-golang-kardianos-service Rouby Pierre-Antoine
2018-06-18 15:18   ` [bug#31881] [PATCH 4/4] gnu: Add go-github-com-docker-distribution Rouby Pierre-Antoine
2018-06-18 16:12 ` [bug#31881] [PATCH 1/4] gnu: Add go-github-com-sirupsen-logrus Leo Famulari
2018-06-19  8:43 ` Rouby Pierre-Antoine
2018-06-19  8:43   ` [bug#31881] [PATCH 2/4] gnu: Add go-github-com-kardianos-osext Rouby Pierre-Antoine
2018-06-20 16:56     ` Leo Famulari
2018-06-19  8:43   ` [bug#31881] [PATCH 3/4] gnu: Add go-github-com-ayufan-golang-kardianos-service Rouby Pierre-Antoine
2018-06-20 16:57     ` Leo Famulari
2018-06-19  8:43   ` [bug#31881] [PATCH 4/4] gnu: Add go-github-com-docker-distribution Rouby Pierre-Antoine
2018-06-20 17:00     ` Leo Famulari
2018-06-26 15:20       ` Pierre-Antoine Rouby
2018-07-07 16:08         ` Ludovic Courtès [this message]
2018-06-20 16:56   ` [bug#31881] [PATCH 1/4] gnu: Add go-github-com-sirupsen-logrus Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fu0v3u66.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=31881-done@debbugs.gnu.org \
    --cc=pierre-antoine.rouby@inria.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).