From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44410) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdj7C-0006Az-TX for guix-patches@gnu.org; Thu, 12 Jul 2018 17:27:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fdj78-0004cq-V5 for guix-patches@gnu.org; Thu, 12 Jul 2018 17:27:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:49535) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fdj78-0004bu-KX for guix-patches@gnu.org; Thu, 12 Jul 2018 17:27:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fdj78-0006dI-6r for guix-patches@gnu.org; Thu, 12 Jul 2018 17:27:02 -0400 Subject: [bug#31999] [PATCH 4/7] gnu: lvm2: Add device-mapper-event support. Resent-Message-ID: From: Marius Bakke In-Reply-To: <20180628213527.23318-3-ambrevar@gmail.com> References: <20180628213527.23318-1-ambrevar@gmail.com> <20180628213527.23318-3-ambrevar@gmail.com> Date: Thu, 12 Jul 2018 23:26:49 +0200 Message-ID: <87fu0o6t7q.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Pierre Neidhardt , 31999@debbugs.gnu.org --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Pierre Neidhardt writes: > * GNU/packages/linux.scm (lvm2)[configure-flags]: Build device-mapper-event. [...] > + "--enable-cmdlib" > + "--enable-dmeventd" ; Requires '--enable-cmdlib'. I was able to get this working by modifying LDFLAGS *and* CLDFLAGS like so: --=-=-= Content-Type: text/x-patch Content-Disposition: inline 1 file changed, 12 insertions(+), 1 deletion(-) gnu/packages/linux.scm | 13 ++++++++++++- modified gnu/packages/linux.scm @@ -2133,11 +2133,22 @@ time.") "--enable-udev_rules" "--enable-pkgconfig" + "--enable-cmdlib" + "--enable-dmeventd" + ;; Make sure programs such as 'dmsetup' can ;; find libdevmapper.so. (string-append "LDFLAGS=-Wl,-rpath=" (assoc-ref %outputs "out") - "/lib")) + "/lib,-rpath=" + (assoc-ref %outputs "out") + "/lib/device-mapper") + (string-append "CLDFLAGS=-Wl,-rpath=" + (assoc-ref %outputs "out") + "/lib,-rpath=" + (assoc-ref %outputs "out") + "/lib/device-mapper") + ) ;; The tests use 'mknod', which requires root access. #:tests? #f)) [back] --=-=-= Content-Type: text/plain The reason CLDFLAGS is required is because the dmeventd plugins do not respect LDFLAGS. See "%.so" (around line 449) in make.tmpl.in. I think it would be okay to patch the Make template to also take LDFLAGS into account. Not sure what CLDFLAGS is used for, but it seems redundant to have the same contents in both. Can you try that? --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAltHx5kACgkQoqBt8qM6 VPpIJgf/VRvuynihoJddscdWoRKdv0dPasN1A7PVWSGvMDqCVXTZNkZlxzYEm/p9 P38BRHu9kHhzrLw1lQXPqD4O1BZnWl0TxQ5EyFCks2xdTaB5Sgcktf1guLShYJq3 867ycjIXGG20vf4/Do/+ENCnqTNFXKwpyTvLcN7DhZDGrx/zWfW1tJdF1VbyFkmF ZoKdIXj+40zpDmXwzCy8epXfurPK0MDWV0uivPM6nso6rUTjO95WWvIi7Ezwn+Be ft7ogrhoq19biWBqf19/VzqkmAa5ae6djCVh6crL/zpTzR6Egd43XuHXBBVDfjdH DsgtVV8r/VMY3ih/gnkI93JsJq38aQ== =kMeH -----END PGP SIGNATURE----- --==-=-=--