unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#33572] Guile-JSON now seems to be a required dependency
       [not found]           ` <20181202163850.63cb6d9e@centurylink.net>
@ 2018-12-03  8:46             ` Ludovic Courtès
  2018-12-03 14:58               ` Eric Bavier
  0 siblings, 1 reply; 2+ messages in thread
From: Ludovic Courtès @ 2018-12-03  8:46 UTC (permalink / raw)
  To: Eric Bavier; +Cc: guix-devel, Joshua Branson, 33572

Hi,

Eric Bavier <ericbavier@centurylink.net> skribis:

> From 5f04eb187de528f5879bd84901f71dba13c68f43 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Sat, 1 Dec 2018 20:46:22 -0600
> Subject: [PATCH] Make Guile-JSON a required dependency.
>
> * README (Requirements): Remove "optional" verbiage.
> * doc/guix.texi (Requirements): Move Guile-JSON from optional to required.
> * configure.ac (HAVE_GUILE_JSON): Remove Automake conditional.
> (have_guile_json): Error if not "yes".
> * Makefile.am (MODULE, SCM_TESTS)[HAVE_GUILE_JSON]: Add modules and tests
> unconditionally.
> * gnu/packages/package-mangement.scm (guix-minimal)[propagated-inputs]: Leave
> guile-json input.

One last thing: guix.texi contains a few footnotes like:

  This functionality requires Guile-JSON to be installed.

Could you remove them as well?

Otherwise LGTM, thank you!

Ludo’.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [bug#33572] Guile-JSON now seems to be a required dependency
  2018-12-03  8:46             ` [bug#33572] Guile-JSON now seems to be a required dependency Ludovic Courtès
@ 2018-12-03 14:58               ` Eric Bavier
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Bavier @ 2018-12-03 14:58 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel, Joshua Branson, 33572

[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]

On Mon, 03 Dec 2018 09:46:40 +0100
ludo@gnu.org (Ludovic Courtès) wrote:

> Hi,
> 
> Eric Bavier <ericbavier@centurylink.net> skribis:
> 
> > From 5f04eb187de528f5879bd84901f71dba13c68f43 Mon Sep 17 00:00:00 2001
> > From: Eric Bavier <bavier@member.fsf.org>
> > Date: Sat, 1 Dec 2018 20:46:22 -0600
> > Subject: [PATCH] Make Guile-JSON a required dependency.
> >
> > * README (Requirements): Remove "optional" verbiage.
> > * doc/guix.texi (Requirements): Move Guile-JSON from optional to required.
> > * configure.ac (HAVE_GUILE_JSON): Remove Automake conditional.
> > (have_guile_json): Error if not "yes".
> > * Makefile.am (MODULE, SCM_TESTS)[HAVE_GUILE_JSON]: Add modules and tests
> > unconditionally.
> > * gnu/packages/package-mangement.scm (guix-minimal)[propagated-inputs]: Leave
> > guile-json input.  
> 
> One last thing: guix.texi contains a few footnotes like:
> 
>   This functionality requires Guile-JSON to be installed.
> 
> Could you remove them as well?

Good catch.  Thanks.  Fixed in a8fdca11d85296b4df1b60a0c8ce4e33c92759af

`~Eric

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-12-03 14:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <87y399am9b.fsf@ngyro.com>
     [not found] ` <20181201091658.720e1f20@centurylink.net>
     [not found]   ` <87sgzh9ivq.fsf@ngyro.com>
     [not found]     ` <87woorg3hk.fsf@fastmail.com>
     [not found]       ` <87a7lnlhd8.fsf@gnu.org>
     [not found]         ` <20181202162225.500e1721@centurylink.net>
     [not found]           ` <20181202163850.63cb6d9e@centurylink.net>
2018-12-03  8:46             ` [bug#33572] Guile-JSON now seems to be a required dependency Ludovic Courtès
2018-12-03 14:58               ` Eric Bavier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).