unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Lirzin <mthl@gnu.org>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 33698@debbugs.gnu.org
Subject: [bug#33698] [PATCH v2 0/2] Update emacs-cider
Date: Tue, 11 Dec 2018 09:51:24 +0100	[thread overview]
Message-ID: <87ftv41m5v.fsf@gnu.org> (raw)
In-Reply-To: <20181211065147.18404-1-arunisaac@systemreboot.net> (Arun Isaac's message of "Tue, 11 Dec 2018 12:21:44 +0530")

Hello Arun,

Arun Isaac <arunisaac@systemreboot.net> writes:

> I've made several modifications to your patches. Most notably, I have changed
> the synopsis and description of emacs-sesman. I have switched both
> emacs-sesman and emacs-cider to using git-fetch. We do this now because
> auto-generated github tarballs are unstable and cause hash mismatch errors. I
> also enabled tests for emacs-sesman and made a few other minor stylistic
> changes.
>
> Let me know if the updated patches are fine. If they are, I will push them to
> master.

Excellent, thanks for polishing the patches and letting me know about
the ‘git-fetch’ policy change.  I saw various commits in the Git log
doing such changes without understanding the goal since commit messages
don't include any context/rationale.

Please go ahead.

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37

  parent reply	other threads:[~2018-12-11  8:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-10 22:17 [bug#33698] [PATCH 0/2] Update emacs-cider Mathieu Lirzin
2018-12-10 22:20 ` [bug#33698] [PATCH 1/2] gnu: Add emacs-sesman Mathieu Lirzin
2018-12-10 22:20   ` [bug#33698] [PATCH 2/2] gnu: emacs-cider: Update to 0.18.0 Mathieu Lirzin
2018-12-11  6:51 ` [bug#33698] [PATCH v2 0/2] Update emacs-cider Arun Isaac
2018-12-11  6:51   ` [bug#33698] [PATCH v2 1/2] gnu: Add emacs-sesman Arun Isaac
2018-12-11  6:51   ` [bug#33698] [PATCH v2 2/2] gnu: emacs-cider: Update to 0.18.0 Arun Isaac
2018-12-11  8:51   ` Mathieu Lirzin [this message]
2018-12-11 17:44     ` bug#33698: [PATCH v2 0/2] Update emacs-cider Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftv41m5v.fsf@gnu.org \
    --to=mthl@gnu.org \
    --cc=33698@debbugs.gnu.org \
    --cc=arunisaac@systemreboot.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).