From: "Ludovic Courtès" <ludo@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 33893@debbugs.gnu.org
Subject: [bug#33893] [PATCH v5 3/4] services: Add docker.
Date: Sun, 06 Jan 2019 21:31:00 +0100 [thread overview]
Message-ID: <87ftu5y1dn.fsf@gnu.org> (raw)
In-Reply-To: <20181230233903.23426-4-dannym@scratchpost.org> (Danny Milosavljevic's message of "Mon, 31 Dec 2018 00:39:02 +0100")
Danny Milosavljevic <dannym@scratchpost.org> skribis:
> * gnu/services/docker.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
> * doc/guix.texi (Miscellaneous Services): Document the service.
Nice!
> +@cindex docker
“Docker” with a capital.
> +@subsubheading Docker Service
> +
> +The @code{(gnu services docker)} module provides the following service.
> +
> +@defvr {Scheme Variable} docker-service-type
> +
> +This is a service that runs @url{http://www.docker.com,Docker}, a daemon that
> +provides container functionality.
> +
We’re missing “@end defvr” I guess.
I think we shouldn’t propagate the narrative that Docker = container.
So what about something like:
This is the type of the service that runs @url{…, Docker}, a daemon
that can execute application bundles (sometimes referred to as
``containers'') in isolated environments.
?
Also could you document ‘docker-configuration’ as well?
[...]
> +;; TODO: Refactor out into its own module? How to depend on it then?
> +(define (containerd-shepherd-service config)
> + (let* ((package (docker-configuration-containerd config)))
> + (shepherd-service
> + (documentation "containerd daemon.")
> + (provision '(containerd))
> + (start #~(make-forkexec-constructor
> + (list (string-append #$package "/bin/containerd"))))
> + (stop #~(make-kill-destructor)))))
I suppose there could be a separate ‘containerd-service-type’ if it’s
useful; if it’s not, it’s OK to keep it this way.
As for the dependency, users would have to add both docker and
containerd to their service list, or docker-service-type could extend
containerd-service-type, which would ensure containerd-service-type is
automatically instantiated if it’s not already in the user’s service
list.
> +(define docker-service-type
> + (service-type (name 'docker)
> + (extensions
> + (list
> + (service-extension activation-service-type
> + %docker-activation)
> + (service-extension shepherd-root-service-type
> + (lambda args
> + (list (apply containerd-shepherd-service args)
> + (apply docker-shepherd-service args))))
You can make the above (lambda (config) …) instead of (lambda (args) …).
> + (service-extension account-service-type
> + (const %docker-accounts))))
> + (default-value (docker-configuration))))
Please add a ‘description’ field here, and please remove tabs from the
file. :-)
Could you consider adding a system test for docker/containerd? Perhaps
we could go as far as using ‘docker-image’ in (guix scripts pack) to
generate an image and make sure ‘docker load’ works, but maybe that’s
too much work.
Thank you,
Ludo’.
next prev parent reply other threads:[~2019-01-06 20:32 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-28 10:13 [bug#33893] [PATCH 0/2] Add docker Danny Milosavljevic
2018-12-28 10:17 ` [bug#33893] [PATCH 1/2] gnu: Add docker-engine Danny Milosavljevic
2018-12-28 10:17 ` [bug#33893] [PATCH 2/2] gnu: Add docker-cli Danny Milosavljevic
2018-12-29 1:32 ` [bug#33893] [PATCH v2 0/3] Add docker Danny Milosavljevic
2018-12-29 1:32 ` [bug#33893] [PATCH v2 1/3] gnu: Add containerd Danny Milosavljevic
2018-12-29 1:32 ` [bug#33893] [PATCH v2 2/3] gnu: Add docker-engine Danny Milosavljevic
2018-12-29 1:32 ` [bug#33893] [PATCH v2 3/3] services: Add docker Danny Milosavljevic
2018-12-29 1:39 ` [bug#33893] [PATCH v3 0/4] " Danny Milosavljevic
2018-12-29 1:39 ` [bug#33893] [PATCH v3 1/4] gnu: Add containerd Danny Milosavljevic
2018-12-29 1:39 ` [bug#33893] [PATCH v3 2/4] gnu: Add docker-engine Danny Milosavljevic
2018-12-29 1:39 ` [bug#33893] [PATCH v3 3/4] services: Add docker Danny Milosavljevic
2018-12-30 9:50 ` Danny Milosavljevic
2018-12-29 1:39 ` [bug#33893] [PATCH v3 4/4] gnu: Add docker-cli Danny Milosavljevic
2018-12-30 12:17 ` [bug#33893] [PATCH v4 0/4] Add docker Danny Milosavljevic
2018-12-30 12:17 ` [bug#33893] [PATCH v4 1/4] gnu: Add containerd Danny Milosavljevic
2018-12-30 12:17 ` [bug#33893] [PATCH v4 2/4] gnu: Add docker-engine Danny Milosavljevic
2018-12-30 12:17 ` [bug#33893] [PATCH v4 3/4] services: Add docker Danny Milosavljevic
2018-12-30 12:17 ` [bug#33893] [PATCH v4 4/4] gnu: Add docker-cli Danny Milosavljevic
2018-12-30 23:38 ` [bug#33893] [PATCH v5 0/4] Add docker Danny Milosavljevic
2018-12-30 23:39 ` [bug#33893] [PATCH v5 1/4] gnu: Add containerd Danny Milosavljevic
2019-01-06 20:14 ` Ludovic Courtès
2018-12-30 23:39 ` [bug#33893] [PATCH v5 2/4] gnu: Add docker-engine Danny Milosavljevic
2019-01-06 20:20 ` Ludovic Courtès
2019-01-07 18:44 ` Danny Milosavljevic
2019-01-08 8:42 ` Ludovic Courtès
2019-01-10 2:22 ` Danny Milosavljevic
2019-01-10 8:50 ` bug#33893: " Ludovic Courtès
2019-01-10 13:15 ` [bug#33893] " Danny Milosavljevic
2019-01-10 20:31 ` Leo Famulari
2018-12-30 23:39 ` [bug#33893] [PATCH v5 3/4] services: Add docker Danny Milosavljevic
2019-01-06 20:31 ` Ludovic Courtès [this message]
2018-12-30 23:39 ` [bug#33893] [PATCH v5 4/4] gnu: Add docker-cli Danny Milosavljevic
2019-01-06 20:33 ` Ludovic Courtès
2019-01-14 3:20 ` Meiyo Peng
2019-01-15 12:34 ` Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftu5y1dn.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=33893@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).