unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#34159] [PATCH] Fix sporadic test failures in mariadb
@ 2019-01-21 16:59 Carl Dong
  2019-01-22  7:23 ` Christopher Baines
  2019-01-23  3:47 ` bug#34159: " Eric Bavier
  0 siblings, 2 replies; 4+ messages in thread
From: Carl Dong @ 2019-01-21 16:59 UTC (permalink / raw)
  To: 34159

From 6963ef73ccfbbc2e22a2b90b567d65cf37a2be0a Mon Sep 17 00:00:00 2001
From: Carl Dong <accounts@carldong.me>
Date: Mon, 21 Jan 2019 11:53:05 -0500
Subject: [PATCH] gnu: mariadb: Disable sporadically failing tests.

* guix/packages/databases.scm: Disable sporadically failing tests.
---
 gnu/packages/databases.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index 655e7c3a3..e08a179bf 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -582,6 +582,8 @@ Language.")
                       "main.explain_non_select"
                       "main.stat_tables_innodb"
                       "roles.acl_statistics"
+                      "main.mysqldump"
+                      "innodb_fts.crash_recovery"

                       ;; FIXME: This test fails on i686:
                       ;; -myisampack: Can't create/write to file (Errcode: 17 "File exists")
--
2.20.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#34159] [PATCH] Fix sporadic test failures in mariadb
  2019-01-21 16:59 [bug#34159] [PATCH] Fix sporadic test failures in mariadb Carl Dong
@ 2019-01-22  7:23 ` Christopher Baines
  2019-01-22 21:40   ` Ludovic Courtès
  2019-01-23  3:47 ` bug#34159: " Eric Bavier
  1 sibling, 1 reply; 4+ messages in thread
From: Christopher Baines @ 2019-01-22  7:23 UTC (permalink / raw)
  To: Carl Dong; +Cc: 34159

[-- Attachment #1: Type: text/plain, Size: 1430 bytes --]


Carl Dong <accounts@carldong.me> writes:

> From 6963ef73ccfbbc2e22a2b90b567d65cf37a2be0a Mon Sep 17 00:00:00 2001
> From: Carl Dong <accounts@carldong.me>
> Date: Mon, 21 Jan 2019 11:53:05 -0500
> Subject: [PATCH] gnu: mariadb: Disable sporadically failing tests.
>
> * guix/packages/databases.scm: Disable sporadically failing tests.
> ---
>  gnu/packages/databases.scm | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
> index 655e7c3a3..e08a179bf 100644
> --- a/gnu/packages/databases.scm
> +++ b/gnu/packages/databases.scm
> @@ -582,6 +582,8 @@ Language.")
>                        "main.explain_non_select"
>                        "main.stat_tables_innodb"
>                        "roles.acl_statistics"
> +                      "main.mysqldump"
> +                      "innodb_fts.crash_recovery"
>
>                        ;; FIXME: This test fails on i686:
>                        ;; -myisampack: Can't create/write to file (Errcode: 17 "File exists")

Hi Carl,

Thanks for looking at this.

I'd be interested to know what the sporadic test failures look like, do
you have a error message you could share?

Currently, there is a comment that sits just above the lines you've
added which says why roles.acl_statistics and 3 other tests are
disabled, so it would be good to confirm if the reason is the same, or a
new comment is needed.

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#34159] [PATCH] Fix sporadic test failures in mariadb
  2019-01-22  7:23 ` Christopher Baines
@ 2019-01-22 21:40   ` Ludovic Courtès
  0 siblings, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2019-01-22 21:40 UTC (permalink / raw)
  To: Christopher Baines; +Cc: Carl Dong, 34159

Hello,

Christopher Baines <mail@cbaines.net> skribis:

> I'd be interested to know what the sporadic test failures look like, do
> you have a error message you could share?

On the build farm, mariadb tests would sometimes fail in obscure ways
because they had not enough space (and they need a whole lot of disk
space!).  Could that be related?

Anyway, thanks for investigating, Carl!

Ludo’.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#34159: [PATCH] Fix sporadic test failures in mariadb
  2019-01-21 16:59 [bug#34159] [PATCH] Fix sporadic test failures in mariadb Carl Dong
  2019-01-22  7:23 ` Christopher Baines
@ 2019-01-23  3:47 ` Eric Bavier
  1 sibling, 0 replies; 4+ messages in thread
From: Eric Bavier @ 2019-01-23  3:47 UTC (permalink / raw)
  To: Carl Dong; +Cc: 34159-done

[-- Attachment #1: Type: text/plain, Size: 1389 bytes --]

On Mon, 21 Jan 2019 16:59:44 +0000
Carl Dong <accounts@carldong.me> wrote:

> From 6963ef73ccfbbc2e22a2b90b567d65cf37a2be0a Mon Sep 17 00:00:00 2001
> From: Carl Dong <accounts@carldong.me>
> Date: Mon, 21 Jan 2019 11:53:05 -0500
> Subject: [PATCH] gnu: mariadb: Disable sporadically failing tests.
> 
> * guix/packages/databases.scm: Disable sporadically failing tests.
> ---
>  gnu/packages/databases.scm | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
> index 655e7c3a3..e08a179bf 100644
> --- a/gnu/packages/databases.scm
> +++ b/gnu/packages/databases.scm
> @@ -582,6 +582,8 @@ Language.")
>                        "main.explain_non_select"
>                        "main.stat_tables_innodb"
>                        "roles.acl_statistics"
> +                      "main.mysqldump"
> +                      "innodb_fts.crash_recovery"
> 
>                        ;; FIXME: This test fails on i686:
>                        ;; -myisampack: Can't create/write to file (Errcode: 17 "File exists")

Pushed to the "staging" branch, due to the 488 dependents, in commit
38f77be464b0b6ca76105d5f0a1b5e55fd694036

BTW, the "main.mysqldump" was disabled recently on the core-updates
branch in commit cbd833750a57ae0596e80d06c74b02bccddf6197.  The two can
trivially be merged later.

`~Eric

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-01-23  3:48 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-21 16:59 [bug#34159] [PATCH] Fix sporadic test failures in mariadb Carl Dong
2019-01-22  7:23 ` Christopher Baines
2019-01-22 21:40   ` Ludovic Courtès
2019-01-23  3:47 ` bug#34159: " Eric Bavier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).