From: Ricardo Wurmus <rekado@elephly.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 34040@debbugs.gnu.org
Subject: [bug#34040] [PATCH 1/2] refresh: Suggest input changes when updating.
Date: Fri, 25 Jan 2019 22:48:58 +0100 [thread overview]
Message-ID: <87fttgv25x.fsf@elephly.net> (raw)
In-Reply-To: <87y378moax.fsf@gnu.org>
Ludovic Courtès <ludo@gnu.org> writes:
>>> Alternately, we could change ‘input-changes’ to ‘inputs’, which would be
>>> absolute, not relative, and thus ‘package-update’ would take care of
>>> calling ‘changed-inputs’ etc.
>>
>> That would also work, but I think I prefer an updater to report changes
>> rather than a new list of inputs.
>
> OTOH if we return a complete list of inputs, then we don’t have to worry
> about the cost of ‘changed-inputs’ since that would only be called on
> demand; also there’d be a single call site for ‘changed-inputs’.
The potentially expensive part is to get the inputs, though. Getting a
list of new inputs means that the importer needs to be run. For CRAN
packages this requires downloading the tarball and unpacking parts of
it.
--
Ricardo
next prev parent reply other threads:[~2019-01-26 1:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 9:11 [bug#34040] Suggest input changes when updating packages Ricardo Wurmus
2019-01-11 9:42 ` [bug#34040] [PATCH 1/2] refresh: Suggest input changes when updating Ricardo Wurmus
2019-01-11 9:42 ` [bug#34040] [PATCH 2/2] import: cran: Suggest input changes Ricardo Wurmus
2019-01-12 13:42 ` Ludovic Courtès
2019-01-12 21:11 ` Ricardo Wurmus
2019-01-12 13:40 ` [bug#34040] [PATCH 1/2] refresh: Suggest input changes when updating Ludovic Courtès
2019-01-21 21:34 ` Ludovic Courtès
2019-01-25 16:21 ` Ricardo Wurmus
2019-01-25 21:15 ` Ludovic Courtès
2019-01-25 21:48 ` Ricardo Wurmus [this message]
2019-01-26 13:53 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fttgv25x.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=34040@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).