From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:39159)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h7nju-00010y-E8
	for guix-patches@gnu.org; Sat, 23 Mar 2019 16:59:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h7nba-0005yg-9u
	for guix-patches@gnu.org; Sat, 23 Mar 2019 16:51:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:42269)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1h7nba-0005yD-4B
	for guix-patches@gnu.org; Sat, 23 Mar 2019 16:51:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h7nbZ-00064n-SO
	for guix-patches@gnu.org; Sat, 23 Mar 2019 16:51:01 -0400
Subject: [bug#34958] Add a package argument to dune-build-system
Resent-Message-ID: <handler.34958.B34958.155337421623284@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
In-Reply-To: <20190323194934.07e3d48e@lepiller.eu> (Julien Lepiller's message
	of "Sat, 23 Mar 2019 19:49:34 +0100")
References: <20190323194934.07e3d48e@lepiller.eu>
Date: Sat, 23 Mar 2019 21:50:04 +0100
Message-ID: <87ftrduxhf.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 34958@debbugs.gnu.org

Hi!

Julien Lepiller <julien@lepiller.eu> skribis:

>>>From 619eb1219ac34d4974da4a3794df0e5a6098e48f Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien@lepiller.eu>
> Date: Sat, 23 Mar 2019 19:18:31 +0100
> Subject: [PATCH 1/2] guix: dune-build-system: Add a package parameter.
>
> * guix/build-system/dune.scm: Add a package parameter.
> * guix/build/dune.scm (build, test, install): Use it.
> * doc/guix.texi: Document it.

[...]

> +The @code{#:package} parameter can be passed to specify a packagename, w=
hich
                                                                   ^^
Missing space.

> +is usefull when a package contains multiple packages and you want to bui=
ld
            ^
Typo.

Otherwise LGTM.

>>>From 6ac1b059ef2c46ea6ac80070e6a49f79bdddbdc4 Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien@lepiller.eu>
> Date: Sat, 23 Mar 2019 19:22:37 +0100
> Subject: [PATCH 2/2] gnu: ocaml-alcotest: Update to 0.8.5.
>
> * gnu/packages/ocaml.scm (ocaml-alcotest): Update to 0.8.5.

LGTM!

Thank you,
Ludo=E2=80=99.