From: "Ludovic Courtès" <ludo@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 35110@debbugs.gnu.org
Subject: [bug#35110] [PATCH v2 1/2] Add (guix build-system linux-module).
Date: Thu, 11 Apr 2019 12:50:42 +0200 [thread overview]
Message-ID: <87ftqo3jel.fsf@gnu.org> (raw)
In-Reply-To: <20190405110550.24168-2-dannym@scratchpost.org> (Danny Milosavljevic's message of "Fri, 5 Apr 2019 13:05:49 +0200")
Hi Danny,
Danny Milosavljevic <dannym@scratchpost.org> skribis:
> * guix/build/linux-module-build-system.scm: New file.
> * guix/build-system/linux-module.scm: New file.
> * Makefile.am (MODULES): Add them.
Awesome!
> +(define* (configure #:key inputs #:allow-other-keys)
> + #t)
> +; (let ((source (string-append (assoc-ref inputs "linux")
> +; "/Module.symvers")))
> +; (if (file-exists? source)
> +; (install-file source out-lib-build))
> +; #t))
I think you should either remove this comment or add an explanation
and/or a TODO.
Could you also add a note in doc/guix.texi under “Build Systems”?
Otherwise LGTM, thank you!
Ludo’.
next prev parent reply other threads:[~2019-04-11 10:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 19:27 [bug#35110] [PATCH 0/3] Add support for loadable modules Danny Milosavljevic
2019-04-02 19:28 ` [bug#35110] [PATCH 1/3] gnu: Add make-linux-module Danny Milosavljevic
2019-04-02 19:28 ` [bug#35110] [PATCH 2/3] gnu: Add vhba-module-linux-libre Danny Milosavljevic
2019-04-02 21:51 ` Pierre Neidhardt
2019-04-02 22:36 ` Danny Milosavljevic
2019-04-03 6:48 ` Pierre Neidhardt
2019-04-02 19:28 ` [bug#35110] [PATCH 3/3] gnu: linux-libre: Disable module versioning Danny Milosavljevic
2019-04-03 20:16 ` [bug#35110] [PATCH 1/3] gnu: Add make-linux-module Ludovic Courtès
2019-04-03 20:48 ` Danny Milosavljevic
2019-04-04 7:48 ` Ludovic Courtès
2019-04-05 11:05 ` [bug#35110] [PATCH v2 0/2] Add support for loadable modules Danny Milosavljevic
2019-04-05 11:05 ` [bug#35110] [PATCH v2 1/2] Add (guix build-system linux-module) Danny Milosavljevic
2019-04-11 10:50 ` Ludovic Courtès [this message]
2019-04-11 15:53 ` bug#35110: " Danny Milosavljevic
2019-04-05 11:05 ` [bug#35110] [PATCH v2 2/2] gnu: Add vhba-module Danny Milosavljevic
2019-04-11 10:51 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftqo3jel.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=35110@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).