unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: "Nicolò Balzarotti" <anothersms@gmail.com>
Cc: 35388@debbugs.gnu.org
Subject: [bug#35388] [PATCH] gnu: julia: Update to 1.1.0
Date: Mon, 06 May 2019 10:43:11 +0200	[thread overview]
Message-ID: <87ftpsm0rk.fsf@gnu.org> (raw)
In-Reply-To: <20190425075114.10284-1-anothersms@gmail.com> ("Nicolò Balzarotti"'s message of "Thu, 25 Apr 2019 09:51:14 +0200")

Hi Nicolò,

Nicolò Balzarotti <anothersms@gmail.com> skribis:

> One second problem regards the llvm patches. They should be generic (as stated
> in the link in the patch, [2]) but are actually needed to compile julia (so I
> cannot use pure system llvm, but I don't feel like applying them to system
> llvm all by myself).

OK.

> The .patch files are available in the julia source package: is it ok to place them in the patches folder or shuld I fetch the julia source and extract them during build?

It would be best if they could be downloaded from upstream.  For that
you could use one ‘origin’ for each patch and use them directly in the
‘patches’ field.  Alternately, if that’s more convenient, you could add
one ‘origin’ for the whole repository, and add an ‘apply-patches’ to the
‘llvm-julia’ package that would pick patches in the right place.

Could you also try to provide a commit log listing all the changes that
this patch makes?  You can read ‘git log’ for examples or see
<https://www.gnu.org/software/guix/manual/en/html_node/Submitting-Patches.html>.

Other than that I think it should be ready to go, and I’m really happy a
newer Julia package is around the corner!

Thank you, and apologies for the delay!

Ludo’.

  reply	other threads:[~2019-05-06  8:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <0190423085235.21419-1-anothersms@gmail.com>
2019-04-25  7:51 ` [bug#35388] [PATCH] gnu: julia: Update to 1.1.0 Nicolò Balzarotti
2019-05-06  8:43   ` Ludovic Courtès [this message]
2019-05-27 14:26     ` Ludovic Courtès
2019-05-27 20:06       ` Nicolò Balzarotti
2019-07-21 10:43         ` Nicolò Balzarotti
2019-07-23 22:40           ` bug#35388: " Ludovic Courtès
2019-04-23  8:52 [bug#35388] " Nicolò Balzarotti
2019-04-23  9:49 ` Nicolò Balzarotti
2019-05-30 17:21 ` Jim Garrison

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftpsm0rk.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=35388@debbugs.gnu.org \
    --cc=anothersms@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).