From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:45812)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hZ9Ye-0003y2-No
 for guix-patches@gnu.org; Fri, 07 Jun 2019 03:45:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hZ9Yd-0005Up-Rr
 for guix-patches@gnu.org; Fri, 07 Jun 2019 03:45:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:37775)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hZ9Yd-0005Ue-Op
 for guix-patches@gnu.org; Fri, 07 Jun 2019 03:45:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hZ9Yc-0006DF-GK
 for guix-patches@gnu.org; Fri, 07 Jun 2019 03:45:03 -0400
Subject: [bug#35790] [PATCH] scripts: lint: Handle warnings with a record type.
Resent-Message-ID: <handler.35790.B35790.155989348423845@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <878suz27ke.fsf@gnu.org> <20190601183135.11882-1-mail@cbaines.net>
Date: Fri, 07 Jun 2019 09:44:33 +0200
In-Reply-To: <20190601183135.11882-1-mail@cbaines.net> (Christopher Baines's
 message of "Sat, 1 Jun 2019 19:31:35 +0100")
Message-ID: <87ftolj0v2.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 35790@debbugs.gnu.org

Hello,

Christopher Baines <mail@cbaines.net> skribis:

> Rather than emiting warnings directly to a port, have the checkers return=
 the
> warning or warnings.
>
> This makes it easier to use the warnings in different ways, for example,
> loading the data in to a database, as you can work with the <lint-warning>
> records directly, rather than having to parse the output to determine the
> package and location.

I like it!

Maybe we should just ignore the i18n issue for now and keep
already-translated messages in <lint-warning>.

One question I have: before, warnings would be emitted as we go; now, we
first collect all the warnings for a given package, and emit all of them
at once.  How does it look in terms of UX?

Perhaps an improvement would be to use SRFI-41 streams instead of lists
to address this issue, but=E2=80=A6 future work.  :-)

WDYT?

Ludo=E2=80=99.