From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:57106)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hqY7c-0006hJ-1O
 for guix-patches@gnu.org; Thu, 25 Jul 2019 03:25:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hqY7a-0006PY-U7
 for guix-patches@gnu.org; Thu, 25 Jul 2019 03:25:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:57717)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hqY7a-0006PM-Jz
 for guix-patches@gnu.org; Thu, 25 Jul 2019 03:25:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hqY7a-00080V-F1
 for guix-patches@gnu.org; Thu, 25 Jul 2019 03:25:02 -0400
Subject: bug#36804: [PATCH] gnu: Add xchm.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.36804.D36804.156403944330698.done@debbugs.gnu.org>
References: <20190725013515.6097-1-bit4bit@riseup.net>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <20190725013515.6097-1-bit4bit@riseup.net>
Date: Thu, 25 Jul 2019 09:23:52 +0200
Message-ID: <87ftmua86v.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: 36804-done@debbugs.gnu.org
Cc: "Jovany Leandro G.C" <bit4bit@riseup.net>


Hi,

thank you for your patch.

> * gnu/packages/ebook.scm (xchm): New variable.
> ---
>  gnu/packages/ebook.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>
> diff --git a/gnu/packages/ebook.scm b/gnu/packages/ebook.scm
> index cf424f285d..7c919710d4 100644
> --- a/gnu/packages/ebook.scm
> +++ b/gnu/packages/ebook.scm
> @@ -330,3 +330,31 @@ following formats:
>  @item XHTML
>  @end enumerate")
>      (license license:gpl2+)))
> +
> +(define-public xchm
> +  (package
> +    (name "xchm")
> +    (version "1.30")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://github.com/rzvncj/xCHM/archiv=
e/"
> +                                  version ".tar.gz"))
> +              (file-name (string-append name "-" version ".tar.gz"))

The project provides a bootstrapped tarball.  We avoid the =E2=80=9C/archiv=
e=E2=80=9D
URLs on Github as they may change over time.

> +              (sha256
> +               (base32
> +                "13733g2bz84a15z08qwhrdcn0ff6g9c0aabdn0kzvx0nanj9vra9"))=
))
> +    (build-system gnu-build-system)
> +    (inputs
> +     `(("wxwidgets" ,wxwidgets)
> +       ("chmlib" ,chmlib)))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ("autoconf" ,autoconf)
> +       ("automake" ,automake)
> +       ("libtool" ,libtool)
> +       ("gettext" ,gettext-minimal)))

When using the bootstrapped tarball most of these inputs are not needed.

> +    (home-page "https://github.com/rzvncj/xCHM")
> +    (synopsis "UNIX CHM Viewer")
> +    (description "xCHM is a cross-platform GPL frontend for CHMLIB writt=
en
> +with the wxWidgets framework.")

I have changed both synopsis and description.  We don=E2=80=99t usually men=
tion
UNIX, nor do we repeat the license or the inputs in the description.

You missed the import of (gnu packages wxwidgets), which makes me think
that you haven=E2=80=99t tried building this patch.

I have pushed this to the master branch with commit 7c0411879b after
including my changes.

Thanks!

--
Ricardo