[bug#37043] [PATCH] gnu: font-ibm-plex: Update to 2.0.0.

[bug#37043] [PATCH] gnu: font-ibm-plex: Update to 2.0.0.

[Alva]

The 1.0.1 release did not work, due to macOS junk files in the release zip.

* gnu/packages/fonts.scm (font-ibm-plex): Update to 2.0.0.
---
 gnu/packages/fonts.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 2dc1df45c8..1e28191ae1 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -26,6 +26,7 @@
 ;;; Copyright © 2019 Jens Mølgaard <jens@zete.tk>
 ;;; Copyright © 2019 Nicolas Goaziou <mail@nicolasgoaziou.fr>
 ;;; Copyright © 2019 Baptiste Strazzulla <bstrazzull@hotmail.fr>
+;;; Copyright © 2019 Alva <alva@skogen.is>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -63,7 +64,7 @@
 (define-public font-ibm-plex
   (package
     (name "font-ibm-plex")
-    (version "1.0.1")
+    (version "2.0.0")
     (source (origin
               (method url-fetch)
               (uri (string-append
@@ -71,7 +72,7 @@
                     "v" version "/OpenType.zip"))
               (sha256
                (base32
-                "0nzxw9z6waixslam248yr26ci3fbk83c7jf6m90hncnaj6zxx795"))))
+                "1lv65z3qnqgh2w36daf5wyz0ma9rg1qj9s9lzlnva8l7q3h8c9b8"))))
     (build-system font-build-system)
     (home-page "https://github.com/IBM/plex")
     (synopsis "IBM Plex typeface")
-- 
2.22.1

[bug#37043] [PATCH] gnu: font-ibm-plex: Update to 2.0.0.

[Tobias Geerinckx-Rice via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 438 bytes --]

Alva,

Alva 写道：
> The 1.0.1 release did not work, due to macOS junk files in the 
> release zip.
>
> * gnu/packages/fonts.scm (font-ibm-plex): Update to 2.0.0.

Thanks!

The patch and resulting output looks fine (although 2.0.0 is 
missing 1.0.1's auto-installend licence file), but could you 
explain what ‘did not work’ means here?  I'd assume it worked 
for others when it was merged.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

[bug#37043] [PATCH] gnu: font-ibm-plex: Update to 2.0.0.

[Alva]

> (although 2.0.0 is 
missing 1.0.1's auto-installend licence file)

I see that they have removed the root-level LICENSE.txt and instead added
license.txt (with the same contents) to each font subdirectory.
Should I do something about that? I

> could you explain what ‘did not work’ means here? 

Yes; instead of the actual font files, the package installed some HFS+ extended
attribute files, that reside in the __MACOSX directory included in the zip file.
This appears to have been a mistake[1] that was addressed in later releases.

I am new to Guix so I thought I'd look into that, and figured I could first
update the font to a release that doesn't have this issue.

[1] https://github.com/IBM/plex/issues/156

[bug#37043] [PATCH] gnu: font-ibm-plex: Update to 2.0.0.

[Tobias Geerinckx-Rice via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 10535 bytes --]

Alva,

Alva 写道：
>> (although 2.0.0 is 
> missing 1.0.1's auto-installend licence file)
>
> I see that they have removed the root-level LICENSE.txt and 
> instead added
> license.txt (with the same contents) to each font subdirectory.
> Should I do something about that? I

Such a straightforward name should probably be handled globally, 
not pollute the package.  I wonder whether making 
%license-file-regexp in (guix build gnu-build-system) would have 
any unintended consequences.  I don't immediately see any.

>> could you explain what ‘did not work’ means here? 
>
> Yes; instead of the actual font files, the package installed 
> some HFS+ extended
> attribute files, that reside in the __MACOSX directory included 
> in the zip file.
> This appears to have been a mistake[1] that was addressed in 
> later releases.

I'm still not following.  Here's[0] the full content of 1.0.1 on 
master.  I admit that I haven't checked whether every font file is 
actually valid ‘OpenType font data’, but file(1) seems to think 
so.

Are you saying that your ‘guix build font-ibm-plex’ output 
contain something else, something worse?  Maybe it only happens on 
certain (file) systems depending on the order in which directory 
entries are read.  Or something.

> I am new to Guix so I thought I'd look into that, and figured I 
> could first
> update the font to a release that doesn't have this issue.

(Guix-affecting) bug or not, an update's always welcome.  Thanks 
again :-)

Kind regards,

T G-R

[0]:
$ find 
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1 
-type f -exec file {} +
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/doc/font-ibm-plex-1.0.1/LICENSE.txt: 
UTF-8 Unicode text, with CRLF line terminators
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexMono-Regular.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSansCondensed-Light.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexMono-Light.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSans-SemiBoldItalic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSerif-SemiBoldItalic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexMono-Thin.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSansCondensed-BoldItalic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSans-ExtraLight.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSerif-ExtraLightItalic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSerif-Medium.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSans-TextItalic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSans-LightItalic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSerif-Italic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSerif-TextItalic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSerif-Text.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSansCondensed-Bold.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSerif-ExtraLight.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSansCondensed-SemiBold.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexMono-LightItalic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexMono-ExtraLight.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSansCondensed-Text.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSans-Light.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexMono-TextItalic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSerif-SemiBold.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSans-Italic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSans-Text.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSans-ThinItalic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexMono-SemiBold.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSansCondensed-ThinItalic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSansCondensed-ExtraLightItalic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSans-Regular.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSansCondensed-SemiBoldItalic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexMono-MediumItalic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSans-SemiBold.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSerif-ThinItalic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSerif-LightItalic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSansCondensed-LightItalic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSerif-Bold.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexMono-Medium.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSerif-BoldItalic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSans-Thin.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexMono-BoldItalic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSansCondensed-MediumItalic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSansCondensed-Thin.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSerif-MediumItalic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexMono-Bold.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSerif-Regular.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexMono-ExtraLightItalic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSansCondensed-Regular.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSans-Medium.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexMono-ThinItalic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexMono-Italic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSans-ExtraLightItalic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSerif-Thin.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexMono-SemiBoldItalic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSansCondensed-TextItalic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexMono-Text.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSerif-Light.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSans-Bold.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSansCondensed-Medium.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSans-BoldItalic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSans-MediumItalic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSansCondensed-Italic.otf: 
OpenType font data
/gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1/share/fonts/opentype/IBMPlexSansCondensed-ExtraLight.otf: 
OpenType font data

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

[bug#37043] [PATCH] gnu: font-ibm-plex: Update to 2.0.0.

[Alva]

> Are you saying that your ‘guix build font-ibm-plex’ output 
> contain something else, something worse?  Maybe it only happens on 
> certain (file) systems depending on the order in which directory 
> entries are read.

Sorry, I have not yet familiarised myself with the build system(s), so I didn't
consider the possibility that the installed files could differ between systems,
hence the lacking description of the issue.

Yes, my output is different; it contains a number of files that have the
same names as yours, except prefixed with "._", which file(1) identifies as
AppleDouble encoded Macintosh files, and LICENSE.txt is missing.
These files come from the aforementioned __MACOSX directory in the 1.0.1 zip.
I'm using btrfs, FWIW.

> I wonder whether making 
> %license-file-regexp in (guix build gnu-build-system) would have 
> any unintended consequences.  I don't immediately see any.

I can try it and see. :)

[bug#37043] [PATCH] gnu: font-ibm-plex: Update to 2.0.0.

[Alva]

> I wonder whether making 
> %license-file-regexp in (guix build gnu-build-system) would have 
> any unintended consequences. 

My brain added "case-insensitive"; I don't know if that's what you meant. :)
Anyway, I checked the regexp, and `[Ll]icen[cs]e.*` already matches license.txt,
so I don't know where it goes wrong. 

bug#37043: [PATCH] gnu: font-ibm-plex: Update to 2.0.0.

[Tobias Geerinckx-Rice via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 1888 bytes --]

Alva,

Alva 写道：
>> I wonder whether making 
>> %license-file-regexp in (guix build gnu-build-system) would 
>> have 
>> any unintended consequences. 
>
> My brain added "case-insensitive"; I don't know if that's what 
> you meant. :)

Your brain is absolutely right; mine's still in holiday mode.  :-)

> Anyway, I checked the regexp, and `[Ll]icen[cs]e.*` already 
> matches license.txt,
> so I don't know where it goes wrong.

Not sure what's going on then.

> Yes, my output is different; it contains a number of files that 
> have the
> same names as yours, except prefixed with "._", which file(1) 
> identifies as
> AppleDouble encoded Macintosh files, and LICENSE.txt is missing.
> These files come from the aforementioned __MACOSX directory in 
> the 1.0.1 zip.
> I'm using btrfs, FWIW.

S'oh boy.  My previous ‘good’ output was built on ext4.  Here's 
what building 1.0.1 on btrfs (and 4 cores) gave me.  Safe to say 
this package isn't exactly deterministic there.

  $ guix describe
    Generation 28   Aug 16 2019 15:11:34    (current)
    …
      guix 4cc5e52
        repository URL: https://git.savannah.gnu.org/git/guix.git
        branch: master
        commit: 4cc5e5204b503afb4536a1e93e2fd7a9f57f12bf

  $ tree `guix build font-ibm-plex`
  /gnu/store/xzxyn6sij2j1sdp9a1p2lg4xwxifhl63-font-ibm-plex-1.0.1
  └── share
      └── fonts
          └── opentype

  3 directories, 0 files

  $

That's 3 very different possible outcomes so far.  My emptiness is 
reproducible on this machine, though.

I've pushed your patch (without the note about it not working 
since It's Complicated and there's no need to justify a bump 
anyway) as 93b3ef1966f9860ae88b87263f8c7f6052565c3f.  It's now 
reproducible on all my file systems, but feel free to try more. 
Thanks!

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]