unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: ison <ison@airmail.cc>
Cc: 37076-done@debbugs.gnu.org
Subject: bug#37076: Contributing package wterm
Date: Sun, 25 Aug 2019 22:43:31 +0200	[thread overview]
Message-ID: <87ftlpvuvg.fsf@gnu.org> (raw)
In-Reply-To: <20190818205811.hcthypxpronmeb4d@cf0> (ison@airmail.cc's message of "Sun, 18 Aug 2019 14:58:12 -0600")

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

Hello ison,

ison <ison@airmail.cc> skribis:

>>From 3597ca9e62e004a27adff73ebfa572d41089a74d Mon Sep 17 00:00:00 2001
> From: ison <ison@airmail.cc>
> Date: Sun, 18 Aug 2019 14:48:04 -0600
> Subject: [PATCH] Add package wterm to terminals.scm
>
> ---
>  gnu/packages/terminals.scm | 53 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 53 insertions(+)

Applied with the simple changes below and with a commit log that follows
our convention.

Thanks for the patch!

Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1146 bytes --]

diff --git a/gnu/packages/terminals.scm b/gnu/packages/terminals.scm
index fbd0bff843..bca8b14dad 100644
--- a/gnu/packages/terminals.scm
+++ b/gnu/packages/terminals.scm
@@ -1120,7 +1120,7 @@ while also supporting native scrolling and @command{tmux} control mode
        (sha256
          (base32
           "0g4lzmc1w6na81i6hny32xds4xfig4xzswzfijyi6p93a1226dv0"))
-       (file-name (git-file-name name version ))))
+       (file-name (git-file-name name version))))
     (build-system gnu-build-system)
     (native-inputs
      `(("pkg-config" ,pkg-config)))
@@ -1134,8 +1134,11 @@ while also supporting native scrolling and @command{tmux} control mode
        ("wayland" ,wayland)))
     (arguments
      '(#:tests? #f
-       #:make-flags (list "-j1" ; Without -j1 it fails to find file libwld.a
-                          "CC=gcc"
+
+       ;; Without -j1 it fails to find file libwld.a.
+       #:parallel-build? #f
+
+       #:make-flags (list "CC=gcc"
                           (string-append "PREFIX=" %output)
                           (string-append "TERMINFO="
                                          (assoc-ref %outputs "out")

      reply	other threads:[~2019-08-25 20:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-18 20:58 [bug#37076] Contributing package wterm ison
2019-08-25 20:43 ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftlpvuvg.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=37076-done@debbugs.gnu.org \
    --cc=ison@airmail.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).