From: "Ludovic Courtès" <ludo@gnu.org>
To: Reza Alizadeh Majd <r.majd@pantherx.org>
Cc: 37708-done@debbugs.gnu.org
Subject: bug#37708: [PATCH] gnu: add uchardet
Date: Sat, 12 Oct 2019 15:16:53 +0200 [thread overview]
Message-ID: <87ftjyf6ii.fsf@gnu.org> (raw)
In-Reply-To: <7721cc22-fc20-41ab-affb-3a44d0947746@pantherx.org> (Reza Alizadeh Majd's message of "Sat, 12 Oct 2019 01:48:08 +0330")
[-- Attachment #1: Type: text/plain, Size: 529 bytes --]
Hi Reza,
Reza Alizadeh Majd <r.majd@pantherx.org> skribis:
> From 5bbab834e617c0bfb14d384e05af390d05728b6e Mon Sep 17 00:00:00 2001
> From: Reza Alizadeh Majd <r.majd@pantherx.org>
> Date: Fri, 11 Oct 2019 23:23:21 +0330
> Subject: [PATCH] gnu: add uchardet
>
> * gnu/packages/freedesktop.scm (uchardet) New variable.
Applied with the modifications below, which address ‘guix lint’ warnings
(remember to run it next time :-)), enable tests, and clarify the
license.
Thank you for the patch!
Ludo’.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1450 bytes --]
diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index 17736aa537..4339f14f35 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -1423,16 +1423,18 @@ their MIME type.
(source
(origin
(method url-fetch)
- (uri (string-append "https://www.freedesktop.org/software/"
+ (uri (string-append "https://www.freedesktop.org/software/"
name "/releases/" name "-" version ".tar.xz"))
(sha256
(base32 "0q9c02b6nmw41yfsiqsnphgc3f0yg3fj31wkccp47cmwvy634lc3"))))
(build-system cmake-build-system)
- (arguments `(#:tests? #f))
(home-page "https://www.freedesktop.org/wiki/Software/uchardet/")
- (synopsis "encoding detector library")
- (description "uchardet is an encoding detector library, which takes a
-sequence of bytes in an unknown character encoding without any additional
-information, and attempts to determine the encoding of the text. Returned
+ (synopsis "Encoding detector library")
+ (description "uchardet is an encoding detector library, which takes a
+sequence of bytes in an unknown character encoding without any additional
+information, and attempts to determine the encoding of the text. Returned
encoding names are iconv-compatible.")
+
+ ;; This combines code under MPL 1.1, LGPL 2.1+, and GPL 2.0+, so the
+ ;; combination is GPL 2.0+.
(license license:gpl2+)))
next prev parent reply other threads:[~2019-10-12 13:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 20:21 [bug#37708] [PATCH] gnu: add uchardet Reza Alizadeh Majd
2019-10-12 8:17 ` Jonathan Brielmaier
2019-10-12 8:49 ` Reza Alizadeh Majd
[not found] ` <7721cc22-fc20-41ab-affb-3a44d0947746@pantherx.org>
2019-10-12 13:16 ` Ludovic Courtès [this message]
2019-10-12 14:48 ` Reza Alizadeh Majd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftjyf6ii.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=37708-done@debbugs.gnu.org \
--cc=r.majd@pantherx.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).