From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:59933) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iTuoV-0004MX-UA for guix-patches@gnu.org; Sun, 10 Nov 2019 16:32:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iTuoU-0005GC-QL for guix-patches@gnu.org; Sun, 10 Nov 2019 16:32:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:43919) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iTuoU-0005G8-MC for guix-patches@gnu.org; Sun, 10 Nov 2019 16:32:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iTuoU-00060r-I5 for guix-patches@gnu.org; Sun, 10 Nov 2019 16:32:02 -0500 Subject: [bug#38129] [PATCH] gnu: Add sherlock-lv2. Resent-Message-ID: From: Marius Bakke In-Reply-To: <57b24a50e1feeed51edf264b6bb97480@posteo.net> References: <57b24a50e1feeed51edf264b6bb97480@posteo.net> Date: Sun, 10 Nov 2019 22:31:07 +0100 Message-ID: <87ftivl8pw.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Alexandros Theodotou , 38129@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Alexandros, Thanks for these patches. I think your MUA might have mangled these patches somehow, as many of them are "corrupt" according to git. Can you try to resend these? I'll comment on the patches individually meanwhile. Alexandros Theodotou writes: > From 5207795bcce201e019c33bb0274e06a460cf6c3f Mon Sep 17 00:00:00 2001 > From: Alexandros Theodotou > Date: Fri, 8 Nov 2019 10:59:52 +0000 > Subject: [PATCH] gnu: Add sherlock-lv2. > > * gnu/packages/music.scm: (sherlock-lv2): New variable. [...] > +(define-public sherlock-lv2 > + (package > + (name "sherlock-lv2") > + (version "0.20.0") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "https://git.open-music-kontrollers.ch/lv2/" > + "sherlock.lv2/snapshot/sherlock.lv2-" > + version ".tar.xz")) > + (sha256 > + (base32 > + "1c5xajpss9h8lbyx160bbzg8va50n2d74qwnxig9sf468rzmha1y")))) > + (build-system meson-build-system) > + (inputs > + `(("glibc" ,glibc) I don't think this is needed? > + ("libx11" ,libx11) > + ("mesa" ,mesa) > + ("serd" ,serd) > + ("sratom" ,sratom))) > + (native-inputs > + `(("flex" ,flex) > + ("lv2" ,lv2) > + ("sord" ,sord) I don't know anything about LV2 and sord, are these inputs really only used for the build process itself? :-) > + ("pkg-config" ,pkg-config))) > + (synopsis "Investigative LV2 plugin bundle") > + (description "The Sherlock plugin bundle contains LV2 plugins for > +visualizing LV2 atom, MIDI and OSC events. They can be used for=20 > monitoring and > +debugging of event signal flows inside plugin graphs.") Two spaces after periods, as per 'guix lint'. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl3IgZsACgkQoqBt8qM6 VPq0ggf/TYthl+Lr7qU9+9CpDCgFVovxuj3U0V1oYFp+IeI3wONo2m8lhe5vNVuc WpWLRITuxLI/tRBdD/QCL66t/SC0ceixdnwgOvi2SKiqef3vzvfoUcMwjvqrmN2O 8dNPOJ4eqqkcmS28TAvzWUPDC5bVIySBdpU0yriv7tgLeMEzptN/BEVpYUVeOS3C iUoo7claM+edV9TQfDUihpXjschlFXKpq/upia1VhBLSvCc2trJJgjHji07QrFgn x6IkICC2+GLy8j0Y1sFzUyiUytq5BU/VqlCzmEvgjxbL6pFe8VfiIQT+z5tb9z7x 7FKUaKrNjpWiUFShnj/LAmQe3YI1wg== =ExMR -----END PGP SIGNATURE----- --=-=-=--