unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <marius@gnu.org>
To: Josh Holland <josh@inv.alid.pw>, 41594-done@debbugs.gnu.org
Cc: Josh Holland <josh@inv.alid.pw>
Subject: bug#41594: [PATCH] gnu: bemenu: Update to 0.4.1.
Date: Sat, 30 May 2020 16:27:19 +0200	[thread overview]
Message-ID: <87ftbhzeew.fsf@gnu.org> (raw)
In-Reply-To: <20200529091439.388824-1-josh@inv.alid.pw>

[-- Attachment #1: Type: text/plain, Size: 642 bytes --]

Josh Holland <josh@inv.alid.pw> writes:

> * gnu/packages/xdisorg.scm (bemenu): Update to 0.4.1.

Applied, thanks!

> ---
> I'm not 100% sure that the CFLAGS setting is correct, but without
> -fPIC the build fails.  Upstream changed their build system, and now
> we do not need to explicitly enable the Wayland backend.

This is because lib/3rdparty/cdl.a is built statically, and needs to be
embedded into the shared libbemenu.so.0.  It's odd that the Makefile
does not add -fPIC for us though, can you file an upstream bug?

Ideally we'd build cdl separately as a shared library and provide it as
an input, then -fPIC would be unnecessary.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

      reply	other threads:[~2020-05-30 14:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-29  9:14 [bug#41594] [PATCH] gnu: bemenu: Update to 0.4.1 Josh Holland
2020-05-30 14:27 ` Marius Bakke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftbhzeew.fsf@gnu.org \
    --to=marius@gnu.org \
    --cc=41594-done@debbugs.gnu.org \
    --cc=josh@inv.alid.pw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).