From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id UGd5H/Yp5V53BwAA0tVLHw (envelope-from ) for ; Sat, 13 Jun 2020 19:33:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id IIJ5G/Yp5V6XegAA1q6Kng (envelope-from ) for ; Sat, 13 Jun 2020 19:33:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0ABE89404C5 for ; Sat, 13 Jun 2020 19:33:10 +0000 (UTC) Received: from localhost ([::1]:51952 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkBts-0000nD-Fd for larch@yhetil.org; Sat, 13 Jun 2020 15:33:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60992) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkBtl-0000mz-Pk for guix-patches@gnu.org; Sat, 13 Jun 2020 15:33:01 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59206) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jkBtl-0005VJ-QI for guix-patches@gnu.org; Sat, 13 Jun 2020 15:33:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jkBtl-0001ak-Mg for guix-patches@gnu.org; Sat, 13 Jun 2020 15:33:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#39258] [PATCH 2/4] ui: Use string matching with literal search strings. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 13 Jun 2020 19:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39258 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Arun Isaac Cc: 39258@debbugs.gnu.org, zimoun Received: via spool by 39258-submit@debbugs.gnu.org id=B39258.15920767726103 (code B ref 39258); Sat, 13 Jun 2020 19:33:01 +0000 Received: (at 39258) by debbugs.gnu.org; 13 Jun 2020 19:32:52 +0000 Received: from localhost ([127.0.0.1]:42519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkBtb-0001aM-V5 for submit@debbugs.gnu.org; Sat, 13 Jun 2020 15:32:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52730) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkBta-0001a9-20 for 39258@debbugs.gnu.org; Sat, 13 Jun 2020 15:32:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34110) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkBtT-0005MU-F5; Sat, 13 Jun 2020 15:32:43 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=45556 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jkBtR-0006QA-7W; Sat, 13 Jun 2020 15:32:42 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200601000030.7443-1-arunisaac@systemreboot.net> <20200601000030.7443-3-arunisaac@systemreboot.net> <87y2owmyf3.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 26 Prairial an 228 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 13 Jun 2020 21:32:37 +0200 In-Reply-To: (Arun Isaac's message of "Sat, 13 Jun 2020 18:07:45 +0530") Message-ID: <87ftayzrqi.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: 0XZLsphSAVY0 Hi, Arun Isaac skribis: >>> * guix/scripts/package.scm (process-query): Make search query a regexp = only if >>> it is not a literal search string. >>> * guix/ui.scm (relevance): Use string matching with literal search stri= ngs and >>> regexp matching with regexp search strings. >> >> How does this affect performance? (To be clear, I=E2=80=99m referring specifically to this patch.) > See my results from earlier. > > time ./pre-inst-env guix search game > > real 0m2.261s > user 0m2.351s > sys 0m0.104s > > time guix search game > > real 0m2.661s > user 0m2.843s > sys 0m0.080s > >> I would expect the regexp engine in libc to do something similar >> internally, so I wonder if the extra work in Scheme pays off. > > I agree it would better to do this optimization at the regexp engine, if > it doesn't do it already. Yeah. I feel like we shouldn=E2=80=99t have to do this, so I=E2=80=99d lea= n towards excluding this patch from the series. It=E2=80=99s too early to be confide= nt about it, but it might be something as discussed in , i.e., a problem to solve at the Guile level. > So, shall I push the remaining patches (patches 1, 3, 4) after applying > the change you suggested for patch 1 (use of if versus cond)? Yes, definitely! Thank you, Ludo=E2=80=99.