From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 0D15FDGA9177eQAA0tVLHw (envelope-from ) for ; Sat, 27 Jun 2020 17:21:53 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id uN13EDGA914cEgAAbx9fmQ (envelope-from ) for ; Sat, 27 Jun 2020 17:21:53 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8889A94051D for ; Sat, 27 Jun 2020 17:21:52 +0000 (UTC) Received: from localhost ([::1]:44586 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpEWT-00011D-On for larch@yhetil.org; Sat, 27 Jun 2020 13:21:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jpENy-0003uL-CI for guix-patches@gnu.org; Sat, 27 Jun 2020 13:13:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:32974) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jpENy-0007XC-1y for guix-patches@gnu.org; Sat, 27 Jun 2020 13:13:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jpENx-0008DL-Sr for guix-patches@gnu.org; Sat, 27 Jun 2020 13:13:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42056] [PATCH] gnu: Add xloadimage. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 27 Jun 2020 17:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42056 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brice Waegeneire Cc: 42056@debbugs.gnu.org Received: via spool by 42056-submit@debbugs.gnu.org id=B42056.159327797231545 (code B ref 42056); Sat, 27 Jun 2020 17:13:01 +0000 Received: (at 42056) by debbugs.gnu.org; 27 Jun 2020 17:12:52 +0000 Received: from localhost ([127.0.0.1]:44520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpENk-0008Cf-9d for submit@debbugs.gnu.org; Sat, 27 Jun 2020 13:12:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49192) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpENf-0008CM-5K for 42056@debbugs.gnu.org; Sat, 27 Jun 2020 13:12:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59316) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpENY-0007Vz-ON; Sat, 27 Jun 2020 13:12:36 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=37614 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jpENW-00013w-33; Sat, 27 Jun 2020 13:12:35 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200626095606.29923-1-brice@waegenei.re> Date: Sat, 27 Jun 2020 19:12:32 +0200 In-Reply-To: <20200626095606.29923-1-brice@waegenei.re> (Brice Waegeneire's message of "Fri, 26 Jun 2020 11:56:06 +0200") Message-ID: <87ftagl9fj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: 7+9e0I7GaGSw Hi Brice, Brice Waegeneire skribis: > * gnu/packages/xorg.scm (xloadimage): New variable. > * gnu/packages/patches/xloadimage-debian-series-25.patch: New file =E2=80= =A6 > * gnu/local.mk (dist_patch_DATA): =E2=80=A6 add it. [...] > +++ b/gnu/packages/patches/xloadimage-debian-series-25.patch > @@ -0,0 +1,7665 @@ > +Combined patches from Debian: https://sources.debian.org/patches/xloadim= age/4.1-25/ We should keep =E2=80=99em separated, for clarity. However: > +Index: xloadimage.4.1.old/Makefile.in > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > +--- /dev/null > ++++ xloadimage.4.1.old/Makefile.in [...] > +--- /dev/null > ++++ xloadimage.4.1.old/configure > +@@ -0,0 +1,2476 @@ > ++#! /bin/sh > ++ > ++# Guess values for system-dependent variables and create Makefiles. > ++# Generated automatically using autoconf version 2.13=20 > ++# Copyright (C) 1992, 93, 94, 95, 96 Free Software Foundation, Inc. This adds an Autoconf-generated =E2=80=98configure=E2=80=99 file. IOW, it = seems we=E2=80=99re adding a complete build system that=E2=80=99s not available upstream. It seems to me that it=E2=80=99s too much. It would be okay to add a coupl= e of Makefile.in and a minimalist =E2=80=98configure.ac=E2=80=99, if they=E2=80= =99re small, and from there to run the bootstrap phase. It would be better to try and use upstream=E2=80=99s build system though. Thoughts? Ludo=E2=80=99.