From: "Ludovic Courtès" <ludo@gnu.org>
To: Brice Waegeneire <brice@waegenei.re>
Cc: 42056@debbugs.gnu.org
Subject: [bug#42056] [PATCH] gnu: Add xloadimage.
Date: Sat, 27 Jun 2020 19:12:32 +0200 [thread overview]
Message-ID: <87ftagl9fj.fsf@gnu.org> (raw)
In-Reply-To: <20200626095606.29923-1-brice@waegenei.re> (Brice Waegeneire's message of "Fri, 26 Jun 2020 11:56:06 +0200")
Hi Brice,
Brice Waegeneire <brice@waegenei.re> skribis:
> * gnu/packages/xorg.scm (xloadimage): New variable.
> * gnu/packages/patches/xloadimage-debian-series-25.patch: New file …
> * gnu/local.mk (dist_patch_DATA): … add it.
[...]
> +++ b/gnu/packages/patches/xloadimage-debian-series-25.patch
> @@ -0,0 +1,7665 @@
> +Combined patches from Debian: https://sources.debian.org/patches/xloadimage/4.1-25/
We should keep ’em separated, for clarity.
However:
> +Index: xloadimage.4.1.old/Makefile.in
> +===================================================================
> +--- /dev/null
> ++++ xloadimage.4.1.old/Makefile.in
[...]
> +--- /dev/null
> ++++ xloadimage.4.1.old/configure
> +@@ -0,0 +1,2476 @@
> ++#! /bin/sh
> ++
> ++# Guess values for system-dependent variables and create Makefiles.
> ++# Generated automatically using autoconf version 2.13
> ++# Copyright (C) 1992, 93, 94, 95, 96 Free Software Foundation, Inc.
This adds an Autoconf-generated ‘configure’ file. IOW, it seems we’re
adding a complete build system that’s not available upstream.
It seems to me that it’s too much. It would be okay to add a couple of
Makefile.in and a minimalist ‘configure.ac’, if they’re small, and from
there to run the bootstrap phase.
It would be better to try and use upstream’s build system though.
Thoughts?
Ludo’.
prev parent reply other threads:[~2020-06-27 17:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 9:56 [bug#42056] [PATCH] gnu: Add xloadimage Brice Waegeneire
2020-06-27 17:12 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftagl9fj.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=42056@debbugs.gnu.org \
--cc=brice@waegenei.re \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).