From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id KEOhB3ZX+17PTgAA0tVLHw (envelope-from ) for ; Tue, 30 Jun 2020 15:17:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id KCeUA3ZX+16SfAAAB5/wlQ (envelope-from ) for ; Tue, 30 Jun 2020 15:17:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 94D79940223 for ; Tue, 30 Jun 2020 15:17:09 +0000 (UTC) Received: from localhost ([::1]:59000 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jqI0Q-0002H1-V6 for larch@yhetil.org; Tue, 30 Jun 2020 11:17:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36800) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jqI0M-0002FQ-9A for guix-patches@gnu.org; Tue, 30 Jun 2020 11:17:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39912) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jqI0L-0007U7-W3 for guix-patches@gnu.org; Tue, 30 Jun 2020 11:17:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jqI0L-0006M9-Px for guix-patches@gnu.org; Tue, 30 Jun 2020 11:17:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42048] [PATCH 3/6] channels: Remove 'signature' from . Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 30 Jun 2020 15:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42048 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ricardo Wurmus Cc: 42048@debbugs.gnu.org Received: via spool by 42048-submit@debbugs.gnu.org id=B42048.159353017024371 (code B ref 42048); Tue, 30 Jun 2020 15:17:01 +0000 Received: (at 42048) by debbugs.gnu.org; 30 Jun 2020 15:16:10 +0000 Received: from localhost ([127.0.0.1]:51458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jqHzW-0006L0-Fu for submit@debbugs.gnu.org; Tue, 30 Jun 2020 11:16:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jqHzS-0006KH-7V for 42048@debbugs.gnu.org; Tue, 30 Jun 2020 11:16:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51275) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jqHzM-0007OW-NA; Tue, 30 Jun 2020 11:16:00 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=46168 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jqHzM-0000X2-6r; Tue, 30 Jun 2020 11:16:00 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200625211605.29316-1-ludo@gnu.org> <20200625211605.29316-3-ludo@gnu.org> <871rlwoc4d.fsf@elephly.net> Date: Tue, 30 Jun 2020 17:15:56 +0200 In-Reply-To: <871rlwoc4d.fsf@elephly.net> (Ricardo Wurmus's message of "Tue, 30 Jun 2020 16:35:14 +0200") Message-ID: <87ftac60ur.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: 2OM+BQ6/xqwd Hi, Ricardo Wurmus skribis: > Ludovic Court=C3=A8s writes: > >> In the end signing the commit/key pair does not buy us much. Someone >> publishing a valid but different commit/key pair would effectively be >> publishing a different channel, which could be a fork (made by a former >> authorized developer) or simply a mirror. In the latter case, there's >> nothing to be gained by publishing a different commit/key pair. >> >> * guix/channels.scm ()[signature]: Remove. >> (make-channel-introduction): Adjust accordingly. >> --- > [=E2=80=A6] >> (define (make-channel-introduction commit signer) >> "Return a new channel introduction: COMMIT is the introductory where >> authentication starts, and SIGNER is the OpenPGP fingerprint (a bytevec= tor) of >> the signer of that commit." >> - (%make-channel-introduction commit signer #f)) >> + (%make-channel-introduction commit signer)) > > Do we still need this procedure at all? Looks like > %make-channel-introduction could simply be renamed to make-channel-introd= uction. =E2=80=98%make-channel-introduction=E2=80=99 is actually a macro, which is = thus inlined. Exporting a procedure makes it easier to preserve ABI compatibility and allow for future extensions (keyword parameters, for instance). Ludo=E2=80=99.