From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id cMOlOlFTbF8NYQAA0tVLHw (envelope-from ) for ; Thu, 24 Sep 2020 08:05:37 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id AHbGNlFTbF8PRgAAbx9fmQ (envelope-from ) for ; Thu, 24 Sep 2020 08:05:37 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EEE39940224 for ; Thu, 24 Sep 2020 08:05:36 +0000 (UTC) Received: from localhost ([::1]:59950 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLMFz-00029h-1u for larch@yhetil.org; Thu, 24 Sep 2020 04:05:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47238) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLMCa-0000aU-2u for guix-patches@gnu.org; Thu, 24 Sep 2020 04:02:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55241) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kLMCY-00043N-FP for guix-patches@gnu.org; Thu, 24 Sep 2020 04:02:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kLMCY-0006jY-CH for guix-patches@gnu.org; Thu, 24 Sep 2020 04:02:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43540] [PATCH] Instantiate nscd in each system container instead of using the container host's service. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 24 Sep 2020 08:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43540 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jason Conroy Cc: 43540@debbugs.gnu.org Received: via spool by 43540-submit@debbugs.gnu.org id=B43540.160093448925839 (code B ref 43540); Thu, 24 Sep 2020 08:02:02 +0000 Received: (at 43540) by debbugs.gnu.org; 24 Sep 2020 08:01:29 +0000 Received: from localhost ([127.0.0.1]:38554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLMC0-0006ig-Sk for submit@debbugs.gnu.org; Thu, 24 Sep 2020 04:01:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLMBy-0006iT-Dl for 43540@debbugs.gnu.org; Thu, 24 Sep 2020 04:01:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57463) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLMBt-00040N-3r; Thu, 24 Sep 2020 04:01:21 -0400 Received: from [2a01:e0a:19b:d9a0:b888:25b1:7546:eb44] (port=34118 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kLMBq-0007oF-Sq; Thu, 24 Sep 2020 04:01:20 -0400 From: Mathieu Othacehe References: Date: Thu, 24 Sep 2020 10:01:16 +0200 In-Reply-To: (Jason Conroy's message of "Sun, 20 Sep 2020 18:05:02 -0400") Message-ID: <87ft777gdv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: 5jjwl7mrei+X Hello Jason, Thanks for this patch. You need to write a commit message that is compliant with the ChangeLog format, see: https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html. > +(define %nscd-container-caches > + ;; Similar to %nscd-default-caches but with smaller cache sizes. This allows > + ;; many containers to coexist on the same machine without exhausting RAM. > + (list (nscd-cache (database 'hosts) > + (positive-time-to-live (* 3600 12)) > + (negative-time-to-live 20) > + (persistent? #t) > + (max-database-size (expt 2 18))) > + (nscd-cache (database 'services) > + (positive-time-to-live (* 3600 24)) > + (negative-time-to-live 3600) > + (check-files? #t) ;check /etc/services changes > + (persistent? #t) > + (max-database-size (expt 2 18))))) You can write something like: --8<---------------cut here---------------start------------->8--- (map (lambda (cache) (nscd-cache (inherit cache) (max-database-size (expt 2 18)))) ;256KiB %nscd-default-caches) --8<---------------cut here---------------end--------------->8--- to avoid repeating the same values. Otherwise, looks nice. Could you please send an updated version? Thanks, Mathieu -- https://othacehe.org