From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 6BnAELbEhl8RbAAA0tVLHw (envelope-from ) for ; Wed, 14 Oct 2020 09:28:22 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id YNOhDLbEhl/yOQAAbx9fmQ (envelope-from ) for ; Wed, 14 Oct 2020 09:28:22 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C5AEF940222 for ; Wed, 14 Oct 2020 09:28:21 +0000 (UTC) Received: from localhost ([::1]:33946 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSd52-0007m3-6H for larch@yhetil.org; Wed, 14 Oct 2020 05:28:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45728) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kScx0-0004Xo-M6 for guix-patches@gnu.org; Wed, 14 Oct 2020 05:20:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38518) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kScx0-0006RH-BU for guix-patches@gnu.org; Wed, 14 Oct 2020 05:20:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kScx0-0000mL-80 for guix-patches@gnu.org; Wed, 14 Oct 2020 05:20:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43881] [PATCH 2/2] install: Deduplicate packages with %base-package sets. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 14 Oct 2020 09:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43881 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: 43881@debbugs.gnu.org Received: via spool by 43881-submit@debbugs.gnu.org id=B43881.16026671552930 (code B ref 43881); Wed, 14 Oct 2020 09:20:02 +0000 Received: (at 43881) by debbugs.gnu.org; 14 Oct 2020 09:19:15 +0000 Received: from localhost ([127.0.0.1]:50064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kScwE-0000lB-Ks for submit@debbugs.gnu.org; Wed, 14 Oct 2020 05:19:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kScwC-0000ky-V1 for 43881@debbugs.gnu.org; Wed, 14 Oct 2020 05:19:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54910) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kScw7-0006KQ-On; Wed, 14 Oct 2020 05:19:07 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=60216 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kScw6-0007hG-Bh; Wed, 14 Oct 2020 05:19:07 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20201009134253.26375-1-efraim@flashner.co.il> <20201009134253.26375-2-efraim@flashner.co.il> Date: Wed, 14 Oct 2020 11:19:05 +0200 In-Reply-To: <20201009134253.26375-2-efraim@flashner.co.il> (Efraim Flashner's message of "Fri, 9 Oct 2020 16:42:53 +0300") Message-ID: <87ft6hf9me.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: 3IrpRex5LGVa Efraim Flashner skribis: > * gnu/system.scm (%base-packages-interactive): Add nvi. > * gnu/system/install.scm (installation-os)[packages]: Remove parted, > gptfdisk, ddrescue, cryptsetup, mdadm, dosfstools, btrfs-progs, > f2fs-tools, jfstools, openssh, wireless-tools, iw, > wpa-supplicant-minimal, iproute, bash-completion, nvi. Replace glibc > with the canonical-package of glibc. Add %base-packages-disk-utils. > > remove wpa-supplicant-minimal > replace glibc with canonical-pacakge glibc These two lines are a leftover? I think we want to keep =E2=80=98wpa-supplicant-minimal=E2=80=99 and keep = =E2=80=98glibc=E2=80=99, not the canonical-package variant (it would prevent cross-compilation). Apart from that, if that leaves the package set unchanged, LGTM! Ludo=E2=80=99.