[-- Attachment #1: Type: text/plain, Size: 134 bytes --] Hello, This patch updates emacs-julia-mode to the latest commit from https://github.com/JuliaEditorSupport/julia-emacs Thanks, Tim [-- Attachment #2: 0001-gnu-emacs-julia-mode-Update-to-0.4-0.8ea90c7.patch --] [-- Type: text/x-patch, Size: 2089 bytes --] From 3271943c18c93317d89869d9882ae69e6a0677aa Mon Sep 17 00:00:00 2001 From: Tim Howes <timhowes@lavabit.com> Date: Mon, 12 Oct 2020 23:12:29 -0700 Subject: [PATCH] gnu: emacs-julia-mode: Update to 0.4-0.8ea90c7. * gnu/packages/emacs-xyz.scm (emacs-julia-mode): Update to 0.4-0.8ea90c7. --- gnu/packages/emacs-xyz.scm | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 0c49d72cc2..9508d1475e 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -81,6 +81,7 @@ ;;; Copyright © 2020 Niklas Eklund <niklas.eklund@posteo.net> ;;; Copyright © 2020 Marco Grassi <marco.au.grassi98@protonmail.com> ;;; Copyright © 2020 Tomás Ortín Fernández <tomasortin@mailbox.org> +;;; Copyright © 2020 Tim Howes <timhowes@lavabit.com> ;;; ;;; This file is part of GNU Guix. ;;; @@ -7731,13 +7732,12 @@ E-Prime forbids the use of the \"to be\" form to strengthen your writing.") (license license:gpl3+)))) (define-public emacs-julia-mode - ;; XXX: Upstream version remained stuck at 0.3. See - ;; <https://github.com/JuliaEditorSupport/julia-emacs/issues/46>. - (let ((commit "115d4dc8a07445301772da8376b232fa8c7168f4") - (revision "1")) + (let ((commit "8ea90c7927f6d87a291cfb0216f34dacf43c722e") + (version "0.4") + (revision "0")) (package (name "emacs-julia-mode") - (version (string-append "0.3-" revision "." (string-take commit 8))) + (version (git-version version revision commit)) (source (origin (method git-fetch) @@ -7747,7 +7747,7 @@ E-Prime forbids the use of the \"to be\" form to strengthen your writing.") (file-name (git-file-name name version)) (sha256 (base32 - "1is4dcv6blslpzbjcg8l2jpxi8xj96q4cm0nxjxsyswpm8bw8ki0")))) + "1ymanbalx41xri5kiqs83a80a72yr9831if6cz2m24pg3g7rwr9c")))) (build-system emacs-build-system) (arguments `(#:tests? #t -- 2.28.0
Hello,
Tim Howes via Guix-patches via <guix-patches@gnu.org> writes:
> This patch updates emacs-julia-mode to the latest commit from
> https://github.com/JuliaEditorSupport/julia-emacs
Thank you.
Is there any reason not to use regular 0.4 release from March? If so,
could you explain it in a comment?
Regards,
--
Nicolas Goaziou
[-- Attachment #1: Type: text/plain, Size: 320 bytes --] It seemed like the previous package definition used the latest commit, but I guess that was because they had not yet put out a tagged release. https://github.com/JuliaEditorSupport/julia-emacs/issues/46 The tagged release from March should work fine. Should it keep the revision and commit ID as part of the version? [-- Attachment #2: v2-0001-gnu-emacs-julia-mode-Update-to-0.4-0.8bfc709.patch --] [-- Type: text/x-patch, Size: 2092 bytes --] From 6975b12dfe2478acf19a299be1942c68a40868ca Mon Sep 17 00:00:00 2001 From: Tim Howes <timhowes@lavabit.com> Date: Thu, 15 Oct 2020 19:52:04 -0700 Subject: [PATCH v2] gnu: emacs-julia-mode: Update to 0.4-0.8bfc709. * gnu/packages/emacs-xyz.scm (emacs-julia-mode): Update to 0.4-0.8bfc709. --- gnu/packages/emacs-xyz.scm | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index e3e61e3141..2392c48295 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -81,6 +81,7 @@ ;;; Copyright © 2020 Niklas Eklund <niklas.eklund@posteo.net> ;;; Copyright © 2020 Marco Grassi <marco.au.grassi98@protonmail.com> ;;; Copyright © 2020 Tomás Ortín Fernández <tomasortin@mailbox.org> +;;; Copyright © 2020 Tim Howes <timhowes@lavabit.com> ;;; ;;; This file is part of GNU Guix. ;;; @@ -7786,13 +7787,12 @@ E-Prime forbids the use of the \"to be\" form to strengthen your writing.") (license license:gpl3+)))) (define-public emacs-julia-mode - ;; XXX: Upstream version remained stuck at 0.3. See - ;; <https://github.com/JuliaEditorSupport/julia-emacs/issues/46>. - (let ((commit "115d4dc8a07445301772da8376b232fa8c7168f4") - (revision "1")) + (let ((commit "8bfc709716a257521cb386f20b8932e83db930a9") + (version "0.4") + (revision "0")) (package (name "emacs-julia-mode") - (version (string-append "0.3-" revision "." (string-take commit 8))) + (version (git-version version revision commit)) (source (origin (method git-fetch) @@ -7802,7 +7802,7 @@ E-Prime forbids the use of the \"to be\" form to strengthen your writing.") (file-name (git-file-name name version)) (sha256 (base32 - "1is4dcv6blslpzbjcg8l2jpxi8xj96q4cm0nxjxsyswpm8bw8ki0")))) + "1w131jb9mhvyjxa0p93iwfhzidgbcs6b8i6jg79yisqb9wchik99")))) (build-system emacs-build-system) (arguments `(#:tests? #t -- 2.28.0
Tim Howes via Guix-patches via <guix-patches@gnu.org> writes: > > The tagged release from March should work fine. Should it keep the > revision and commit ID as part of the version? > Using tagged releases is preferred. I would remove the commit let-binding and go about it using version numbering. -- Brett M. Gilio brettg@gnu.org https://brettgilio.com/ E82A C026 95D6 FF02 43CA 1E5C F6C5 2DD1 BA27 CB87
[-- Attachment #1: Type: text/plain, Size: 212 bytes --] Brett Gilio writes: > Using tagged releases is preferred. I would remove the commit > let-binding and go about it using version numbering. OK, sounds good. Here it is using just the version tag. Thanks, Tim [-- Attachment #2: v3-0001-gnu-emacs-julia-mode-Update-to-0.4.patch --] [-- Type: text/x-patch, Size: 2356 bytes --] From 56fb736e24782937283eda7a3c4ea6b25c2d1014 Mon Sep 17 00:00:00 2001 From: Tim Howes <timhowes@lavabit.com> Date: Thu, 15 Oct 2020 19:52:04 -0700 Subject: [PATCH v3] gnu: emacs-julia-mode: Update to 0.4. * gnu/packages/emacs-xyz.scm (emacs-julia-mode): Update to 0.4. --- gnu/packages/emacs-xyz.scm | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index e3e61e3141..d2fb4aaadb 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -81,6 +81,7 @@ ;;; Copyright © 2020 Niklas Eklund <niklas.eklund@posteo.net> ;;; Copyright © 2020 Marco Grassi <marco.au.grassi98@protonmail.com> ;;; Copyright © 2020 Tomás Ortín Fernández <tomasortin@mailbox.org> +;;; Copyright © 2020 Tim Howes <timhowes@lavabit.com> ;;; ;;; This file is part of GNU Guix. ;;; @@ -7786,23 +7787,19 @@ E-Prime forbids the use of the \"to be\" form to strengthen your writing.") (license license:gpl3+)))) (define-public emacs-julia-mode - ;; XXX: Upstream version remained stuck at 0.3. See - ;; <https://github.com/JuliaEditorSupport/julia-emacs/issues/46>. - (let ((commit "115d4dc8a07445301772da8376b232fa8c7168f4") - (revision "1")) (package (name "emacs-julia-mode") - (version (string-append "0.3-" revision "." (string-take commit 8))) + (version "0.4") (source (origin (method git-fetch) (uri (git-reference (url "https://github.com/JuliaEditorSupport/julia-emacs") - (commit commit))) + (commit version))) (file-name (git-file-name name version)) (sha256 (base32 - "1is4dcv6blslpzbjcg8l2jpxi8xj96q4cm0nxjxsyswpm8bw8ki0")))) + "1w131jb9mhvyjxa0p93iwfhzidgbcs6b8i6jg79yisqb9wchik99")))) (build-system emacs-build-system) (arguments `(#:tests? #t @@ -7813,7 +7810,7 @@ E-Prime forbids the use of the \"to be\" form to strengthen your writing.") (synopsis "Major mode for Julia") (description "This Emacs package provides a mode for the Julia programming language.") - (license license:expat)))) + (license license:expat))) (define-public emacs-smex (package -- 2.28.0
Dear, On Fri, 16 Oct 2020 at 21:33, Brett Gilio <brettg@gnu.org> wrote: > Using tagged releases is preferred. I would remove the commit > let-binding and go about it using version numbering. It is currently the convention and uniformity matters. :-) But IMHO it is bad practise. Using commit hash enforces content-addressed, which is obviously not the case with "tags". Tags are fragile for upstream in-place replacement, for example. For reference, [1] and BTW all the thread is worth to read. :-) 1: <https://lists.gnu.org/archive/html/guix-devel/2020-05/msg00236.html> All the best, simon
Hi Tim,
Tim Howes <timhowes@lavabit.com> skribis:
>>From 56fb736e24782937283eda7a3c4ea6b25c2d1014 Mon Sep 17 00:00:00 2001
> From: Tim Howes <timhowes@lavabit.com>
> Date: Thu, 15 Oct 2020 19:52:04 -0700
> Subject: [PATCH v3] gnu: emacs-julia-mode: Update to 0.4.
>
> * gnu/packages/emacs-xyz.scm (emacs-julia-mode): Update to 0.4.
Applied, thanks! And sorry for the delay.
Ludo’.