From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id mA8tEkLxql/lHgAA0tVLHw (envelope-from ) for ; Tue, 10 Nov 2020 20:00:02 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id fhTvDULxql8FewAAbx9fmQ (envelope-from ) for ; Tue, 10 Nov 2020 20:00:02 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 99D66940111 for ; Tue, 10 Nov 2020 20:00:01 +0000 (UTC) Received: from localhost ([::1]:51900 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcZo8-0004zz-Ig for larch@yhetil.org; Tue, 10 Nov 2020 15:00:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58464) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcZmE-0002vh-It for guix-patches@gnu.org; Tue, 10 Nov 2020 14:58:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:55663) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kcZmE-0003gS-A7 for guix-patches@gnu.org; Tue, 10 Nov 2020 14:58:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kcZmE-000056-8s for guix-patches@gnu.org; Tue, 10 Nov 2020 14:58:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44191] gnu: Add kristall Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 10 Nov 2020 19:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44191 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: =?UTF-8?Q?Nicol=C3=B2?= Balzarotti Cc: 44191@debbugs.gnu.org, nicolo@nixo.xyz Received: via spool by 44191-submit@debbugs.gnu.org id=B44191.1605038281303 (code B ref 44191); Tue, 10 Nov 2020 19:58:02 +0000 Received: (at 44191) by debbugs.gnu.org; 10 Nov 2020 19:58:01 +0000 Received: from localhost ([127.0.0.1]:38976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcZmD-0008WV-BZ for submit@debbugs.gnu.org; Tue, 10 Nov 2020 14:58:01 -0500 Received: from mira.cbaines.net ([212.71.252.8]:39638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcZmB-0008WN-Jx for 44191@debbugs.gnu.org; Tue, 10 Nov 2020 14:58:00 -0500 Received: from localhost (188.28.119.85.threembb.co.uk [188.28.119.85]) by mira.cbaines.net (Postfix) with ESMTPSA id 6F46F27BBF6; Tue, 10 Nov 2020 19:57:58 +0000 (GMT) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 358183be; Tue, 10 Nov 2020 19:57:56 +0000 (UTC) References: <8736233h7h.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> <87o8kqab7i.fsf@cbaines.net> <87tuui1ce2.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> <87imaxym37.fsf@cbaines.net> <87sga0n9ew.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> <87o8knn6rm.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> <87sg9uxhtc.fsf@cbaines.net> <87k0v2ycgd.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> User-agent: mu4e 1.4.13; emacs 27.1 From: Christopher Baines In-reply-to: <87k0v2ycgd.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> Date: Tue, 10 Nov 2020 19:57:51 +0000 Message-ID: <87ft5hougw.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -3.11 X-TUID: A/r7YgvYEU2a --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Nicol=C3=B2 Balzarotti writes: > Christopher Baines writes: >> >> Given this is a stylesheet, rather than cmark, I don't think it's a >> blocker, although I do think it would be neater to have a package for >> it. >> > Would it be better to at least pass it's origin as an input? > > #+begin_src scheme > ("breeze-stylesheet" > ,(origin > (method git-fetch) > (uri > (git-reference > (url "https://github.com/Alexhuszagh/BreezeStyleSheets") > (commit "2d595a956f8a5f493aa51139a470b768a6d82cce"))) > (file-name (git-file-name name version)) > (sha256 > (base32 > "1kvkxkisi3czldnb43ig60l55pi4a3m2a4ixp7krhpf9fc5wp294")))) > #+end_src > > I'm ok with making a package for it, but in that case I'm not sure what > to do. I think I'd use the copy-build-system, right? Should the package > be hidden? I don't mind, I think it's OK as is. >> I've made some more comments below, and I wanted to enquire about >> exactly how the fonts are used, but I think this is pretty much ready to >> merge. >> >> I'd maybe use symlink rather than copy file, since you want the fonts to >> be used from the respective packages in the store, however, is this just >> to satisfy the build system? It looks to me like the XDG_DATA_DIRS >> wrapping is probably what'll make the fonts work at runtime (if >> anything)? > > Regarding fonts, > I tried removing both from the inputs, and emojis at this page [1] > rendered just fine. > Should I just remove them from the inputs and let the user install them? > The code tries to load them with the relative path: > > #+begin_src cpp > // Provide OpenMoji font for a safe fallback > QFontDatabase::addApplicationFont(":/fonts/OpenMoji-Color.ttf"); > QFontDatabase::addApplicationFont(":/fonts/NotoColorEmoji.ttf"); > #+end_src > > This function fails silently (The function returns -1 if the font could > not be loaded.) and the error code is not checked, so we don't even need > to patch kristall source for this. If there's an expectation or a use in making sure these fonts are available, it would be good to patch the relative paths to be the absolute paths within the font-openmoji package. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl+q8L9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XfWqxAAsQ0fQ1536/c/794nMRRYnTgXniYT+1VB Gnwe18SvlMT+No4GhVPlcU2+bJxd+/dyNJbeNmMEGm8tFxgbf948n64SvEYjTCrA hg7toI3LYwF0HqD5jvaAhC6PTydGhb/OkuudldtAIgek4GZoCZQ1KM9huOJQj8PL SOkZMD8tsBtZ2MKqoYI2SduKK/LI/eB2Zo4vxO73sX3lYsAFEN6twGLMIUENJylr E17HX2d1/IVgvE8C1K+9JfWmQX8l6Bo7ic98LI0U5yXZsTVWQRxpkIe/ckGv6ZE4 jRA5JhG+NDue0rOGCQKWLo+exEEorvplF0IcGESXDyo15DsYDWFoRvmpBLR21zJ8 255S2/C2qFGhaN6X6INbmm/swcEvkHSNw2DqdFh7FzzNK6NIOJyJTtkMEpcI4yKA 2kGtQLnPp3XFvhMTEj8yQPxmTqHdAE+basMUshKn7W2Oj+qugYgj1xLpfSSqgml/ h4UOVvyTe1mNFkTQtKEOGoP45EfyzSoRQwTt3dZw9ldvJ8SIDC5UO2CScICeobqv 7IwVsXgG5O5UWqTIEEzC2BSCEui94l0fmAX1h7cniWLzHL1xAUj9uf3dRSysOxul 3AYqjxM6x/z/mb+5FkdfAKY7zI0qcxUfrPNoftc8elRSJnUG2kP9bT8TrBB/b8AY bfWJBPfvFjk= =pmCC -----END PGP SIGNATURE----- --=-=-=--