From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id OJZWNU5DVGBJfQAA0tVLHw (envelope-from ) for ; Fri, 19 Mar 2021 06:23:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id UIocMU5DVGCiWgAAbx9fmQ (envelope-from ) for ; Fri, 19 Mar 2021 06:23:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2EA9314145 for ; Fri, 19 Mar 2021 07:23:10 +0100 (CET) Received: from localhost ([::1]:41496 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lN8XM-0000rg-N0 for larch@yhetil.org; Fri, 19 Mar 2021 02:23:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57430) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lN8XG-0000rM-UB for guix-patches@gnu.org; Fri, 19 Mar 2021 02:23:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37023) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lN8XG-0000cs-ND for guix-patches@gnu.org; Fri, 19 Mar 2021 02:23:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lN8XG-0002fL-KE for guix-patches@gnu.org; Fri, 19 Mar 2021 02:23:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47182] [PATCH 00/18] Add support for powerpc64le-linux (wip-ppc64le-for-master) Resent-From: Chris Marusich Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 19 Mar 2021 06:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47182 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: Leo Le Bouter , 47182@debbugs.gnu.org Received: via spool by 47182-submit@debbugs.gnu.org id=B47182.161613496310193 (code B ref 47182); Fri, 19 Mar 2021 06:23:02 +0000 Received: (at 47182) by debbugs.gnu.org; 19 Mar 2021 06:22:43 +0000 Received: from localhost ([127.0.0.1]:48563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lN8Wx-0002eL-8n for submit@debbugs.gnu.org; Fri, 19 Mar 2021 02:22:43 -0400 Received: from mail-pf1-f174.google.com ([209.85.210.174]:40664) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lN8Wv-0002e8-Da for 47182@debbugs.gnu.org; Fri, 19 Mar 2021 02:22:41 -0400 Received: by mail-pf1-f174.google.com with SMTP id l3so5176182pfc.7 for <47182@debbugs.gnu.org>; Thu, 18 Mar 2021 23:22:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=knvyBE2Ji9VTFs9aVn5jeg7SgchrXe2eqrqEQAQjlBE=; b=omX0G9pNrrqHQyHfggkmTNPpOPYQ1PV1c7ju/k1zDQhrDg82rEoHVMdrnE/E/WpnY9 HlwhIJuUvHSxcGtAo50+15asoEgRHHX1xyAPu5p45bbnNVfgqIz4n1vnS2sNHQL3kD5g 2oKe8fjRRXS1lpzVu0dO2Sg/xASMy6f5Gkt4fbTVVJQ1/qgsIbyNpz0dCpVRTFb/flZ9 QJxPqEnUcMNd1IHjtpnQfttG9Wx7SXWqYciFTX7cbB4j8DBXp56u4oKdhUsdju9TPj7b 3cQVEXhFeVJbB5DyY77OeY1rg2TmquwR3sHNWZHuQjDSz0zRaP+UXwpH+Fehznw9S8lb E1VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=knvyBE2Ji9VTFs9aVn5jeg7SgchrXe2eqrqEQAQjlBE=; b=nZOEtao6BR7PY1f5ByAskY5dEkwMtfTXWoTImUcA4jFTiHN0KP/LKh106O9VEFhQMR /Utl34NU2zT66737TaM+hly9H9PP8vjJoQfb4YahlxRXf6R1qNjwKTy75sMLB/6D7OgX ELUjoGxK/yEUWYc0dEhqoeGkv9OtDgsfWUmiH5UrsJ5w6fqXtaMRM2mXyAgpVN9WuTZr hhULqo5cQB6zN5iyPCtU/3u1f0m3fr55AAVQYSOWH1edDspeGveER/6YX7d1ueH7JMbd zb10AFrcJaehpq5O14vxNiqPTRmIyzt+gelbu1twXaoATfpP8gX8zrvz3DpxXZGXTAJ2 75iQ== X-Gm-Message-State: AOAM530OXs0ER+ltbMGrM0Juu6L2CZWsf+g8Qt8cVkZMfiYAITtWFONk 0O0CtTIO8Rkr8M6q9RbNdhe+bDMvjIc= X-Google-Smtp-Source: ABdhPJx+f/QIFI7Ipvm25Pn63TRsMvJ64X63FzDgsLVII/E/V/4qREOyw9ih8ZKjf7XDN8n9htBr0g== X-Received: by 2002:a63:f14e:: with SMTP id o14mr10711446pgk.260.1616134954907; Thu, 18 Mar 2021 23:22:34 -0700 (PDT) Received: from garuda-lan (c-24-18-44-142.hsd1.wa.comcast.net. [24.18.44.142]) by smtp.gmail.com with ESMTPSA id w2sm3944480pgh.54.2021.03.18.23.22.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 23:22:33 -0700 (PDT) From: Chris Marusich References: <20210316062805.2890883-1-cmmarusich@gmail.com> <20210316064511.2891553-1-cmmarusich@gmail.com> <20210316064511.2891553-10-cmmarusich@gmail.com> <87h7l9m1g8.fsf_-_@gmail.com> Date: Thu, 18 Mar 2021 23:22:29 -0700 In-Reply-To: (Efraim Flashner's message of "Thu, 18 Mar 2021 10:34:09 +0200") Message-ID: <87ft0r1x3u.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616134990; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=knvyBE2Ji9VTFs9aVn5jeg7SgchrXe2eqrqEQAQjlBE=; b=NL+SVoXHQMZy90xnj+WzSEydx1ufL2m5y+0f25E6pDZ+St+ByNnJs76H6z3bEpBJcHezaM Xy3TCWOiyxEBGdoZF70V/wxcwxHzpifz8YR6A99LP3PcoGAtKfzEgfrX7n3MCu2rQfM0su bHtMG2p4o1D1e6cudQZANNcJIUSsokiPX7/inqexjUIBYE5rJMK700+sB6XYidK9UJjgDQ aqh8fReqaQi4rW5UyibiGJok5UnSLGdLSoiLLWbxdcVGLOB6f+3cTE9zC5RZV3ohhxSg4x fb5oxKXjBhLdsylfMRrOg5OVL/RXN/AdfsPSx/Xe/QpVbOh7poY1dzx3/1WiSg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616134990; a=rsa-sha256; cv=none; b=nQ9y35qstkg/MDhoe7SLGm5fr3tEWvJlN70d9uplM+saLyuMWaO+nAU770y+0/qc134jMr Zy+Eo3wTopgtEfafoINqblRKRV1U9Z+VMWm7VJe7ePmJs9BLK7BcwpW7OP5rlKcOmOazq+ o2YJybwjolZapOpcVvHPTWsKvByspp2Nx+oZPqMd8LsqbzLUWUUM77pa6hjEqtv9aVRIjo fuK8lIVw1voXFkHND/931FRMfokAflbMIW/gi6bDJ4cEVgr8ZOt4fMrPqI/RC7fok1ctz7 BwYh7yx7WMXOY2Hn7rpNJvP0jx7fu2NQ+cVk0jcmRGRNTjOayzsTByuJquvE4Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=omX0G9pN; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -0.91 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=omX0G9pN; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 2EA9314145 X-Spam-Score: -0.91 X-Migadu-Scanner: scn0.migadu.com X-TUID: Dw40BQw60YzZ --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Efraim Flashner writes: > On Wed, Mar 17, 2021 at 11:16:07PM -0700, Chris Marusich wrote: >> Efraim Flashner writes: >>=20 >> >> #:tests? ,(let ((s (or (%current-target-system) >> >> (%current-system)))) >> >> (not (or (string-prefix? "aarch64" s) >> >> - (string-prefix? "mips64" s)))) >> >> + (string-prefix? "mips64" s) >> >> + (string-prefix? "powerpc64le" s)))) >> >> + >> > >> > we can probably change this to use cute in core-updates. I don't know = if >> > changing it here will cause rebuilds on aarch64. >>=20 >> The result of unquoting the expression will be either #t or #f, >> depending on the system. For an aarch64 system, the string s hasn't >> changed (it'll still start with "aarch64", right?). Therefore, my >> understanding is that this change here will not alter the package >> definition; it will still say "#:tests? #f", just like it did before, on >> an aarch64 system. Is there something else I'm missing? >>=20 > > I like the way it looks better if we use something like > > #:tests? ,(if (any (cute string-prefix? <> (or (%current-target-system) > (%current-system))) > '("aarch64" "powerpc64le" "mips64")) > '#f '#t) Both forms achieve the same result. I honestly think either would be fine. Therefore, I don't intend to change the commit corresponding to this specific patch. However, if you went and changed it per above, I wouldn't mind at all. =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmBUQyUVHGNtbWFydXNp Y2hAZ21haWwuY29tAAoJEN1AmhXYIkadRxIQALfYErBSNiFIM5q2Lwu0/w47rM9D vQvLfl6h3svzR3DmhRI0abcKzTTrAtXlUBqa0dND6duGULUjfqKNTL/gFBUziY2k P94O5ZomK4873WYeZLftwaUjOniGDCp/AR/8pI+MiY91OZeFOs65w2XgbFfA43rr +/W94qG9EsNeBFWrGFhafGZ+Z9Czz82CZsrRa81DQte+AMpzNu/dEvjyh+igRLxn +liP/URhD1oVk4RwlmuyJsUnhO+azzp2zucfF2S8+ZsWmbVN+fZ1bZkIFJJZsymt +seVwkrJzoOZYmMzJjpjy7y1V+vq+SZQnTl5Z/UQFHEXsAjto0EkNca2WxDB18gc cCpxLOoNl8MvbP6ErMZC//UbcLaGINUnB86zNgwNm8Ad0840CylTfxUe8/iqici4 DSCM+iupDR35LhM9czHCpn7FjlJPB55UEhGCIruwxpRSmz6GMmcynKp5cdwVMdcn sKXgcT4iNa2x7IRtEE3gTHOmjcwOnE1b5VPdk32U/FXqQumI0Vcq3kD2h19Ldh/J QSEhItaPRnTCr5mq+rS55FngTqOLWi8u9fQyaHANrqngrUYLeufwd/Dta+jGobdQ xbiJVpcLGmqlQhNR/Z3gEfNuJgYbMV2tyXwbgzkvhPg2Iq5IyNWml7VLCl5c7OmO /AarNwEoL7TPkk20 =+XNG -----END PGP SIGNATURE----- --=-=-=--