From: Kyle Meyer <kyle@kyleam.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Ricardo Wurmus <rekado@elephly.net>, 49252@debbugs.gnu.org
Subject: [bug#49252] [PATCH] Channels defaulting to HEAD instead of ‘master’
Date: Thu, 08 Jul 2021 20:38:45 -0400 [thread overview]
Message-ID: <87fswo8goa.fsf@kyleam.com> (raw)
In-Reply-To: <87y2auw3jo.fsf@inria.fr>
Ludovic Courtès writes:
> For the record, commit cb41c15827a2e910aa56fb5d1917ba8a085c95c7 by Kyle
> (Cc’d) gives the ability to use the remote HEAD by default, which is
> exactly what we need here.
>
> Unfortunately, for the Guix repo at Savannah, I get:
>
> --8<---------------cut here---------------start------------->8---
> $ ./pre-inst-env guix time-machine -- describe
> guix time-machine: error: Git error: reference 'refs/remotes/origin/HEAD' not found
> --8<---------------cut here---------------end--------------->8---
>
> … but it works for <https://github.com/guix-mirror/guix>.
>
> Presumably we have a server-side setup issue at Savannah?
Hmm, it looks like it's there:
$ git ls-remote https://git.savannah.gnu.org/git/guix.git | grep HEAD
e499500730de23fd54ae63696a725d4b90a406d7 HEAD
$ git clone https://git.savannah.gnu.org/git/guix.git && cd guix
$ git for-each-ref refs/remotes/origin | grep HEAD
e499500730de23fd54ae63696a725d4b90a406d7 commit refs/remotes/origin/HEAD
$ git name-rev refs/remotes/origin/HEAD
refs/remotes/origin/HEAD master
This might be a long shot, but if you cloned the repo with magit-clone,
it has some custom logic that deletes refs/remotes/<remote>/HEAD unless
magit-clone-set-remote-head is non-nil (and it's nil by default).
> Are there downsides, or cases where it might pick the wrong branch?
The main downside I can think of is what I mentioned in bug#45187
(87v9d8dk0r.fsf@kyleam.com):
[The remote HEAD symref] probably the best indicator of what the
primary branch is. In a clone, it doesn't necessarily match HEAD on
the remote, because users may change it to another branch they're
interested in, but that isn't really relevant to these
behind-the-scenes checkouts.
So, if it's a user-facing clone, refs/remotes/origin/HEAD isn't a
reliable indicator because users are free to redirect the remote HEAD
symref to another branch of interest [*] or to delete it altogether.
I think channel clones would fall into the "behind the scenes" category,
though, right?
[*] This is discussed here:
https://lore.kernel.org/git/xmqqlfivwvtw.fsf@gitster.c.googlers.com/
next prev parent reply other threads:[~2021-07-09 0:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 12:56 [bug#49252] [PATCH] Channels defaulting to HEAD instead of ‘master’ Ludovic Courtès
2021-07-09 0:38 ` Kyle Meyer [this message]
2021-08-04 15:04 ` Ludovic Courtès
2021-08-08 23:28 ` Kyle Meyer
2021-08-09 9:12 ` Ludovic Courtès
2021-08-10 2:10 ` Kyle Meyer
2021-08-10 8:04 ` Ludovic Courtès
2021-08-11 0:34 ` Kyle Meyer
2021-08-08 13:53 ` Ricardo Wurmus
2021-08-08 23:08 ` Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fswo8goa.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=49252@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).