unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Arun Isaac <arunisaac@systemreboot.net>
To: Sarah Morgensen <iskarian@mgsn.dev>, 49705@debbugs.gnu.org
Subject: [bug#49705] [PATCH] gnu: gmnisrv: Fix configure flags.
Date: Sun, 25 Jul 2021 19:53:45 +0530	[thread overview]
Message-ID: <87fsw2fp5a.fsf@systemreboot.net> (raw)
In-Reply-To: <7109666ab6ca0797c583fe62942342a9b0a1be89.1627027028.git.iskarian@mgsn.dev>

[-- Attachment #1: Type: text/plain, Size: 668 bytes --]


Hi Sarah,

Thank you for improving our gmnisrv package!

> +         #:make-flags '("CC=gcc")))

This should be (list (string-append "CC=" ,(cc-for-target))) so that the
package cross-compiles correctly. Hard-coding CC=gcc is now deprecated
practice.

I also feel that this patch should be split into at least two patches or
maybe even three. This way, the first line summary in the commit message
is much more descriptive of the change.

1. gnu: gmnisrv: Remove dependency on /etc/mime.types.
2. gnu: gmnisrv: Cross-compile.
3. gnu: gmnisrv: Disable tests using tests?.

WDYT? Feel free to combine patches 2 and 3 if that splitting is a bit
excessive.

Thanks,
Arun

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 524 bytes --]

  reply	other threads:[~2021-07-25 14:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-23  8:07 [bug#49705] [PATCH] gnu: gmnisrv: Fix configure flags Sarah Morgensen
2021-07-25 14:23 ` Arun Isaac [this message]
2021-07-25 20:37 ` [bug#49705] [PATCH v2 0/4] " Sarah Morgensen
2021-07-25 20:39   ` [bug#49705] [PATCH v2 1/4] gnu: gmnisrv: Disable tests using #:tests? Sarah Morgensen
2021-07-25 20:39   ` [bug#49705] [PATCH v2 2/4] gnu: gmnisrv: Use #:make-flags, and cross-compile Sarah Morgensen
2021-07-25 20:39   ` [bug#49705] [PATCH v2 3/4] gnu: gmnisrv: Remove dependency on /etc/mime.types Sarah Morgensen
2021-07-25 20:39   ` [bug#49705] [PATCH v2 4/4] gnu: gmnisrv: Fix configuration search path Sarah Morgensen
2021-07-26 21:18   ` bug#49705: [PATCH v2 0/4] gnu: gmnisrv: Fix configure flags Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsw2fp5a.fsf@systemreboot.net \
    --to=arunisaac@systemreboot.net \
    --cc=49705@debbugs.gnu.org \
    --cc=iskarian@mgsn.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).